Re: Automatic deployment changes

2013-05-22 Thread Mark Thomas
On 21/05/2013 23:42, Konstantin Kolinko wrote: Finally trying to find some time to review this... 1) Is there an intent to put [4] into some version-controlled place? E.g. webapps/docs/architecture/ ? Or essentials of it will be included as part of config/context.html ? I see some rows

Re: Automatic deployment changes

2013-05-22 Thread Christopher Schultz
Mark, On 5/17/13 3:04 PM, Mark Thomas wrote: On 16/05/2013 21:50, Mark Thomas wrote: The final (for now) changes are: 1. unpackWARs now applies to external WARs as well as WARs located in the Host's appBase. 2. If a WAR is modified (located in the Host's appBase or externally) and

Re: Automatic deployment changes

2013-05-22 Thread Christopher Schultz
Mark, On 5/17/13 3:25 PM, Mark Thomas wrote: On 17/05/2013 20:22, Caldarale, Charles R wrote: From: Mark Thomas [mailto:ma...@apache.org] Subject: Re: Automatic deployment changes 3. A warning is generate if a DIR in the appBase is ignored because there is a matching WAR and unpackWARs

Re: Automatic deployment changes

2013-05-22 Thread Mark Thomas
On 22/05/2013 17:48, Christopher Schultz wrote: Mark, On 5/17/13 3:04 PM, Mark Thomas wrote: 4. Adding an XML or WAR when just a DIR exists will trigger a redeploy. If a WAR is added and unpackWARs==true, the DIR will be replaced. 5. If a WAR or DIR is added to an XML, a reload will

Re: Automatic deployment changes

2013-05-22 Thread Mark Thomas
On 22/05/2013 17:50, Christopher Schultz wrote: Mark, On 5/17/13 3:25 PM, Mark Thomas wrote: On 17/05/2013 20:22, Caldarale, Charles R wrote: From: Mark Thomas [mailto:ma...@apache.org] Subject: Re: Automatic deployment changes 3. A warning is generate if a DIR in the appBase is ignored

Re: Automatic deployment changes

2013-05-21 Thread Konstantin Kolinko
2013/5/7 Mark Thomas ma...@apache.org: There have been a few queries [1], [2] recently and there is a long standard enhancement request [3] regarding automatic deployment. What has made changes in this area difficult in the past is a) a lack of a clear definition as to what the expected

Re: Automatic deployment changes

2013-05-17 Thread Mark Thomas
On 16/05/2013 21:50, Mark Thomas wrote: The final (for now) changes are: 1. unpackWARs now applies to external WARs as well as WARs located in the Host's appBase. 2. If a WAR is modified (located in the Host's appBase or externally) and there is a context.xml file present in the Host's

RE: Automatic deployment changes

2013-05-17 Thread Caldarale, Charles R
From: Mark Thomas [mailto:ma...@apache.org] Subject: Re: Automatic deployment changes 3. A warning is generate if a DIR in the appBase is ignored because there is a matching WAR and unpackWARs==false. The doc at [1] contains this statement: Note: After deployment, if both a WAR and a DIR

Re: Automatic deployment changes

2013-05-17 Thread Mark Thomas
On 17/05/2013 20:22, Caldarale, Charles R wrote: From: Mark Thomas [mailto:ma...@apache.org] Subject: Re: Automatic deployment changes 3. A warning is generate if a DIR in the appBase is ignored because there is a matching WAR and unpackWARs==false. The doc at [1] contains this statement

Re: Automatic deployment changes

2013-05-16 Thread Mark Thomas
The changes have changed. The new changes are: 1. unpackWARs now applies to external WARs as well as WARs located in the Host's appBase. 2. If a WAR is modified (located in the Host's appBase or externally) and there is a context.xml file present in the Host's appBase (which there must be for

RE: Automatic deployment changes

2013-05-16 Thread Caldarale, Charles R
From: Mark Thomas [mailto:ma...@apache.org] Subject: Re: Automatic deployment changes 2. If a WAR is modified (located in the Host's appBase or externally) and there is a context.xml file present in the Host's appBase (which there must be for external WARs) Just to be clear, do you mean

Re: Automatic deployment changes

2013-05-16 Thread Mark Thomas
On 16/05/2013 22:05, Caldarale, Charles R wrote: From: Mark Thomas [mailto:ma...@apache.org] Subject: Re: Automatic deployment changes 2. If a WAR is modified (located in the Host's appBase or externally) and there is a context.xml file present in the Host's appBase (which there must

Re: Automatic deployment changes

2013-05-15 Thread Mark Thomas
On 14/05/2013 20:55, Christopher Schultz wrote: On 5/13/13 3:35 AM, Mark Thomas wrote: I've updated the proposal to cover these. Cool. Having all the rules in one place will be tremendously helpful to users. Even if they disagree with the rules, they will at least be predictable without

Automatic deployment changes

2013-05-15 Thread Mark Thomas
I have been implementing tests for the proposed behaviour [1] and I have found the first difference between the current and the proposed behaviour. Given there have been no objections to [1], I intend to align 8.0.x's behaviour with the proposal. As I find differences I will update this list to

Re: Automatic deployment changes

2013-05-14 Thread Christopher Schultz
Mark, On 5/13/13 3:35 AM, Mark Thomas wrote: On 08/05/2013 15:18, Christopher Schultz wrote: Perhaps I should clarify my question with an example: what happens when a WAR file is found and a DIR also exists with the same context name, but expandWars is false? Does the directory get updated

Re: Automatic deployment changes

2013-05-08 Thread Christopher Schultz
Mark, On 5/7/13 5:05 PM, Mark Thomas wrote: On 07/05/2013 21:13, Christopher Schultz wrote: Mark, On 5/7/13 8:54 AM, Mark Thomas wrote: In an attempt to improve the situation, I have tried to document a proposed expected behaviour [4]. Cool. Two question: 1. What is the difference

Automatic deployment changes

2013-05-07 Thread Mark Thomas
There have been a few queries [1], [2] recently and there is a long standard enhancement request [3] regarding automatic deployment. What has made changes in this area difficult in the past is a) a lack of a clear definition as to what the expected behaviour is and b) a lack of test cases to

Re: Automatic deployment changes

2013-05-07 Thread Remy Maucherat
On Tue, 2013-05-07 at 13:54 +0100, Mark Thomas wrote: What has made changes in this area difficult in the past is a) a lack of a clear definition as to what the expected behaviour is and b) a lack of test cases to validate that behaviour. a) is very true ... Anyway, I think it's very good to

Re: Automatic deployment changes

2013-05-07 Thread Christopher Schultz
Mark, On 5/7/13 8:54 AM, Mark Thomas wrote: In an attempt to improve the situation, I have tried to document a proposed expected behaviour [4]. Cool. Two question: 1. What is the difference between Y/N and - in a column? Y/N seems to mean does not matter. Does - mean does not apply? If both

Re: Automatic deployment changes

2013-05-07 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/05/2013 21:13, Christopher Schultz wrote: Mark, On 5/7/13 8:54 AM, Mark Thomas wrote: In an attempt to improve the situation, I have tried to document a proposed expected behaviour [4]. Cool. Two question: 1. What is the difference