Re: C code needs review

2008-07-07 Thread Jim Jagielski
Agreed that the code "works" but could be improved. I'll hold off and let Mladen make his improvements before digging again. On Jul 7, 2008, at 2:23 AM, Mladen Turk wrote: Mark Thomas wrote: I've just attached a couple of patches to https://issues.apache.org/bugzilla/show_bug.cgi?id=43327 One

Re: C code needs review

2008-07-06 Thread Mark Thomas
Mladen Turk wrote: Mark Thomas wrote: I've just attached a couple of patches to https://issues.apache.org/bugzilla/show_bug.cgi?id=43327 One of the patches is a patch to native and since all I know just about know enough C to be dangerous, I would be grateful if someone who actually knows wh

Re: C code needs review

2008-07-06 Thread jean-frederic clere
Mark Thomas wrote: I've just attached a couple of patches to https://issues.apache.org/bugzilla/show_bug.cgi?id=43327 One of the patches is a patch to native and since all I know just about know enough C to be dangerous, I would be grateful if someone who actually knows what they are doing wh

Re: C code needs review

2008-07-06 Thread Mladen Turk
Mark Thomas wrote: I've just attached a couple of patches to https://issues.apache.org/bugzilla/show_bug.cgi?id=43327 One of the patches is a patch to native and since all I know just about know enough C to be dangerous, I would be grateful if someone who actually knows what they are doing wh

C code needs review

2008-07-05 Thread Mark Thomas
I've just attached a couple of patches to https://issues.apache.org/bugzilla/show_bug.cgi?id=43327 One of the patches is a patch to native and since all I know just about know enough C to be dangerous, I would be grateful if someone who actually knows what they are doing when it comes to C cou