https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #23 from Francis Galiegue fgalie...@gmail.com 2011-10-20 09:31:34
UTC ---
Comments?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #22 from Francis Galiegue fgalie...@gmail.com 2011-10-16 08:19:47
UTC ---
Well, I can now confirm that both the filter and valve work, however the
messages I log are NOT shown at all. As to exceptions, when running the valve,
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #21 from Francis Galiegue fgalie...@gmail.com 2011-10-15 11:03:31
UTC ---
OK, I don't understand what is happening at all.
The filter does work, exceptions are thrown, but nothing is logged with the
default Tomcat log
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
Francis Galiegue fgalie...@gmail.com changed:
What|Removed |Added
Attachment #27691|0 |1
is
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #19 from Francis Galiegue fgalie...@gmail.com 2011-10-14 23:16:06
UTC ---
Well, my filter is not the only one affected.
I also added this to web.xml:
filter
filter-namehost/filter-name
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #20 from Konstantin Kolinko knst.koli...@gmail.com 2011-10-15
03:02:36 UTC ---
(In reply to comment #19)
param-value$127.0.0.1/param-value
Of course, the regex is invalid. BUT THE CONTEXT RELOADS!!
The regex is valid.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #17 from Francis Galiegue fgalie...@gmail.com 2011-10-09 12:37:21
UTC ---
Still waiting for input...
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #16 from Francis Galiegue fgalie...@gmail.com 2011-10-07 13:53:05
UTC ---
Created attachment 27726
-- https://issues.apache.org/bugzilla/attachment.cgi?id=27726
Tests for the NetMask class
Here are the first tests for this
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #15 from Francis Galiegue fgalie...@gmail.com 2011-10-06 07:34:50
UTC ---
OK, I need advice.
How should errors be handled and at which level? What should happen if one
specified netmask is invalid? Should the Valve/Filter fail
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #10 from Francis Galiegue fgalie...@gmail.com 2011-10-05 09:22:33
UTC ---
Created attachment 27694
-- https://issues.apache.org/bugzilla/attachment.cgi?id=27694
Alternative netmask class, using byte arrays
Here is another
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #11 from Francis Galiegue fgalie...@gmail.com 2011-10-05 12:51:19
UTC ---
This crude test using the following code shows indeed that the byte array based
implementation is indeed MUCH faster:
private static final int
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #12 from Christopher Schultz ch...@christopherschultz.net
2011-10-05 14:21:03 UTC ---
I like this NetMask implementation *much* better. It took me a while to
convince myself that it was correct, but it looks good to me, now. :)
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #13 from Francis Galiegue fgalie...@gmail.com 2011-10-05 14:38:27
UTC ---
(In reply to comment #12)
I like this NetMask implementation *much* better. It took me a while to
convince myself that it was correct, but it looks
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #14 from Christopher Schultz ch...@christopherschultz.net
2011-10-05 15:35:07 UTC ---
(In reply to comment #13)
But I'm really not convinced that string matching is a good idea. It
may be for IPv4, but for IPv6 it will be a
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #1 from Francis Galiegue fgalie...@gmail.com 2011-10-04 18:06:15
UTC ---
Created attachment 27686
-- https://issues.apache.org/bugzilla/attachment.cgi?id=27686
As title says
--
Configure bugmail:
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #2 from Francis Galiegue fgalie...@gmail.com 2011-10-04 18:06:30
UTC ---
Created attachment 27687
-- https://issues.apache.org/bugzilla/attachment.cgi?id=27687
As title says
--
Configure bugmail:
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
Francis Galiegue fgalie...@gmail.com changed:
What|Removed |Added
Attachment #27686|As title says |Netmask
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
Francis Galiegue fgalie...@gmail.com changed:
What|Removed |Added
Attachment #27687|As title says |Netmask
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #3 from Francis Galiegue fgalie...@gmail.com 2011-10-04 18:07:25
UTC ---
Created attachment 27688
-- https://issues.apache.org/bugzilla/attachment.cgi?id=27688
Netmask valve
--
Configure bugmail:
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #4 from Francis Galiegue fgalie...@gmail.com 2011-10-04 18:46:53
UTC ---
Created attachment 27689
-- https://issues.apache.org/bugzilla/attachment.cgi?id=27689
Whole patch (git diff origin/trunk..)
--
Configure bugmail:
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #5 from Christopher Schultz ch...@christopherschultz.net
2011-10-04 20:52:36 UTC ---
I might make this filter/valve a bit more generic: there's no reason to go
through all the trouble of doing an InetAddress lookup, creating a
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #6 from Francis Galiegue fgalie...@gmail.com 2011-10-04 21:05:25
UTC ---
(In reply to comment #5)
I might make this filter/valve a bit more generic: there's no reason to go
through all the trouble of doing an InetAddress
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #7 from Christopher Schultz ch...@christopherschultz.net
2011-10-04 21:15:43 UTC ---
This code is executed unconditionally:
final InetAddress addr = InetAddress.getByName(property);
for (final NetMask nm: deny)
if
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #8 from Francis Galiegue fgalie...@gmail.com 2011-10-04 21:30:27
UTC ---
(In reply to comment #7)
This code is executed unconditionally:
final InetAddress addr = InetAddress.getByName(property);
for (final NetMask nm:
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
Christopher Schultz ch...@christopherschultz.net changed:
What|Removed |Added
Attachment #27686|0
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Severity|normal |enhancement
--
26 matches
Mail list logo
