> On Sep 26, 2014, at 17:03, Mark Thomas wrote:
>
> On 26/09/2014 16:45, Christopher Schultz wrote:
>
>>> +1 for commit.
>>
>> Are you up for back-porting this to Tomcat 7?
>
> Hmm. Not sure at this point. I'd like to give it sometime to settle in
> to 8.0.x first.
I understand wanting to w
On 26/09/2014 16:45, Christopher Schultz wrote:
>> +1 for commit.
>
> Are you up for back-porting this to Tomcat 7?
Hmm. Not sure at this point. I'd like to give it sometime to settle in
to 8.0.x first.
> I noticed that you
> committed to trunk in smaller pieces rather than a single commit. Was
Mark,
On 9/25/14 9:18 AM, Christopher Schultz wrote:
> Mark,
>
> On 9/24/14 12:27 PM, Mark Thomas wrote:
>> On 24/09/2014 16:59, Christopher Schultz wrote:
>>> Mark,
>>>
>>> On 9/24/14 5:00 AM, Mark Thomas wrote:
On 23/09/2014 10:49, Mark Thomas wrote:
> On 23/09/2014 00:56, "Gabriel E.
Mark,
On 9/24/14 12:27 PM, Mark Thomas wrote:
> On 24/09/2014 16:59, Christopher Schultz wrote:
>> Mark,
>>
>> On 9/24/14 5:00 AM, Mark Thomas wrote:
>>> On 23/09/2014 10:49, Mark Thomas wrote:
On 23/09/2014 00:56, "Gabriel E. Sánchez Martínez" wrote:
>
> On 09/17/2014 04:36 AM, Mark
On 09/24/2014 12:27 PM, Mark Thomas wrote:
On 24/09/2014 16:59, Christopher Schultz wrote:
Mark,
On 9/24/14 5:00 AM, Mark Thomas wrote:
On 23/09/2014 10:49, Mark Thomas wrote:
On 23/09/2014 00:56, "Gabriel E. Sánchez Martínez" wrote:
On 09/17/2014 04:36 AM, Mark Thomas wrote:
On 16/09/2014
On 24/09/2014 16:59, Christopher Schultz wrote:
> Mark,
>
> On 9/24/14 5:00 AM, Mark Thomas wrote:
>> On 23/09/2014 10:49, Mark Thomas wrote:
>>> On 23/09/2014 00:56, "Gabriel E. Sánchez Martínez" wrote:
On 09/17/2014 04:36 AM, Mark Thomas wrote:
> On 16/09/2014 22:14, Christopher Sc
Mark,
On 9/24/14 5:00 AM, Mark Thomas wrote:
> On 23/09/2014 10:49, Mark Thomas wrote:
>> On 23/09/2014 00:56, "Gabriel E. Sánchez Martínez" wrote:
>>>
>>> On 09/17/2014 04:36 AM, Mark Thomas wrote:
On 16/09/2014 22:14, Christopher Schultz wrote:
> Mark,
>
> On 9/16/14 3:39 PM, Ma
On 23/09/2014 10:49, Mark Thomas wrote:
> On 23/09/2014 00:56, "Gabriel E. Sánchez Martínez" wrote:
>>
>> On 09/17/2014 04:36 AM, Mark Thomas wrote:
>>> On 16/09/2014 22:14, Christopher Schultz wrote:
Mark,
On 9/16/14 3:39 PM, Mark Thomas wrote:
> Updated patch:
> http://peop
Am 23.09.2014 um 19:35 schrieb Felix Schumacher:
Am 23.09.2014 um 01:56 schrieb "Gabriel E. Sánchez Martínez":
On 09/17/2014 04:36 AM, Mark Thomas wrote:
On 16/09/2014 22:14, Christopher Schultz wrote:
Mark,
On 9/16/14 3:39 PM, Mark Thomas wrote:
Updated patch:
http://people.apache.org/~mar
Am 23.09.2014 um 01:56 schrieb "Gabriel E. Sánchez Martínez":
On 09/17/2014 04:36 AM, Mark Thomas wrote:
On 16/09/2014 22:14, Christopher Schultz wrote:
Mark,
On 9/16/14 3:39 PM, Mark Thomas wrote:
Updated patch:
http://people.apache.org/~markt/patches/2014-09-16-bug56403-tc8-v2.patch
It'
Am 17.09.2014 um 10:36 schrieb Mark Thomas:
On 16/09/2014 22:14, Christopher Schultz wrote:
Mark,
On 9/16/14 3:39 PM, Mark Thomas wrote:
Updated patch:
http://people.apache.org/~markt/patches/2014-09-16-bug56403-tc8-v2.patch
Looks good, but its missing a configuration for the digester to actu
Gabriel,
On 9/22/14 7:56 PM, "Gabriel E. Sánchez Martínez" wrote:
>
> On 09/17/2014 04:36 AM, Mark Thomas wrote:
>> On 16/09/2014 22:14, Christopher Schultz wrote:
>>> Mark,
>>>
>>> On 9/16/14 3:39 PM, Mark Thomas wrote:
Updated patch:
http://people.apache.org/~markt/patches/2014-09-16-
On 23/09/2014 00:56, "Gabriel E. Sánchez Martínez" wrote:
>
> On 09/17/2014 04:36 AM, Mark Thomas wrote:
>> On 16/09/2014 22:14, Christopher Schultz wrote:
>>> Mark,
>>>
>>> On 9/16/14 3:39 PM, Mark Thomas wrote:
Updated patch:
http://people.apache.org/~markt/patches/2014-09-16-bug56403-
On 09/17/2014 04:36 AM, Mark Thomas wrote:
On 16/09/2014 22:14, Christopher Schultz wrote:
Mark,
On 9/16/14 3:39 PM, Mark Thomas wrote:
Updated patch:
http://people.apache.org/~markt/patches/2014-09-16-bug56403-tc8-v2.patch
It's looking good!
Looks good, but its missing a configuration for
On 16/09/2014 22:14, Christopher Schultz wrote:
> Mark,
>
> On 9/16/14 3:39 PM, Mark Thomas wrote:
>> Updated patch:
>> http://people.apache.org/~markt/patches/2014-09-16-bug56403-tc8-v2.patch
>
> Looks good, but its missing a configuration for the digester to actually
> read the configuration an
Mark,
On 9/16/14 3:39 PM, Mark Thomas wrote:
> Updated patch:
> http://people.apache.org/~markt/patches/2014-09-16-bug56403-tc8-v2.patch
Looks good, but its missing a configuration for the digester to actually
read the configuration and set-up the CredentialHandler objects at
runtime. Existing Me
Mark,
On 9/16/14 3:39 PM, Mark Thomas wrote:
> On 16/09/2014 16:20, Christopher Schultz wrote:
>> 1. In terms of limiting converting to String values, we could base
>> everything on byte[] instead of String.
>
> Having looked at the current code and the Servlet API I don't believe
> that this is
Mark,
On 9/16/14 12:46 PM, Mark Thomas wrote:
> On 16/09/2014 17:17, Mark Thomas wrote:
>> On 16/09/2014 16:20, Christopher Schultz wrote:
>
>>> 2. I don't like CredentialHandler.mutate(String input, byte[] salt, int
>>> iterations). I think it ties the method signature to the implementation
>>>
On 16/09/2014 16:20, Christopher Schultz wrote:
> 1. In terms of limiting converting to String values, we could base
> everything on byte[] instead of String.
Having looked at the current code and the Servlet API I don't believe
that this is practical.
> 2. I don't like CredentialHandler.mutate(
On 16/09/2014 16:20, Christopher Schultz wrote:
> StringBuilder credential = new StringBuilder(saltLength << 1 +
> serverCredential.length() + 10 + 2);
> credential.append(HexUtils.toString(salt))
> .append('$')
> .append(iterations)
> .append('$')
>
On 16/09/2014 17:17, Mark Thomas wrote:
> On 16/09/2014 16:20, Christopher Schultz wrote:
>> 2. I don't like CredentialHandler.mutate(String input, byte[] salt, int
>> iterations). I think it ties the method signature to the implementation
>> of the mutation algorithm. PBKDF2 for instance has both
On 16/09/2014 16:20, Christopher Schultz wrote:
> All,
>
> In reference to bug 56403
> (https://issues.apache.org/bugzilla/show_bug.cgi?id=56403) and
> specifically markt's proposed patch
> (http://people.apache.org/~markt/patches/2014-09-16-bug56403-tc8-v1.patch),
> I have the following comments.
All,
In reference to bug 56403
(https://issues.apache.org/bugzilla/show_bug.cgi?id=56403) and
specifically markt's proposed patch
(http://people.apache.org/~markt/patches/2014-09-16-bug56403-tc8-v1.patch),
I have the following comments.
I'm interested in what others have to say.
1. In terms of l
23 matches
Mail list logo
