Re: Impossible branch in o.a.t.websocket.server.WsServerContainer.addEndpoint

2015-03-18 Thread Christopher Schultz
Mark, On 3/17/15 4:25 PM, Mark Thomas wrote: >>> On 3/9/15 12:19 PM, Christopher Schultz wrote: All, I was looking at https://bz.apache.org/bugzilla/show_bug.cgi?id=57676 (a simple proposed patch to improve an error message) and I was trying to figure out what to do with a

Re: Impossible branch in o.a.t.websocket.server.WsServerContainer.addEndpoint

2015-03-17 Thread Mark Thomas
>> On 3/9/15 12:19 PM, Christopher Schultz wrote: >>> All, >>> >>> I was looking at https://bz.apache.org/bugzilla/show_bug.cgi?id=57676 (a >>> simple proposed patch to improve an error message) and I was trying to >>> figure out what to do with a bit of code in addEndpoint. Reading the >>> code, I

Re: Impossible branch in o.a.t.websocket.server.WsServerContainer.addEndpoint

2015-03-17 Thread Mark Thomas
On 17/03/2015 14:45, Christopher Schultz wrote: > Ping Sorry. This dropped off my radar while I was trying to figure out the APR crash. I'll take a look later today. Mark > > On 3/9/15 12:19 PM, Christopher Schultz wrote: >> All, >> >> I was looking at https://bz.apache.org/bugzilla/show_bug.

Re: Impossible branch in o.a.t.websocket.server.WsServerContainer.addEndpoint

2015-03-17 Thread Christopher Schultz
Ping On 3/9/15 12:19 PM, Christopher Schultz wrote: > All, > > I was looking at https://bz.apache.org/bugzilla/show_bug.cgi?id=57676 (a > simple proposed patch to improve an error message) and I was trying to > figure out what to do with a bit of code in addEndpoint. Reading the > code, I think I

Impossible branch in o.a.t.websocket.server.WsServerContainer.addEndpoint

2015-03-09 Thread Christopher Schultz
All, I was looking at https://bz.apache.org/bugzilla/show_bug.cgi?id=57676 (a simple proposed patch to improve an error message) and I was trying to figure out what to do with a bit of code in addEndpoint. Reading the code, I think I've spotted a problem: [187] UriTemplate uriTemplate = new Uri