JSTL issue

2021-04-13 Thread Jean-Louis MONTEIRO
Hi guys, I have one JSTL issue and I'd need your feedback on it. https://github.com/eclipse-ee4j/jstl-api/issues/140 Can you guys have a look and let me know what you think? -- Jean-Louis

Re: JSTL issue

2021-04-13 Thread Mark Thomas
On 13/04/2021 20:17, Jean-Louis MONTEIRO wrote: Hi guys, I have one JSTL issue and I'd need your feedback on it. https://github.com/eclipse-ee4j/jstl-api/issues/140 Can you guys have a look and let me know what you think? That looks like a side-effect of the various improvements we ma

Re: JSTL issue

2021-04-14 Thread Jean-Louis MONTEIRO
Thanks for the answer. Do you mind adding the comment in the issue? I can copy/paste if not. It's just to give context to others Thanks Le mar. 13 avr. 2021 à 21:44, Mark Thomas a écrit : > On 13/04/2021 20:17, Jean-Louis MONTEIRO wrote: > > Hi guys, > > > > I have o

Re: JSTL issue

2021-04-15 Thread Jean-Louis MONTEIRO
not. It's just to give context to others > > Thanks > > Le mar. 13 avr. 2021 à 21:44, Mark Thomas a écrit : > >> On 13/04/2021 20:17, Jean-Louis MONTEIRO wrote: >> > Hi guys, >> > >> > I have one JSTL issue and I'd need your feedback on it. >

Re: JSTL issue

2021-04-15 Thread Mark Thomas
On 15/04/2021 09:03, Jean-Louis MONTEIRO wrote: I've got an answer from JSTL team. Here it is 1. Jakarta Tags Specification Section 7.4 details the tag: c:import Within th

Re: JSTL issue

2021-04-15 Thread Jean-Louis MONTEIRO
Hi, I definitely value the feedback and thoughts. I understand and I agree it's unlikely to be a real world use case. I am happy to give it a try to improve the flag and submit a PR for it. I'll make sure to fire a new TCK build with everything (servlet, jsp, etc) so we have more confidence in t

Re: JSTL issue

2021-04-15 Thread Christopher Schultz
Mark, On 4/15/21 04:57, Mark Thomas wrote: If we wanted to address this and provide a way to allow JSTL to have the control over the included content required to pass this TCK test then we could modify 'useBomIfPresent' as follows: - true   - no change - remains the default - false  - no cha

Re: JSTL issue

2021-05-05 Thread Jean-Louis MONTEIRO
Hi, Now that we crossed the finish line with TomEE compatibility, I'd like to give back the BOM changes according to this discussion. I did the updated and created another subclass for DefaultServletEncodingBaseTest [image: image.png] Did some fixes around that test to take the changes into accou

Re: JSTL issue

2021-05-05 Thread Christopher Schultz
Jean-Louis, On 5/5/21 09:49, Jean-Louis MONTEIRO wrote: Now that we crossed the finish line with TomEE compatibility, I'd like to give back the BOM changes according to this discussion. I did the updated and created another subclass for DefaultServletEncodingBaseTest image.png Did some fixes

Re: JSTL issue

2021-05-11 Thread Jean-Louis MONTEIRO
Hi, I went ahead and pull the code into a draft PR. I'd appreciate any feedback or guidance. https://github.com/apache/tomcat/pull/418 Lemme know if that's ok. I believe I should maybe open something in the bug tracker? Thanks Le mer. 5 mai 2021 à 16:38, Christopher Schultz < ch...@christopher