Re: Message files encoding

2018-08-01 Thread Christopher Schultz
Mark, On 8/1/18 11:21 AM, Mark Thomas wrote: > On 01/08/18 16:03, Emmanuel Bourg wrote: >> Le 01/08/2018 à 16:34, Mark Thomas a écrit : >> >>> I think there is a little more work to be done. Currently the files are >>> corrupted when I look at them in an IDE. I've tried playing with >>> svn:mimety

Re: Message files encoding

2018-08-01 Thread Mark Thomas
On 01/08/18 16:03, Emmanuel Bourg wrote: > Le 01/08/2018 à 16:34, Mark Thomas a écrit : > >> I think there is a little more work to be done. Currently the files are >> corrupted when I look at them in an IDE. I've tried playing with >> svn:mimetype without much luck. > > With IntelliJ the encodin

Re: Message files encoding

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 16:34, Mark Thomas a écrit : > I think there is a little more work to be done. Currently the files are > corrupted when I look at them in an IDE. I've tried playing with > svn:mimetype without much luck. With IntelliJ the encoding is automatically detected as UTF-8, but I had to r

Re: Message files encoding

2018-08-01 Thread Mark Thomas
On 01/08/18 15:10, Emmanuel Bourg wrote: > Le 01/08/2018 à 14:12, Mark Thomas a écrit : > >> That solves the complexity problem. It looks like all that would be >> required is a change from copying the file to using native2ascii with >> appropriate src and destinations. >> >> No objections here. >

Re: Message files encoding

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 14:12, Mark Thomas a écrit : > That solves the complexity problem. It looks like all that would be > required is a change from copying the file to using native2ascii with > appropriate src and destinations. > > No objections here. Ok it's committed (r1837237 and r1837238 for the

Re: Message files encoding

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 14:08, Martin Grigorov a écrit : > I hope the following changes your mind: > > 1) Bulgarian translations in XML format: > https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Application_bg.properties.xml > 2) Czech translation in ascii format:

Re: Message files encoding

2018-08-01 Thread Mark Thomas
On 01/08/18 12:47, Emmanuel Bourg wrote: > Le 01/08/2018 à 13:08, Mark Thomas a écrit : > >> I like the idea but that will make building with later versions of Java >> problematic - or at least more complex - since native2ascii has been >> removed in Java 9 onwards. > > Good point, I wasn't aware

Re: Message files encoding

2018-08-01 Thread Martin Grigorov
On Wed, Aug 1, 2018 at 2:56 PM Emmanuel Bourg wrote: > Le 01/08/2018 à 13:16, Martin Grigorov a écrit : > > > What about using the XML version of Java Properties ? > > > https://docs.oracle.com/javase/7/docs/api/java/util/Properties.html#loadFromXML(java.io.InputStream) > > This way the encoding

Re: Message files encoding

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 13:16, Martin Grigorov a écrit : > What about using the XML version of Java Properties ? > https://docs.oracle.com/javase/7/docs/api/java/util/Properties.html#loadFromXML(java.io.InputStream) > This way the encoding could be specified in the XML file itself and there > is no need t

Re: Message files encoding

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 13:08, Mark Thomas a écrit : > I like the idea but that will make building with later versions of Java > problematic - or at least more complex - since native2ascii has been > removed in Java 9 onwards. Good point, I wasn't aware of native2ascii removal. I checked the Ant code and

Re: Message files encoding

2018-08-01 Thread Martin Grigorov
Hi, On Wed, Aug 1, 2018 at 2:08 PM Mark Thomas wrote: > On 01/08/18 12:03, Emmanuel Bourg wrote: > > Hi all, > > > > The LocalString*.properties files are ASCII encoded which renders the > > modification of the non-english messages rather inconvenient. > > Contributors either need a specialized

Re: Message files encoding

2018-08-01 Thread Mark Thomas
On 01/08/18 12:03, Emmanuel Bourg wrote: > Hi all, > > The LocalString*.properties files are ASCII encoded which renders the > modification of the non-english messages rather inconvenient. > Contributors either need a specialized resource editor or go through a > native2ascii roundtrip. > > How d

Message files encoding

2018-08-01 Thread Emmanuel Bourg
Hi all, The LocalString*.properties files are ASCII encoded which renders the modification of the non-english messages rather inconvenient. Contributors either need a specialized resource editor or go through a native2ascii roundtrip. How do feel about converting the message files to UTF-8 to fac