Re: Where to put a helper class for test?

2013-09-12 Thread Christopher Schultz
Nick, On 9/12/13 2:12 PM, Nick Williams wrote: > > On Sep 12, 2013, at 1:03 PM, Mark Thomas wrote: > >> On 12/09/2013 18:31, Nick Williams wrote: >>> Mark, >>> >>> I'm working on revisions to my patch for BZ 55317 based on your >>> feedback. In this feedback you said: >>> 5. I'm not a fan o

Re: Where to put a helper class for test?

2013-09-12 Thread Nick Williams
On Sep 12, 2013, at 1:03 PM, Mark Thomas wrote: > On 12/09/2013 18:31, Nick Williams wrote: >> Mark, >> >> I'm working on revisions to my patch for BZ 55317 based on your >> feedback. In this feedback you said: >> >>> 5. I'm not a fan of the org.apache.tomcat.unittest package unless >>> the cla

Re: Where to put a helper class for test?

2013-09-12 Thread Mark Thomas
On 12/09/2013 18:31, Nick Williams wrote: > Mark, > > I'm working on revisions to my patch for BZ 55317 based on your > feedback. In this feedback you said: > >> 5. I'm not a fan of the org.apache.tomcat.unittest package unless >> the classes concerned are going to be used by multiple tests acros

Where to put a helper class for test?

2013-09-12 Thread Nick Williams
Mark, I'm working on revisions to my patch for BZ 55317 based on your feedback. In this feedback you said: > 5. I'm not a fan of the org.apache.tomcat.unittest package unless the classes > concerned are going to be used by multiple tests across multiple packages. I put org.apache.tomcat.unitte