svn commit: r1042022 - in /tomcat: tc6.0.x/trunk/STATUS.txt trunk/java/org/apache/catalina/session/StandardManager.java trunk/webapps/docs/changelog.xml

2010-12-03 Thread slaurent
Author: slaurent Date: Fri Dec 3 22:00:58 2010 New Revision: 1042022 URL: http://svn.apache.org/viewvc?rev=1042022&view=rev Log: bug 48973 (enhancement): Don't create SESSIONS.ser when no session exists https://issues.apache.org/bugzilla/show_bug.cgi?id=48973 Modified: tomcat/tc6.0.x/trunk/

Re: svn commit: r1042022 - in /tomcat: tc6.0.x/trunk/STATUS.txt trunk/java/org/apache/catalina/session/StandardManager.java trunk/webapps/docs/changelog.xml

2010-12-05 Thread Mark Thomas
On 03/12/2010 22:00, slaur...@apache.org wrote: > Author: slaurent > Date: Fri Dec 3 22:00:58 2010 > New Revision: 1042022 > > URL: http://svn.apache.org/viewvc?rev=1042022&view=rev Comments in-line. > +if (sessions.isEmpty()) { > +log.debug("No persisted sessions to unload"

Re: svn commit: r1042022 - in /tomcat: tc6.0.x/trunk/STATUS.txt trunk/java/org/apache/catalina/session/StandardManager.java trunk/webapps/docs/changelog.xml

2010-12-05 Thread Sylvain Laurent
On 5 déc. 2010, at 18:58, Mark Thomas wrote: > We haven't been good at this historically for debug messages but we > should really use a StringManager here for i18n support. Though i can understand that i18n is useful for information and error message, is it really useful for debug level messag

Re: svn commit: r1042022 - in /tomcat: tc6.0.x/trunk/STATUS.txt trunk/java/org/apache/catalina/session/StandardManager.java trunk/webapps/docs/changelog.xml

2010-12-05 Thread Mark Thomas
On 05/12/2010 21:18, Sylvain Laurent wrote: > > On 5 déc. 2010, at 18:58, Mark Thomas wrote: > >> We haven't been good at this historically for debug messages but we >> should really use a StringManager here for i18n support. > > Though i can understand that i18n is useful for information and er