Author: kkolinko
Date: Mon Aug 22 16:12:30 2011
New Revision: 1160317
URL: http://svn.apache.org/viewvc?rev=1160317&view=rev
Log:
vote
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1160317&r1=1160316&r2=1160317&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Mon Aug 22 16:12:30 2011
@@ -29,7 +29,8 @@ PATCHES PROPOSED TO BACKPORT:
Display error page rather than an empty response for an IllegalStateException
https://issues.apache.org/bugzilla/attachment.cgi?id=27421
+1: markt
- -0: kkolinko: I do not like removing the catch from CoyoteAdapter. It
+
+ kkolinko: I do not like removing the catch from CoyoteAdapter. It
looks safer the old way. JkCoyoteHandler does not handle Errors, just
Exceptions. It seems from the patch that all you need to fix this bug is
ep.setStatus(MsgContext.JK_STATUS_ERROR);
@@ -45,6 +46,14 @@ PATCHES PROPOSED TO BACKPORT:
-0: schultz: I tend to agree with Konstantin's assertion that the catch
block is important. I understand the change to the status, but could
you explain why the catch(Throwable) block has been removed?
- markt: See reply to kkolino above.
+ markt: See reply to kkolinko above.
+ +1: kkolinko: OK with the updated patch.
+ It seems though that
+ 1) MemoryProtocolHandler#process() should now try/catch(Throwable).
+ The MemoryProtocolHandler is created in Embedded.java line 424.
+ Maybe also
+ 2) i18n the message in JkCoyoteHandler.
+ 3) s/log.error()/log.info()/ in processors, because CoyoteAdapter
+ used info() for its exception handling.
-1:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
