Re: svn commit: r1174181 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/ClusterManagerBase.java java/org/apache/catalina/ha/s

2011-09-23 Thread Konstantin Kolinko
Reviewing Eclipse warnings I noticed a bug in this commit. 2011/9/22 : > Author: rjung > Date: Thu Sep 22 15:01:08 2011 > New Revision: 1174181 > > URL: http://svn.apache.org/viewvc?rev=1174181&view=rev > Log: > - Pull up members "cluster" and "notifyListenersOnReplication" >  to common base cla

Re: svn commit: r1174181 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/ClusterManagerBase.java java/org/apache/catalina/ha/s

2011-09-24 Thread Rainer Jung
On 23.09.2011 23:57, Konstantin Kolinko wrote: > Reviewing Eclipse warnings I noticed a bug in this commit. Argh. >> +protected void clone(ClusterManagerBase copy) { >> +copy.name = "Clone-from-" + getName(); > > The above assignment is wrong. > It assigns to ManagerBase.name which i

Re: svn commit: r1174181 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/ClusterManagerBase.java java/org/apache/catalina/ha/s

2011-09-24 Thread Konstantin Kolinko
2011/9/24 Rainer Jung : > > Fixed also, ported to TC 7, updated TC 6 patch for Override, kept your > vote in STATUS.txt. > OK, good. Thank you. BTW, typo in JavaDoc in the patch. @return true is attribute should not be replicated @return true if attribute should not be replicated There are enoug

Re: svn commit: r1174181 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/ClusterManagerBase.java java/org/apache/catalina/ha/s

2011-09-24 Thread Rainer Jung
On 24.09.2011 13:57, Konstantin Kolinko wrote: > 2011/9/24 Rainer Jung : >> >> Fixed also, ported to TC 7, updated TC 6 patch for Override, kept your >> vote in STATUS.txt. >> > > OK, good. Thank you. > > BTW, typo in JavaDoc in the patch. > @return true is attribute should not be replicated > @r