Re: svn commit: r1209686 [1/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/c

2011-12-02 Thread Mark Thomas
On 02/12/2011 20:49, slaur...@apache.org wrote: > Author: slaurent > Date: Fri Dec 2 20:49:50 2011 > New Revision: 1209686 > > URL: http://svn.apache.org/viewvc?rev=1209686&view=rev > Log: > bug 51741: Eclipse WTP "Serve modules without publishing" broken with > tc7, needs patch in tomcat > http

Re: svn commit: r1209686 [1/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/c

2011-12-02 Thread Mark Thomas
On 02/12/2011 21:08, Mark Thomas wrote: > On 02/12/2011 20:49, slaur...@apache.org wrote: >> Author: slaurent >> Date: Fri Dec 2 20:49:50 2011 >> New Revision: 1209686 >> >> URL: http://svn.apache.org/viewvc?rev=1209686&view=rev >> Log: >> bug 51741: Eclipse WTP "Serve modules without publishing"

Re: svn commit: r1209686 [1/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/c

2011-12-02 Thread Sylvain Laurent
good catch. Actually I did perform a ant test to check that all tests pass, but the "validate" target is not run by default. Why isn't it enabled by default ? Sylvain On 2 déc. 2011, at 22:08, Mark Thomas wrote: > On 02/12/2011 20:49, slaur...@apache.org wrote: >> Author: slaurent >> Date: Fri

Re: svn commit: r1209686 [1/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/c

2011-12-02 Thread Mark Thomas
On 02/12/2011 21:20, Mark Thomas wrote: > On 02/12/2011 21:08, Mark Thomas wrote: >> On 02/12/2011 20:49, slaur...@apache.org wrote: >>> Author: slaurent >>> Date: Fri Dec 2 20:49:50 2011 >>> New Revision: 1209686 >>> >>> URL: http://svn.apache.org/viewvc?rev=1209686&view=rev >>> Log: >>> bug 5174

Re: svn commit: r1209686 [1/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/c

2011-12-02 Thread Mark Thomas
On 02/12/2011 21:25, Sylvain Laurent wrote: > good catch. Actually I did perform a ant test to check that all tests > pass, but the "validate" target is not run by default. Why isn't it > enabled by default ? Because Checkstyle uses a license (LGPL?) that is not AL2 compatible so we require explic