svn commit: r1650277 - in /tomcat/trunk/java/org/apache: coyote/http11/ tomcat/util/net/

2015-01-08 Thread markt
Author: markt Date: Thu Jan 8 13:10:41 2015 New Revision: 1650277 URL: http://svn.apache.org/r1650277 Log: Partial NIO2 refactoring Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java tomcat/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java

Re: svn commit: r1650277 - in /tomcat/trunk/java/org/apache: coyote/http11/ tomcat/util/net/

2015-01-08 Thread Rémy Maucherat
2015-01-08 14:10 GMT+01:00 ma...@apache.org: @@ -766,32 +776,120 @@ public class Nio2Endpoint extends Abstra this.writeCompletionHandler = new CompletionHandlerInteger, ByteBuffer() { @Override public void completed(Integer nBytes, ByteBuffer

Re: svn commit: r1650277 - in /tomcat/trunk/java/org/apache: coyote/http11/ tomcat/util/net/

2015-01-08 Thread Mark Thomas
On 08/01/2015 13:46, Rémy Maucherat wrote: 2015-01-08 14:10 GMT+01:00 ma...@apache.org: @@ -766,32 +776,120 @@ public class Nio2Endpoint extends Abstra this.writeCompletionHandler = new CompletionHandlerInteger, ByteBuffer() { @Override public

Re: svn commit: r1650277 - in /tomcat/trunk/java/org/apache: coyote/http11/ tomcat/util/net/

2015-01-08 Thread Rémy Maucherat
2015-01-08 14:50 GMT+01:00 Mark Thomas ma...@apache.org: There's a big deadlock risk if the recursion if incomplete and error processing are inside the sync. I came across some of those while doing the refactoring. I think - as of r1650289 - they are addressed but it is possible I missed

Re: svn commit: r1650277 - in /tomcat/trunk/java/org/apache: coyote/http11/ tomcat/util/net/

2015-01-08 Thread Mark Thomas
On 08/01/2015 13:54, Rémy Maucherat wrote: 2015-01-08 14:50 GMT+01:00 Mark Thomas ma...@apache.org: There's a big deadlock risk if the recursion if incomplete and error processing are inside the sync. I came across some of those while doing the refactoring. I think - as of r1650289 - they

Re: svn commit: r1650277 - in /tomcat/trunk/java/org/apache: coyote/http11/ tomcat/util/net/

2015-01-08 Thread Rémy Maucherat
2015-01-08 14:58 GMT+01:00 Mark Thomas ma...@apache.org: On 08/01/2015 13:54, Rémy Maucherat wrote: 2015-01-08 14:50 GMT+01:00 Mark Thomas ma...@apache.org: There's a big deadlock risk if the recursion if incomplete and error processing are inside the sync. I came across some of