Re: svn commit: r1660609 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: UpgradeProcessor.java UpgradeServletOutputStream.java

2015-02-19 Thread Mark Thomas
On 18/02/2015 18:56, Mark Thomas wrote: I'm currently exploring explicitly triggering the onWritePossible() and onDataAvailable() calls but I have some more work to do on this as the work-arounds needs to be removed to avoid double registration etc. A short progress report. It has been

Re: svn commit: r1660609 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: UpgradeProcessor.java UpgradeServletOutputStream.java

2015-02-18 Thread Mark Thomas
On 18/02/2015 15:04, Mark Thomas wrote: On 18/02/2015 14:01, Rémy Maucherat wrote: 2015-02-18 14:19 GMT+01:00 Mark Thomas ma...@apache.org: Hmm. I've been running a test with this plus a bunch of possibly unnecessary sync expansions looping over the suspect test for over an hour now without

Re: svn commit: r1660609 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: UpgradeProcessor.java UpgradeServletOutputStream.java

2015-02-18 Thread Mark Thomas
On 18/02/2015 12:14, ma...@apache.org wrote: Author: markt Date: Wed Feb 18 12:14:24 2015 New Revision: 1660609 URL: http://svn.apache.org/r1660609 Log: registered is guarded by registeredLock so there is no need for it to be volatile. Simplify the process of triggering the first call

svn commit: r1660609 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: UpgradeProcessor.java UpgradeServletOutputStream.java

2015-02-18 Thread markt
Author: markt Date: Wed Feb 18 12:14:24 2015 New Revision: 1660609 URL: http://svn.apache.org/r1660609 Log: registered is guarded by registeredLock so there is no need for it to be volatile. Simplify the process of triggering the first call to onWritePossible Modified:

Re: svn commit: r1660609 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: UpgradeProcessor.java UpgradeServletOutputStream.java

2015-02-18 Thread Rémy Maucherat
2015-02-18 14:19 GMT+01:00 Mark Thomas ma...@apache.org: Hmm. I've been running a test with this plus a bunch of possibly unnecessary sync expansions looping over the suspect test for over an hour now without any failures. This patch does fix a logic problem but I thought it was one that

Re: svn commit: r1660609 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: UpgradeProcessor.java UpgradeServletOutputStream.java

2015-02-18 Thread Mark Thomas
On 18/02/2015 14:01, Rémy Maucherat wrote: 2015-02-18 14:19 GMT+01:00 Mark Thomas ma...@apache.org: Hmm. I've been running a test with this plus a bunch of possibly unnecessary sync expansions looping over the suspect test for over an hour now without any failures. This patch does fix a