Re: svn commit: r1779674 - /tomcat/native/trunk/native/configure.in

2017-01-30 Thread Emmanuel Bourg
Le 24/01/2017 à 12:12, Konstantin Kolinko a écrit : > There is a bug number for this change, 60388. It is better to mention > it as 60388: Thanks I didn't notice the syntax to specify a bug number. I added it. > The code and use of ${enableval} is OK. I mean the help string that >

Re: svn commit: r1779674 - /tomcat/native/trunk/native/configure.in

2017-01-24 Thread Konstantin Kolinko
2017-01-23 11:38 GMT+03:00 Emmanuel Bourg : > Hi Konstantin, > > Le 21/01/2017 à 08:58, Konstantin Kolinko a écrit : > >> 1. Please update xdocs/miscellaneous/changelog.xml as well. > > Thanks I didn't see it. There is a bug number for this change, 60388. It is better to

Re: svn commit: r1779674 - /tomcat/native/trunk/native/configure.in

2017-01-23 Thread Emmanuel Bourg
Hi Konstantin, Le 21/01/2017 à 08:58, Konstantin Kolinko a écrit : > 1. Please update xdocs/miscellaneous/changelog.xml as well. Thanks I didn't see it. > 2. I see that other "able-" flags use AS_HELP_STRING() macro to format > help string. > > Maybe use it here as well? I got a look and

Re: svn commit: r1779674 - /tomcat/native/trunk/native/configure.in

2017-01-20 Thread Konstantin Kolinko
Hi! Welcome! 1. Please update xdocs/miscellaneous/changelog.xml as well. 2. I see that other "able-" flags use AS_HELP_STRING() macro to format help string. Maybe use it here as well? 3. Don't forget to add youself to the list at Tomcat site http://tomcat.apache.org/whoweare.html See

svn commit: r1779674 - /tomcat/native/trunk/native/configure.in

2017-01-20 Thread ebourg
Author: ebourg Date: Fri Jan 20 20:26:45 2017 New Revision: 1779674 URL: http://svn.apache.org/viewvc?rev=1779674=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60388 Ensure --disable-maintainer-mode doesn't enable the maintainer mode Modified: