Re: svn commit: r532877 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/transport: PooledSender.java bio/PooledMultiSender.java nio/PooledParallelSender.java

2007-04-29 Thread Peter Rossbach
HI Filip, I see the problem also and I like your proposed solution. +1 peter Am 27.04.2007 um 17:18 schrieb Filip Hanik - Dev Lists: here is a patch that would solve it the way I proposed Index: java/org/apache/catalina/tribes/transport/nio/ ParallelNioSender.java

Re: svn commit: r532877 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/transport: PooledSender.java bio/PooledMultiSender.java nio/PooledParallelSender.java

2007-04-27 Thread Filip Hanik - Dev Lists
here is a patch that would solve it the way I proposed Index: java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java === --- java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java (revision 533123

Re: svn commit: r532877 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/transport: PooledSender.java bio/PooledMultiSender.java nio/PooledParallelSender.java

2007-04-27 Thread Filip Hanik - Dev Lists
Been thinking some more about this, this solution is definitely not right. Two reasons: 1. A member can opt out of the membership without wanting to disconnect the TCP sockets 2. There is no clean way to kill "active" connections Instead the better solution would be this: 1. Issue keepalive as

Re: svn commit: r532877 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/transport: PooledSender.java bio/PooledMultiSender.java nio/PooledParallelSender.java

2007-04-27 Thread Filip Hanik - Dev Lists
Peter Rossbach wrote: HI Filip, this is the next step at weekend :-) how about you discuss what the proposed changes are before you commit them, I am still not sure this is the right way to go as keep alive will take care of any connections left hanging, and also removing "active" connections

Re: svn commit: r532877 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/transport: PooledSender.java bio/PooledMultiSender.java nio/PooledParallelSender.java

2007-04-26 Thread Peter Rossbach
HI Filip, this is the next step at weekend :-) Peter Am 27.04.2007 um 05:14 schrieb Filip Hanik - Dev Lists: I would say this is a -1 this only removes the connections from the idle while it leaves the other ones hanging, hence leaves an inconsistent state. if we are gonna implement this

Re: svn commit: r532877 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/transport: PooledSender.java bio/PooledMultiSender.java nio/PooledParallelSender.java

2007-04-26 Thread Filip Hanik - Dev Lists
I would say this is a -1 this only removes the connections from the idle while it leaves the other ones hanging, hence leaves an inconsistent state. if we are gonna implement this solution, lets do it correct or not at all. Filip [EMAIL PROTECTED] wrote: Author: pero Date: Thu Apr 26 14:41:4

svn commit: r532877 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/transport: PooledSender.java bio/PooledMultiSender.java nio/PooledParallelSender.java

2007-04-26 Thread pero
Author: pero Date: Thu Apr 26 14:41:47 2007 New Revision: 532877 URL: http://svn.apache.org/viewvc?view=rev&rev=532877 Log: Remove senders as member disappeared.. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/transport/PooledSender.java tomcat/tc6.0.x/trunk/java/org/apa