svn commit: r551809 - /tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c

2007-06-29 Thread mturk
Author: mturk Date: Thu Jun 28 23:32:27 2007 New Revision: 551809 URL: http://svn.apache.org/viewvc?view=revrev=551809 Log: Fix potential overflow. The actual encoded string length is strlen + 3 (Two bytes for len and one '\0') Modified:

Re: svn commit: r551809 - /tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c

2007-06-29 Thread jean-frederic clere
[EMAIL PROTECTED] wrote: Author: mturk Date: Thu Jun 28 23:32:27 2007 New Revision: 551809 URL: http://svn.apache.org/viewvc?view=revrev=551809 Log: Fix potential overflow. The actual encoded string length is strlen + 3 (Two bytes for len and one '\0') Modified:

Re: svn commit: r551809 - /tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c

2007-06-29 Thread Mladen Turk
jean-frederic clere wrote: /* We checked for space !! */ -strncpy((char *)msg-buf + msg-len, param, len + 1); /* including \0 */ +memcpy(msg-buf + msg-len, param, len + 1); /* including \0 */ Why do you remove the (char *)? Cause memcpy uses void* so no need for