Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-08 Thread Filip Hanik - Dev Lists
ignore my prev email about the mem leak, I wasn't up to current in trunk, and was running into something else Filip [EMAIL PROTECTED] wrote: Author: markt Date: Mon Apr 7 15:47:54 2008 New Revision: 645722 URL: http://svn.apache.org/viewvc?rev=645722&view=rev Log: All of the issues I was see

Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-08 Thread Filip Hanik - Dev Lists
just taking a quick look at the patch, this is a memory leak. the buffer will simply grow larger and larger until an OOM happens, if one keeps marking the buffer when I am more awake, I'll help out on this, it's very easy to reproduce http://people.apache.org/~fhanik/upload-mark.jsp Filip [EMA

Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-07 Thread Mark Thomas
Remy Maucherat wrote: On Mon, 2008-04-07 at 22:47 +, [EMAIL PROTECTED] wrote: Author: markt Date: Mon Apr 7 15:47:54 2008 New Revision: 645722 URL: http://svn.apache.org/viewvc?rev=645722&view=rev Log: All of the issues I was seeing with mark/reset were due to states that resulted in a cal

Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-07 Thread Remy Maucherat
On Mon, 2008-04-07 at 22:47 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Mon Apr 7 15:47:54 2008 > New Revision: 645722 > > URL: http://svn.apache.org/viewvc?rev=645722&view=rev > Log: > All of the issues I was seeing with mark/reset were due to states that > resulted in a call to Char

svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-07 Thread markt
Author: markt Date: Mon Apr 7 15:47:54 2008 New Revision: 645722 URL: http://svn.apache.org/viewvc?rev=645722&view=rev Log: All of the issues I was seeing with mark/reset were due to states that resulted in a call to CharChunk.flushBuffer(). I tried many different ways to fix it but by far the s