Author: rjung
Date: Sun Mar 29 16:42:21 2009
New Revision: 759722
URL: http://svn.apache.org/viewvc?rev=759722&view=rev
Log:
Vote, comment, add diff URLs.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=759722&r1=759721&r2=759722&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Mar 29 16:42:21 2009
@@ -148,7 +148,7 @@
* Fix typo in OPTIONS response
http://svn.apache.org/viewvc?rev=757774&view=rev
- +1: markt
+ +1: markt, rjung
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46908
@@ -161,35 +161,46 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46875
http://svn.apache.org/viewvc?rev=758407&view=rev
Catch possible ISE as a result of session expiration in comet valve
- +1: markt
+ +1: markt, rjung
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46866
http://svn.apache.org/viewvc?rev=758596&view=rev
Better init of Random objects
- +1: markt
+ +1: markt, rjung
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46822
http://svn.apache.org/viewvc?rev=758616&view=rev
Remove unnecessary object creation in StandardContext
- +1: markt
+ +1: markt, rjung
-1:
+ rjung: firePropertyChange() creates a PropertyChangeEvent, which only has
+ object type arguments in the constructor. Brief inspection of the Sun
JDK
+ shows, that the firePropertyChange() method with primitive type
arguments
+ first converts them to objects and then creates the
PropertyChangeEvent().
+ So in general there will be no object creation safed, although in some
+ cases we use e.g. "new Boolean" instead of Boolean.valueOf(), so
there might be
+ some savings.
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46915
When resolving ResourceBundle properties, don't claim to have resolved the
property unless we really have resolved it.
http://svn.apache.org/viewvc?rev=758664&view=rev
- +1: markt
+ +1: markt, rjung
-1:
+ rjung: r758664 (above URL) contains strange whitespace.
+ Seems tabs are mixed with spaces.
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41606
Prevent double init() of JSP
Patch provided by Chris Halstead
- +1: markt
+ http://svn.apache.org/viewvc?view=rev&revision=759074
+ +1: markt, rjung
-1:
- * Fix encoding when filtering French properties files, by using in build.xml:
+* Fix encoding when filtering French properties files, by using in build.xml:
+ http://svn.apache.org/viewvc?view=rev&revision=759720
@@ -128,7 +128,7 @@
<filter token="VERSION" value="${version}"/>
<filter token="VERSION_NUMBER" value="${version.number}"/>
@@ -199,5 +210,5 @@
<fileset dir="java">
<include name="**/*.properties"/>
<include name="**/*.dtd"/>
- +1: remm
+ +1: remm, rjung
-1:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
