svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 23:54:24 2009 New Revision: 882008 URL: http://svn.apache.org/viewvc?rev=882008view=rev Log: Fix theorectical sync issue and soem Eclipse warnings Modified: tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java Modified:

Re: svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread Konstantin Kolinko
2009/11/19 ma...@apache.org: Author: markt Date: Wed Nov 18 23:54:24 2009 New Revision: 882008 +        // If the thread is not bound, return a shared writable context +        if (initialContext == null) { +            if (initialContext == null) { +                synchronized(this) {

Re: svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread Konstantin Kolinko
2009/11/19 Mark Thomas ma...@apache.org: Konstantin Kolinko wrote: twice the same condition Thanks - I'll fix that. OK, seen that. On second thought: it is strange to synchronize on this to set a static field. That should be synchronized(getClass()) Best regards, Konstantin Kolinko

Re: svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread Mark Thomas
Konstantin Kolinko wrote: 2009/11/19 Mark Thomas ma...@apache.org: Konstantin Kolinko wrote: twice the same condition Thanks - I'll fix that. OK, seen that. On second thought: it is strange to synchronize on this to set a static field. That should be synchronized(getClass()) Fair