Re: svn commit: r920907 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

2010-03-09 Thread Mark Thomas
On 09/03/2010 15:10, Konstantin Kolinko wrote: 2010/3/9ma...@apache.org: Author: markt Date: Tue Mar 9 15:01:05 2010 New Revision: 920907 URL: http://svn.apache.org/viewvc?rev=920907view=rev Log: Review feedback 1. getNameFromAttribute() returns the attribute name, not the variable name and

svn commit: r920907 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

2010-03-09 Thread markt
Author: markt Date: Tue Mar 9 15:01:05 2010 New Revision: 920907 URL: http://svn.apache.org/viewvc?rev=920907view=rev Log: Review feedback 1. getNameFromAttribute() returns the attribute name, not the variable name and 2. This is a translation time test so the attribute value is not known

Re: svn commit: r920907 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

2010-03-09 Thread Konstantin Kolinko
2010/3/9 ma...@apache.org: Author: markt Date: Tue Mar  9 15:01:05 2010 New Revision: 920907 URL: http://svn.apache.org/viewvc?rev=920907view=rev Log: Review feedback 1. getNameFromAttribute() returns the attribute name, not the variable name and 2. This is a translation time test so