ChristopherSchultz commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864828084
> 1. There are case-insensitive file systems out there... I wonder whether
those default extensions should be treated case-insensitively. (If one is
serving a web site from an
kkolinko commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864808958
1. There are case-insensitive file systems out there... I wonder whether
those default extensions should be treated case-insensitively. (If one is
serving a web site from an USB stick or a
ChristopherSchultz commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864951885
> Re 4: I think that if one is wise enough to write a RegExp, they could use
"|" to combine several patterns, and do not really need splitting by comma. Or
do you envision a use
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1433225531
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest
request) {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434514917
##
webapps/docs/config/filter.xml:
##
@@ -291,6 +291,13 @@
request. The default value is 403.
+
+A flag to enable or disable
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434524088
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String
parameterName) {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434511388
##
webapps/docs/config/filter.xml:
##
@@ -319,6 +326,34 @@
of java.security.SecureRandom will be used.
+
+A list of URL
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434513367
##
webapps/docs/config/filter.xml:
##
@@ -319,6 +326,34 @@
of java.security.SecureRandom will be used.
+
+A list of URL patterns that
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434512783
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest
request) {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434521612
##
webapps/docs/config/filter.xml:
##
@@ -319,6 +326,34 @@
of java.security.SecureRandom will be used.
+
+A list of URL
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434510673
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest
request) {
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434518590
##
webapps/docs/config/filter.xml:
##
@@ -291,6 +291,13 @@
request. The default value is 403.
+
+A flag to enable or disable
zoumuzou commented on issue #51:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/51#issuecomment-1851193071
OK, thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] opened a new pull request, #680:
URL: https://github.com/apache/tomcat/pull/680
Bumps org.apache.tomcat:tomcat-catalina from 10.1.15 to 10.1.16.
[![Dependabot compatibility
ChristopherSchultz commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1875476100
> > Re 4: I think that if one is wise enough to write a RegExp, they could
use "|" to combine several patterns, and do not really need splitting by comma.
>
> I suppose if
janbrasna opened a new pull request, #682:
URL: https://github.com/apache/tomcat/pull/682
Trivial wording fix for config docs.
_(Unfortunately goes all the way back to `9.0.x` and `8.5.x`)_
--
This is an automated message from the Apache Git Service.
To respond to the message,
lbliangbin closed pull request #683: Fix websocket processor leaks when
WsSession expires and server send …
URL: https://github.com/apache/tomcat/pull/683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jjohannes opened a new pull request, #684:
URL: https://github.com/apache/tomcat/pull/684
This package no longer exits in `tomcat-embed-core.jar`. It is in the
'module-info.class' of the current `10.1.18` and earlier `10.x` releases.
Running `jlink` or `jpackage` with a Module Path
markt-asf commented on PR #684:
URL: https://github.com/apache/tomcat/pull/684#issuecomment-1891608646
Fixed manually in main for 11.0.x (with change log entry) and then
back-ported (cherry-picked) to 10.1.x and 9.0.x.
--
This is an automated message from the Apache Git Service.
To
markt-asf closed pull request #684: Remove org.apache.catalina.ssi from
tomcat-embed-core.jar.tmp.bnd
URL: https://github.com/apache/tomcat/pull/684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jjohannes commented on PR #684:
URL: https://github.com/apache/tomcat/pull/684#issuecomment-1891752142
Thanks @markt-asf!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
fhanik opened a new pull request, #1:
URL: https://github.com/apache/tomcat-tck/pull/1
Fix header typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
markt-asf closed pull request #680: Bump org.apache.tomcat:tomcat-catalina from
10.1.15 to 10.1.16 in /modules/owb
URL: https://github.com/apache/tomcat/pull/680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
markt-asf commented on PR #680:
URL: https://github.com/apache/tomcat/pull/680#issuecomment-1893441250
Out of date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] commented on PR #680:
URL: https://github.com/apache/tomcat/pull/680#issuecomment-1893441318
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
markt-asf commented on PR #683:
URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898853883
Thanks. The reference to the description on the users list helps. I'll look
at this again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
imario42 commented on PR #683:
URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898787616
@markt-asf : He described his findings in that tomcat-user post
[https://lists.apache.org/thread/vyog0dyxwq3hlpjgt2vb1wkrxw6x2h1k](url)
However, I do not know if his patch works.
markt-asf commented on PR #683:
URL: https://github.com/apache/tomcat/pull/683#issuecomment-189414
The description of the problem and the analysis of the root cause (the BZ
66508 fix) is correct but the proposed fix is not. It will probably work the
majority of the time but there is a
markt-asf commented on PR #683:
URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898765701
No evidence provided to support claim of a leak.
No leak observed when testing with profiler.
No obvious reason that proposed patch would impact `UpgradeProcessor`
instances (or
markt-asf closed pull request #683: Fix websocket processor leaks when
WsSession expires and server sends close message by WsBackgroundThread
URL: https://github.com/apache/tomcat/pull/683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
markt-asf commented on PR #682:
URL: https://github.com/apache/tomcat/pull/682#issuecomment-1899075283
Tx. I'll back-port this fix shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
markt-asf commented on PR #683:
URL: https://github.com/apache/tomcat/pull/683#issuecomment-1899074074
Fixed and back-ported. Will be in the February releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
markt-asf merged PR #682:
URL: https://github.com/apache/tomcat/pull/682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf closed pull request #683: Fix websocket processor leaks when
WsSession expires and server sends close message by WsBackgroundThread
URL: https://github.com/apache/tomcat/pull/683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431610887
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431612056
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431615348
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431618064
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1436107052
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String
parameterName) {
BTrees opened a new pull request, #679:
URL: https://github.com/apache/tomcat/pull/679
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aooohan closed pull request #679: Update README.md
URL: https://github.com/apache/tomcat/pull/679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
glendagonzales closed pull request #42: PDS-4683 upgrade tomcat for security
reasons
URL: https://github.com/apache/tomcat-maven-plugin/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
markt-asf commented on PR #685:
URL: https://github.com/apache/tomcat/pull/685#issuecomment-1910670058
Thanks for reporting this.
Looks like most of the embedded JARs got missed but EL was updated for
embedded but not the standalone JAR in BZ 66834. I have a fix I'll push shortly
that
markt-asf closed pull request #685: Update to use JakartaExpressionLanguage
osgi.contract
URL: https://github.com/apache/tomcat/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
markt-asf commented on PR #685:
URL: https://github.com/apache/tomcat/pull/685#issuecomment-1910685730
Broader fix applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
DanielThomas commented on issue #48:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/48#issuecomment-1913758414
Some improvements got made to this mitigation in later JDK releases, due to
false positives in the detection, so I think this has been addressed upstream.
--
ChristopherSchultz merged PR #681:
URL: https://github.com/apache/tomcat/pull/681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chenbiaoit commented on PR #683:
URL: https://github.com/apache/tomcat/pull/683#issuecomment-1923029828
> Fixed and back-ported. Will be in the February releases.
Hi @markt-asf,What channel can I use to know that this problem has been
fixed? Thank you very much.
--
This is an
ChristopherSchultz commented on PR #683:
URL: https://github.com/apache/tomcat/pull/683#issuecomment-1924044806
> > Fixed and back-ported. Will be in the February releases.
>
> Hi @markt-asf,What channel can I use to know that this problem has been
fixed? Thank you very much.
pnicolucci opened a new pull request, #685:
URL: https://github.com/apache/tomcat/pull/685
I opened: https://bz.apache.org/bugzilla/show_bug.cgi?id=66834 last year and
upon looking at the latest M16 release of Expression Language 6.0 here:
aooohan commented on PR #678:
URL: https://github.com/apache/tomcat/pull/678#issuecomment-1818083370
This is an internal fork project which not belong to Tomcat. You should move
this change to [Apache Commons DBCP](https://github.com/apache/commons-dbcp).
--
This is an automated message
aooohan closed pull request #678: Add support for RequestBoudaries in DBCP
URL: https://github.com/apache/tomcat/pull/678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jfclere closed pull request #641: Making sure that stop is not "blocked" by the
check() in HostConfig
URL: https://github.com/apache/tomcat/pull/641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jfclere commented on PR #641:
URL: https://github.com/apache/tomcat/pull/641#issuecomment-1819080600
See
https://github.com/apache/tomcat/commit/dce1fc833b5192ec0ccee7d4120a050cee5da8de
the exceptions are gone but now the stop() is blocked by the check(String
name) but the fix is easy
markt-asf merged PR #50:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
meedbek opened a new pull request, #678:
URL: https://github.com/apache/tomcat/pull/678
JDBC 4.3 introduced `beginRequest` and `endRequest` methods for connection
pools which are called to mark request boundaries.
`beginRequest` should be called when borrowing a connection and
KoteswararaoGundapaneni commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1816164863
Requesting to panel the change request to be considering and request has
been taken care by the process that's done above
--
This is an automated message from the Apache
KoteswararaoGundapaneni commented on PR #678:
URL: https://github.com/apache/tomcat/pull/678#issuecomment-1817334170
Hi Meedbek Please allow to work on this for offline to assist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
KoteswararaoGundapaneni commented on PR #678:
URL: https://github.com/apache/tomcat/pull/678#issuecomment-1817359611
still there is no presence of beginRequest in our code when i checked in dbcp
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dependabot[bot] closed pull request #2: Bump derby from 10.4.2.0 to 10.14.2.0
in /standard-examples
URL: https://github.com/apache/tomcat-taglibs-standard/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dependabot[bot] opened a new pull request, #9:
URL: https://github.com/apache/tomcat-taglibs-standard/pull/9
Bumps org.apache.derby:derby from 10.4.2.0 to 10.17.1.0.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #8:
URL: https://github.com/apache/tomcat-taglibs-standard/pull/8
Bumps org.apache.derby:derby from 10.4.2.0 to 10.17.1.0.
[![Dependabot compatibility
dependabot[bot] commented on PR #2:
URL:
https://github.com/apache/tomcat-taglibs-standard/pull/2#issuecomment-1819973208
Superseded by #8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] closed pull request #3: Bump derby from 10.4.2.0 to 10.14.2.0
in /standard-test
URL: https://github.com/apache/tomcat-taglibs-standard/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] commented on PR #3:
URL:
https://github.com/apache/tomcat-taglibs-standard/pull/3#issuecomment-1819973270
Superseded by #9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
markt-asf merged PR #1:
URL: https://github.com/apache/tomcat-tck/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] opened a new pull request, #715:
URL: https://github.com/apache/tomcat/pull/715
Bumps org.apache.tomcat:tomcat-coyote from 11.0.0-M14 to 11.0.0-M17.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #714:
URL: https://github.com/apache/tomcat/pull/714
Bumps org.apache.tomcat:tomcat-websocket from 11.0.0-M16 to 11.0.0-M17.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #716:
URL: https://github.com/apache/tomcat/pull/716
Bumps org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #717:
URL: https://github.com/apache/tomcat/pull/717
Bumps org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86.
[![Dependabot compatibility
dependabot[bot] commented on PR #714:
URL: https://github.com/apache/tomcat/pull/714#issuecomment-2050326037
Looks like org.apache.tomcat:tomcat-websocket is up-to-date now, so this is
no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the
dependabot[bot] commented on PR #716:
URL: https://github.com/apache/tomcat/pull/716#issuecomment-2050326279
Looks like org.apache.tomcat:tomcat-coyote is up-to-date now, so this is no
longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dependabot[bot] closed pull request #716: Bump org.apache.tomcat:tomcat-coyote
from 9.0.83 to 9.0.86 in /modules/openssl-java21
URL: https://github.com/apache/tomcat/pull/716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dependabot[bot] commented on PR #715:
URL: https://github.com/apache/tomcat/pull/715#issuecomment-2050326108
Looks like org.apache.tomcat:tomcat-coyote is up-to-date now, so this is no
longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dependabot[bot] closed pull request #714: Bump
org.apache.tomcat:tomcat-websocket from 11.0.0-M16 to 11.0.0-M17 in
/modules/stuffed
URL: https://github.com/apache/tomcat/pull/714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dependabot[bot] closed pull request #717: Bump org.apache.tomcat:tomcat-coyote
from 9.0.83 to 9.0.86 in /modules/openssl-java17
URL: https://github.com/apache/tomcat/pull/717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dependabot[bot] commented on PR #717:
URL: https://github.com/apache/tomcat/pull/717#issuecomment-2050326077
Looks like org.apache.tomcat:tomcat-coyote is up-to-date now, so this is no
longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dependabot[bot] closed pull request #715: Bump org.apache.tomcat:tomcat-coyote
from 11.0.0-M14 to 11.0.0-M17 in /modules/openssl-foreign
URL: https://github.com/apache/tomcat/pull/715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
achibear opened a new pull request, #718:
URL: https://github.com/apache/tomcat/pull/718
Tomcat 8 fixed the CVE-2024-23672 vulnerability through commit
[3631adb1](https://github.com/apache/tomcat/commit/3631adb1342d8bbd8598802a12b63ad02c37d591).
However, we have discovered similar
aooohan closed pull request #718: fix CVE-2024-23672
URL: https://github.com/apache/tomcat/pull/718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aooohan commented on PR #718:
URL: https://github.com/apache/tomcat/pull/718#issuecomment-2050851432
Tomcat 7 is end of life since March 2021, so we won't merge this change,
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hazendaz commented on PR #718:
URL: https://github.com/apache/tomcat/pull/718#issuecomment-2050846843
Not speaking for team but as onlooker, Tomcat 7 is end of life since March
2021. There are no further updates. So it wouldn't make sense to patch it.
It wouldn't be released anyways.
rmaucher closed pull request #713: Sessioncounter
URL: https://github.com/apache/tomcat/pull/713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rmaucher commented on PR #713:
URL: https://github.com/apache/tomcat/pull/713#issuecomment-2051302240
Thanks for pointing this out. Since tracking too many redundant stats is not
super useful, I decided to remove this one (it is now approximated by adding
the active sessions to the expired
qauck opened a new pull request, #719:
URL: https://github.com/apache/tomcat/pull/719
These attributes no longer existing in corresponding
org.apache.tomcat.util.net.NioEndpoint, which will cause
java.lang.NoSuchMethodException at run time.
--
This is an automated message from the
ilapavuluri opened a new issue, #55:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/55
I am using tomcat transformer for javax to jakarta conversion, in the
similar lines I converted my activemq-all 5.16.7 into jakarta using the same
tomcat transformer, no errors during
jose-galvez opened a new pull request, #720:
URL: https://github.com/apache/tomcat/pull/720
commit
[a8575ef](https://github.com/apache/tomcat/commit/a8575efbc1de64fe58c8fd99e53a0011b59a8e86)
removed support for seconds with floating point for the Extended Access Log
Valve and made it only
markt-asf commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061540617
From memory that change was to align Tomcat's access log configuration with
httpd. It may well be that the correct fix here is to correct the documentation.
Separately, comparing this
jose-galvez commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061821679
> From memory that change was to align Tomcat's access log configuration
with httpd. It may well be that the correct fix here is to correct the
documentation. Separately, comparing this
ChristopherSchultz commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061771435
Why not use `%D` which is in milliseconds (Tomcat <10) or microseconds
(Tomcat >= 10)?
--
This is an automated message from the Apache Git Service.
To respond to the message,
jose-galvez commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061838297
> Why not use `%D` which is in milliseconds (Tomcat <10) or microseconds
(Tomcat >= 10)?
I wanted to keep parity on the behavior here with previous versions,
especially because
markt-asf commented on code in PR #721:
URL: https://github.com/apache/tomcat/pull/721#discussion_r1572780769
##
java/org/apache/catalina/valves/AbstractAccessLogValve.java:
##
@@ -1756,10 +1776,14 @@ protected AccessLogElement
createAccessLogElement(String name, char pattern)
jose-galvez commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063746801
It can, but in this case the documentation states that it didn't so I was
trying to bring it back to how it behaved before (which as an added bonus helps
us not change our scripts).
ChristopherSchultz commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063868914
Oh, I'm' sorry I didn't pick-up on the subtleties of your report.
Tomcat 10.1 is documented that the value for `%T` is in (presumably _whole_)
seconds. Tomcat 9 says it's
ChristopherSchultz commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063733345
So nothing can ever change, then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jose-galvez commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2064310044
> Are you specifically talking about the ExtendedAccessLogValve's
`time-taken` token? If so, you're right, that documentation did not change yet
the underlying implementation did
xsimo opened a new pull request, #724:
URL: https://github.com/apache/tomcat/pull/724
Managing multiple tomcats on multiple servers, the need came to have a way
of customizing the Manager HTML interface.
This PR proposes to add a simple configurable html subtitle.
Hakky54 commented on PR #706:
URL: https://github.com/apache/tomcat/pull/706#issuecomment-2049034933
Hi @markt-asf
What do you think of this PR, would it make sense to have this kind of
wrapper, or does it needs to be adjusted or would you like me to close it and
disregard it?
ChristopherSchultz merged PR #721:
URL: https://github.com/apache/tomcat/pull/721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ChristopherSchultz commented on code in PR #721:
URL: https://github.com/apache/tomcat/pull/721#discussion_r1578085100
##
java/org/apache/catalina/valves/AbstractAccessLogValve.java:
##
@@ -1756,10 +1776,14 @@ protected AccessLogElement
createAccessLogElement(String name, char
901 - 1000 of 1182 matches
Mail list logo
