Hi
seems there is a taglib validation issue we should encounter pretty
quickly (in particular in certified envrt), it should be hacked too or
we have to workaround it no?
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibuc
well, not sure how we can merge pull request btw (I know maven does it
but they have some infra, not sure we have ATM), the easier is to send
us (attaching it to jira) a patch we can apply from the tomee trunk
(patch -p0 < yourpatch.patch).
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rman
Hi folks,
That is what I tried to ask in the first message in this thread:
- I rebased my local branch to trunk, then I added my commit and pushed it
to github. Then I created a pull request. However github wants to merge it
to apache/tomee-1.5.2, together with 906 other commits. I don't know how
Hi
https://github.com/apache/tomee/pull/2/files seems a pretty big diff,
are you sure you rebased correctly?
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014/1/8 Jean-Loui
Ivan,
Creating a patch file is really trivial. Just add ".patch" at the end of
the URL you gave me.
The main issue there is that your pull request is currently also including
a lot of more changes.
Jean-Louis
2014/1/8 Ivan St. Ivanov
> Hi Jean-Louis!
>
> Here is the pull request: https://gith
Hi Jean-Louis!
Here is the pull request: https://github.com/apache/tomee/pull/2
I would appreciate if you tell me how to create the patch myself :)
Thanks,
Ivan
On Wed, Jan 8, 2014 at 10:27 AM, Jean-Louis MONTEIRO wrote:
> Hi Ivan,
>
> The JIRA is affected to you now and I added you as a cont
Hi Ivan,
The JIRA is affected to you now and I added you as a contributor.
We did not switch yet on git. That's why I asked for a patch instead of a
pull request.
Can you give me the link of the pull request?
Thanks
JLouis
2014/1/7 Ivan St. Ivanov
> Hi Jean-Louis!
>
> Thank you for the answe
