Re: WebAppDeployer does not support undeploy

2015-05-16 Thread Mark Struberg
Found at least a partial explanation. The servlet spec indeed does not mandate that sessionDestroyed gets fired on undeploy or shutdown. Instead tomcat serializes the sessions away to a file and reads it again if you start up the application again. This is indeed a cool feature for 24/7 suppor

Re: [VOTE] Release Apache TomEE 1.7.2

2015-05-16 Thread Romain Manni-Bucau
some feedback from deltaspike (Gerhard): on windows the issue Andy reported is real and blocking: "Unable to start remote container" deltaspike\core\impl\C\maven-repository\org\apache\openejb\apache-tomee\1.7.2\apache-tomee-1.7.2-webprofile.zip So I guess we need to cancel this vote since it is a

Re: WebAppDeployer does not support undeploy

2015-05-16 Thread Romain Manni-Bucau
will connect on IRC now but this was working for sure since I fixed it twice working on TCKs Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn

Re: WebAppDeployer does not support undeploy

2015-05-16 Thread Mark Struberg
Btw this TCK test also blurps up in master, but weirdly it seems to pass: INFO: Invoke SessionContextAsyncListenerTest.testSessionContextActiveOnError: 273/1,494 (124) May 15, 2015 2:03:56 PM com.gargoylesoftware.htmlunit.WebClient printContentIfNecessary INFO: statusCode=[500] contentType=[text

Re: WebAppDeployer does not support undeploy

2015-05-16 Thread Mark Struberg
debugged this in master as well and it is also broken. I guess we just didn’t detect this as in the old OWB version we simply cleaned out all SessionContexts we maintained in a HashMap. But in OWB-1.6.0 we now use the real HttpSession so we fail to clean this up properly. With other words: it wa

Re: WebAppDeployer does not support undeploy

2015-05-16 Thread Romain Manni-Bucau
Le 16 mai 2015 15:12, "Mark Struberg" a écrit : > > And yet a bit more info. > > What happens when an app is undeployed using Arquillian then > > 1.) the CDI container (OpenEJBLifecycle implements ContainerLifecycle#stop) gets shut down. This will also stop the contexts it has access to. That does

Re: WebAppDeployer does not support undeploy

2015-05-16 Thread Mark Struberg
And yet a bit more info. What happens when an app is undeployed using Arquillian then 1.) the CDI container (OpenEJBLifecycle implements ContainerLifecycle#stop) gets shut down. This will also stop the contexts it has access to. That does NOT include SessionContexts anymore… 2.) the webapp g

Re: WebAppDeployer does not support undeploy

2015-05-16 Thread Romain Manni-Bucau
Le 16 mai 2015 14:42, "Mark Struberg" a écrit : > > when using arquillian that seems not to be the case afaics. > Lifecycle is a little bit different but needs to be handled as well - and both are conform to the spec. > openejb Assembler#destroyApplication(final AppInfo appInfo) just looks up th

Re: WebAppDeployer does not support undeploy

2015-05-16 Thread Mark Struberg
when using arquillian that seems not to be the case afaics. openejb Assembler#destroyApplication(final AppInfo appInfo) just looks up the WebBeansLifecycle from OpenWebBeans and shuts it down. By doing this it will also destroy the various contexts. But this does _not_ destroy any _real_ Sessio

Re: [VOTE] Release Apache TomEE 1.7.2

2015-05-16 Thread Mark Struberg
+1 tested with 3 of my customers apps in embedded (openejb) + web server mode (tomee) without any issues so far. LieGrue, strub > Am 12.05.2015 um 14:58 schrieb Jonathan Gallimore : > > Hi > > I have rolled the latest 1.7.2 binaries, and I think we're ready for a > vote, so here goes. > > G

Re: WebAppDeployer does not support undeploy

2015-05-16 Thread Romain Manni-Bucau
Normal undeployment will call tomcat one. Same way as we have to support for ears so important to have it working this way. Le 16 mai 2015 12:40, "Mark Struberg" a écrit : > Just saw that my sentence is very ambiguous. > Of course the undeploy is perfectly fine IF we just use the standard > tomca

Re: WebAppDeployer does not support undeploy

2015-05-16 Thread Mark Struberg
Just saw that my sentence is very ambiguous. Of course the undeploy is perfectly fine IF we just use the standard tomcat deploy/undeploy. But we do not cleanly undeploy via Arquillian (which is used in the TCK). LieGrue, strub > Am 16.05.2015 um 11:38 schrieb Mark Struberg : > > Hi! > > We ha

WebAppDeployer does not support undeploy

2015-05-16 Thread Mark Struberg
Hi! We have 2 TCK tests (of the last 4 failing ones) who test the undeploy scenario. They fail as they rely on a clean undeploy - which we do not do atm it seems. In DeployerEJB we do a clean deploy via WebAppDeployer#deploy(). This creates the Tomcat Context and starts the webapp. But this se