Re: OpenEJB/TomEE static code analysis

2016-09-14 Thread Svetlin Zarev
Hi, I think I've fixed[1] all stream leaks to files or streams opened by classLoader.getResoureAsStream(). I intentionally ignored all streams opened bu UrlConnection, because the issue with the connection pooling has to be researched. I also reopened [2] because the patch is only for slurp(File)

Re: OpenEJB/TomEE static code analysis

2016-09-14 Thread Romain Manni-Bucau
Tomee is java 7 for 7.x by spec do java 8 is not an option On the fixes: ensure to unit test each non trivial fix but you can put all the "same" category ones in the same pr. Like "ensure streams are closed". Side note on this particular one: since we pool connections sometimes closing the stream

Re: OpenEJB/TomEE static code analysis

2016-09-14 Thread Mitia Alexandrov
Hello, I've made several such runs from Idea but mainly for Java 8fy reasons. There are also several thousand places where the code may be rewritten with java 8 constructions. Regards, Mitia 2016-09-14 10:35 GMT+03:00 Svetlin Zarev : > Dear TomEE developers, > > I've been running static code an

OpenEJB/TomEE static code analysis

2016-09-14 Thread Svetlin Zarev
Dear TomEE developers, I've been running static code analysis (fortify) against TomEE 7 and as a result I have a list of more than 8000 potential issues (I hope most of them are false positives). Unfortunately I'm not allowed to share the list itself. Either way I'll have to go through that list