It is the fix, originally alternative=true was a very secured impl cause
even with a poorly setup test it was passing but it was wrong. Maybe it is
worth a ticket to have it in the changelog but no doubt we are good now.
Le 16 avr. 2018 07:41, "Mark Struberg" a écrit :
> Hi jon!
>
> Most probabl
Will review and apply later.
LieGrue,
Strub
> Am 16.04.2018 um 07:16 schrieb Romain Manni-Bucau :
>
> (Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
> member of the community review it since, as you mentionned, idea was coming
> from me but happy to apply it after.
>
Hi jon!
Most probably has to do with fixing OWB-1209.
A custom Bean which is an @Alternative also must be enabled via beans.xml as
per the spec :(
I know this is not convenient, but thats what the spec says.
From CDI-2.0 onwards one can add the Prioritized interface and add a priority n
a prog
(Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
member of the community review it since, as you mentionned, idea was coming
from me but happy to apply it after.
Le 15 avr. 2018 22:28, "Jonathan Gallimore"
a écrit :
> Hi,
>
> This discussion originated on the TomEE dev@
(Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
member of the community review it since, as you mentionned, idea was coming
from me but happy to apply it after.
Le 15 avr. 2018 22:28, "Jonathan Gallimore"
a écrit :
> Hi,
>
> This discussion originated on the TomEE dev@
On the openejb-mockito test failure - forget my previous emails - setting
the MockBean to not be an AlternativeBean seems to do the trick. Pushed.
Lets see what we get from the CI now.
Cheers
Jon
On Sun, Apr 15, 2018 at 9:43 PM, Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> OK, I'
OK, I'm not sure which commit causes that test failure, but this commit is
ok:
https://github.com/apache/openwebbeans/commit/4b7259a1f7c8c0d65736f753df9e6a43a262ed96.
Will try and pin it down.
In other news - Johnzon patch submitted, and discussion opened on the
Johnzon dev@ mailing list. Will kee
Hi,
This discussion originated on the TomEE dev@ list, but I think it is more
appropriate that it continue here. Effectively I'm looking at trying to
provide a 1.0.1 version of Johnzon that is at the the same API level as
1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
Thanks all!
I have looked at the test failures on the CI. The bval-embedded tests
should be ok now - the other failures were in the openejb-mockito module,
and I think they relate to this change in OWB:
https://github.com/apache/openwebbeans/commit/89c18915afc2173ec1c5478ca6dc09ecce322d2a
To be h
done.
LieGrue,
strub
> Am 15.04.2018 um 12:02 schrieb Mark Struberg :
>
> Yes, will fix openjpa and push a snapshot when back home.
>
> Lgm
>
>> Am 15.04.2018 um 07:15 schrieb Alex The Rocker :
>>
>> Hello Jon,
>>
>> Sounds like very good news!
>> I'm ready to run our real-life tests with an
Yes, will fix openjpa and push a snapshot when back home.
Lgm
> Am 15.04.2018 um 07:15 schrieb Alex The Rocker :
>
> Hello Jon,
>
> Sounds like very good news!
> I'm ready to run our real-life tests with any preview of Johnzon 1.0.1
> if it's compatible with current TomEE 7.0.4 (and of course I
Thanks Romain. I'll pick up the build issues on the CI later today.
Jon
On Sun, 15 Apr 2018, 08:21 Romain Manni-Bucau,
wrote:
> I can probably deploy openjpa snapshot on monday if still needed but not
> this week end.
>
> Le 15 avr. 2018 07:16, "Alex The Rocker" a écrit :
>
> > Hello Jon,
> >
I can probably deploy openjpa snapshot on monday if still needed but not
this week end.
Le 15 avr. 2018 07:16, "Alex The Rocker" a écrit :
> Hello Jon,
>
> Sounds like very good news!
> I'm ready to run our real-life tests with any preview of Johnzon 1.0.1
> if it's compatible with current TomEE
13 matches
Mail list logo