Re: Connector issues

2018-10-04 Thread Jean-Louis Monteiro
Great note Jon. Thanks it's appreciated +1 Le jeu. 4 oct. 2018 à 12:01, Romain Manni-Bucau a écrit : > +1 looks good > > Romain Manni-Bucau > @rmannibucau | Blog > | Old Blog > | Github < >

Re: TomEE 8 Release Preview

2018-10-04 Thread Roberto Cortez
I understand. Was just trying to give more detail into it. I’ll have a better look and try to come up with some test scenarios. > On 4 Oct 2018, at 10:47, Romain Manni-Bucau wrote: > > Le jeu. 4 oct. 2018 à 11:42, Roberto Cortez > a > écrit : > >> Hi Romain

Re: TomEE 8 Release Preview

2018-10-04 Thread Romain Manni-Bucau
Le jeu. 4 oct. 2018 à 11:42, Roberto Cortez a écrit : > Hi Romain, > > Well the exception being thrown is not the actual exception. > > This was only happening in the MP binary due to the OpenAPI Geronimo > implementation. In the DefaultLoader the ServletContext is injected, but at > the time tha

Re: Connector issues

2018-10-04 Thread Romain Manni-Bucau
+1 looks good Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: Connector issues

2018-10-04 Thread Jonathan Gallimore
I have pushed some commits onto the PR here: https://github.com/apache/tomee/pull/174, and would appreciate some review. One the things I found was that if I hold onto a reference to the proxy for the transaction, it doesn't get cleaned up, but then losing the reference from the scope at the end of

Re: TomEE 8 Release Preview

2018-10-04 Thread Roberto Cortez
Hi Romain, Well the exception being thrown is not the actual exception. This was only happening in the MP binary due to the OpenAPI Geronimo implementation. In the DefaultLoader the ServletContext is injected, but at the time that the JAX-RS app is deployed, which is in the AfterApplicationCrea

Re: TomEE 8 Release Preview

2018-10-04 Thread Romain Manni-Bucau
@Roberto: do we have a test to reproduce and prevent future regressions? If your fix is right the error message is quite unexpected so it would be better to ensure we don't break it unintentionnally (a side note is that setting a single webapp context and firing an event for all webapps can have th