Re: Is there someone looking for Microprofile Reactive at TomEE?

2018-11-20 Thread Romain Manni-Bucau
Ok so MP decided to be bloated as the old ee so we will get a light impl @geronimo - likely next year. Anyone wants to lead it since you asked? Le mar. 20 nov. 2018 13:44, Romain Manni-Bucau a écrit : > Hi Otavio, > > none yet and the existing ones are either bloated or don't integrate well >

MicroProfile rest client example

2018-11-20 Thread César Hernández Mendoza
Hi all, I'm planning to create a MicroProfile rest client example. I checked Ivan's example: mp-metrics-counted [1], I created a PR [2] for the work in progress in order to collect feedback and contributions as I move forward. As you can see I'm using the convention he used for the metrics

[GitHub] tomee pull request #210: WIP - Added basic structure for mp-rest-client exam...

2018-11-20 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/210 WIP - Added basic structure for mp-rest-client example maven project You can merge this pull request into a Git repository by running: $ git pull

Re: Secure websocket example

2018-11-20 Thread David Blevins
Sounds great, Bruno. For the directory name, perhaps: - websocket-basic-auth That way if someday we have JWT version based in MP JWT, it could be: - websocket-jwt-auth And now that I say it out loud, that could be an interesting example to write :) // possible contribution for anyone!

Re: Microprofile Metrics Example

2018-11-20 Thread Romain Manni-Bucau
Well it was not a big issue bit something to take care. The pr - not yet merged - is way more impacting users and kind of justifies to not use MP today :(. Le mar. 20 nov. 2018 22:39, César Hernández Mendoza a écrit : > Hi Romain, > > Did you test passing accept header or just in the browser

[GitHub] tomee pull request #209: mp-metrics-counted fixed a couple of typos

2018-11-20 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/209 mp-metrics-counted fixed a couple of typos You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee

Re: Microprofile Metrics Example

2018-11-20 Thread César Hernández Mendoza
Hi Romain, Did you test passing accept header or just in the browser which sends json > and text as acceptable value so resolution can be not that deterministic > using it - but this is the request so all fine ;). Yes, yesterday my test was performed using safari and that was causing the

Re: Re: TomEE8 RC2: MP Metrics @Counted throws 500

2018-11-20 Thread César Hernández Mendoza
Hi, I checked your example Ivan and I performed a couple of updates on my example project and now I have successful results. Following Roman feedback about lib folder issue, I specified in arquilliam.xml the microprofile classifier and also the project now uses Arquillian remote instead of

Re: TOMEE-2253 - tomee.sh -version not working properly with Java 11

2018-11-20 Thread Daniel Cunha
Hi Romain, Ok, I'll create a scenario for it. Thank you. Em ter, 20 de nov de 2018 às 17:29, Romain Manni-Bucau < rmannibu...@gmail.com> escreveu: > Hi Daniel > > Do you think you can assert the classloader in the execution thread didnt > change after the call? Was one concern and i didnt find

Re: TOMEE-2253 - tomee.sh -version not working properly with Java 11

2018-11-20 Thread Romain Manni-Bucau
Hi Daniel Do you think you can assert the classloader in the execution thread didnt change after the call? Was one concern and i didnt find the matching assert Le mar. 20 nov. 2018 20:00, Daniel Cunha a écrit : > Hi folks, > > I've added a new test with JAXRS, calling a command in my endpoint

[GitHub] tomee pull request #208: Fixed a couple CDI Examples

2018-11-20 Thread monsonhaefel
GitHub user monsonhaefel opened a pull request: https://github.com/apache/tomee/pull/208 Fixed a couple CDI Examples The README.md text in a `cdi-basic` and `cdi-alternative-and-stereotypes` examples required corrections. You can merge this pull request into a Git repository by

Re: TOMEE-2253 - tomee.sh -version not working properly with Java 11

2018-11-20 Thread Daniel Cunha
Hi folks, I've added a new test with JAXRS, calling a command in my endpoint from Bootstrap CLI. Please review the changes on my PR[1] and let me know what do you think about it. Thank you. :) [1] https://github.com/apache/tomee/pull/176 Em seg, 19 de nov de 2018 às 13:57, Daniel Cunha

Re: About TomEE Twitter account

2018-11-20 Thread Romain Manni-Bucau
What about a bot polling tweets in a github repo - with a scheduled date for instance? Then PR would be welcomed ;). Just needs a server (or even a free heroku pby or openshift). Le mar. 20 nov. 2018 18:57, David Blevins a écrit : > I would trust Mark Struberg with access to the twitter account

Re: About TomEE Twitter account

2018-11-20 Thread David Blevins
I would trust Mark Struberg with access to the twitter account to use impartially. Anyone with access to that account would need to intimately understand Apache's marketing and trademark policies. Otherwise it's kids playing with matches. A little more access could be good to help breath

Re: Microprofile Metrics Example

2018-11-20 Thread Ivan Junckes Filho
Thanks Jon. Cesar, I couldn't reproduce the monotonic=false as json here. It returns Prometheus if I don't send the header. Can you check this again? On Tue, Nov 20, 2018 at 2:41 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Looks great. I'll merge it in. Thanks for the

Re: Uses Boolean.valueof instaed of new instance

2018-11-20 Thread Jonathan Gallimore
Looks like the //NOPMD isn't needed after this change, so I've removed it. Thanks for the patch. Cheers Jon On Tue, Nov 20, 2018 at 5:02 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Interesting. I'm curious about the //NOPMD. Has anyone tried removing that > and seeing what

[GitHub] tomee pull request #206: Uses Boolean.valueof instaed of new instance

2018-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/206 ---

Re: Uses Boolean.valueof instaed of new instance

2018-11-20 Thread Jonathan Gallimore
Interesting. I'm curious about the //NOPMD. Has anyone tried removing that and seeing what the warning is? Jon On Tue, Nov 20, 2018 at 12:12 PM Bruno Baptista wrote: > Hi Otávio, > > I think that makes sense, It looks like It's the only place in the code > where we have that. > > Cheers > >

[GitHub] tomee pull request #207: TOMEE-2279 MP Metrics Counted example (new changes ...

2018-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/207 ---

Re: Re: TomEE8 RC2: MP Metrics @Counted throws 500

2018-11-20 Thread Ivan Junckes Filho
@César Hernandez , FYI the 500 / null pointer doesn't happen in the master. So it should be fixed in the next release of geronimo-metrics / TomEE MP. If you want to check a working example of metrics see https://github.com/apache/tomee/pull/207. On Tue, Nov 20, 2018 at 1:11 PM MoreFlavor

Re: Microprofile Metrics Example

2018-11-20 Thread Jonathan Gallimore
Looks great. I'll merge it in. Thanks for the contribution Ivan! On Tue, Nov 20, 2018 at 4:33 PM Daniel Cunha wrote: > Hi Ivan, > > really nice, the content on README is much better now. Nice work man! > Just pushing my +1 for your PR. :) > > Em ter, 20 de nov de 2018 às 13:14, Ivan Junckes

Re: Microprofile Metrics Example

2018-11-20 Thread Daniel Cunha
Hi Ivan, really nice, the content on README is much better now. Nice work man! Just pushing my +1 for your PR. :) Em ter, 20 de nov de 2018 às 13:14, Ivan Junckes Filho < ivanjunc...@gmail.com> escreveu: > Hey guys, could you please review this? > > https://github.com/apache/tomee/pull/207 > >

Re: About TomEE Twitter account

2018-11-20 Thread Daniel Cunha
We just move things on the list, but will be really awesome to keep the social accounts updated as well. Good catch. +1 Em ter, 20 de nov de 2018 às 12:38, César Hernández Mendoza < cesargu...@gmail.com> escreveu: > Hi, > > The last post from TomEE Twitter account [1] was on July 13th 2017, in

Re: Microprofile Metrics Example

2018-11-20 Thread Ivan Junckes Filho
Hey guys, could you please review this? https://github.com/apache/tomee/pull/207 This is the project for counted. I will add more projects for other types of metrics during the week. I would like to know if the README is good enough or if need more changes. Thanks. On Tue, Nov 20, 2018 at

About TomEE Twitter account

2018-11-20 Thread César Hernández Mendoza
Hi, The last post from TomEE Twitter account [1] was on July 13th 2017, in 2016 there were no posts at all. Is there a process to generate content on this twitter account? I think at least we could be posting when: - A new release is available - New content is generated by the community

Re: MicroProfile JWT 1.1

2018-11-20 Thread Jean-Louis Monteiro
Ok, yes I see it. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Tue, Nov 20, 2018 at 4:11 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > The commits are showing for me (at the bottom). Here's the latest one: > >

[GitHub] tomee pull request #207: MP Metrics Counted example (new changes based on fe...

2018-11-20 Thread ivanjunckes
GitHub user ivanjunckes opened a pull request: https://github.com/apache/tomee/pull/207 MP Metrics Counted example (new changes based on feedback) You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivanjunckes/tomee metrics-example

Re: MicroProfile JWT 1.1

2018-11-20 Thread Jonathan Gallimore
The commits are showing for me (at the bottom). Here's the latest one: https://github.com/apache/tomee/commit/7ce1f8033e239331cfa7843e4e5565ed0aa83345 On Tue, Nov 20, 2018 at 2:44 PM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Hey Jon, > > I clicked on the link and the diff tab does

Re: MicroProfile JWT 1.1

2018-11-20 Thread Jean-Louis Monteiro
Hey Jon, I clicked on the link and the diff tab does not show any difference. Did you push? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Nov 19, 2018 at 12:36 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I now have the principal

Re: Github not syncing?

2018-11-20 Thread Jonathan Gallimore
I wish I could claim credit for it, but that should go to the unsung heroes of the ASF Infra team :) On Tue, Nov 20, 2018 at 1:25 PM Richard Monson-Haefel < monsonhae...@gmail.com> wrote: > Nice work, Jonathan! > > On Mon, Nov 19, 2018 at 5:28 PM Jonathan Gallimore < >

Re: Github not syncing?

2018-11-20 Thread Daniel Cunha
Nice! +1 Em ter, 20 de nov de 2018 10:25 AM, Richard Monson-Haefel < monsonhae...@gmail.com escreveu: > Nice work, Jonathan! > > On Mon, Nov 19, 2018 at 5:28 PM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > I've filed a ticket with ASF infra to take a look: > >

Re: Microprofile Metrics Example

2018-11-20 Thread Richard Monson-Haefel
Hi David, This was really informative and useful. Thank you! Richard On Mon, Nov 19, 2018 at 6:43 PM David Blevins wrote: > Agree with the README comments. Another great reference is the Simple > WebService example which has payloads. > > - >

Re: Github not syncing?

2018-11-20 Thread Richard Monson-Haefel
Nice work, Jonathan! On Mon, Nov 19, 2018 at 5:28 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I've filed a ticket with ASF infra to take a look: > https://issues.apache.org/jira/browse/INFRA-17276 > > Cheers > > Jon > > On Mon, Nov 19, 2018 at 11:15 PM Roberto Cortez > >

Re: Is there someone looking for Microprofile Reactive at TomEE?

2018-11-20 Thread Romain Manni-Bucau
Hi Otavio, none yet and the existing ones are either bloated or don't integrate well in any existing stack :( FYI the reason it is not @geronimo: https://github.com/eclipse/microprofile/issues/57 Romain Manni-Bucau @rmannibucau | Blog

Re: Is there someone looking for Microprofile Reactive at TomEE?

2018-11-20 Thread Bruno Baptista
Hi Otávio! Not on TomEE, have you looked in the Geronimo Side? +1 to work on reactive streams. If you want help, I can join. Cheers Bruno Baptista http://twitter.com/brunobat_ On 20/11/18 12:07, Otávio Gonçalves de Santana wrote: Hello everyone, at the Eclipse Microprofile world there are

Re: Uses Boolean.valueof instaed of new instance

2018-11-20 Thread Bruno Baptista
Hi Otávio, I think that makes sense, It looks like It's the only place in the code where we have that. Cheers Bruno Baptista http://twitter.com/brunobat_ On 20/11/18 12:03, Otávio Gonçalves de Santana wrote: While I was studying the code, I found at SingletonEjbObjectHandler.java that

Is there someone looking for Microprofile Reactive at TomEE?

2018-11-20 Thread Otávio Gonçalves de Santana
Hello everyone, at the Eclipse Microprofile world there are a lot of implementations that TomEE covers, but, I did not find the implementation to microprofile-reactive-streams . Does someone know if this Job has started at the TomEE side?

Uses Boolean.valueof instaed of new instance

2018-11-20 Thread Otávio Gonçalves de Santana
While I was studying the code, I found at SingletonEjbObjectHandler.java that they are creating a new Boolean instance instead of using the Boolean.valueOf. method. The boolean wrapper has a singleton instance to both true and false. However, it will use when the code uses the Boolean.valueOf

[GitHub] tomee pull request #206: Uses Boolean.valueof instaed of new instance

2018-11-20 Thread otaviojava
GitHub user otaviojava opened a pull request: https://github.com/apache/tomee/pull/206 Uses Boolean.valueof instaed of new instance While I was studying the code, I found at SingletonEjbObjectHandler.java that they are creating a new Boolean instance instead of using the

Re: TomEE8 RC2: MP Metrics @Counted throws 500

2018-11-20 Thread Ivan Junckes Filho
Hey Cesar, I was able to make it work with my example. Take a look there I found a bug with geronimo-metrics-1.0.0 throwing a null pointer when the app metric is not found instead of returning a blank page. I am not sure if it happens in master. I will be looking into it. On Mon, Nov 19, 2018 at

Re: Writing presentable examples

2018-11-20 Thread Ivan Junckes Filho
There are good tips there. I liked the one about operators (eye focus). That is very useful. On Tue, Nov 20, 2018 at 7:29 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Thanks David. Fixed few typos in it. > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro >

Re: Microprofile Metrics Example

2018-11-20 Thread Ivan Junckes Filho
@Cesar / @Romain I will take a look. If there is a bug I will provide the fix. On Tue, Nov 20, 2018 at 3:52 AM Romain Manni-Bucau wrote: > Hi César, > > Did you test passing accept header or just in the browser which sends json > and text as acceptable value so resolution can be not that

Re: Microprofile Metrics Example

2018-11-20 Thread Ivan Junckes Filho
Thanks David, these are really great tips and I will follow them. On Mon, Nov 19, 2018 at 10:43 PM David Blevins wrote: > Agree with the README comments. Another great reference is the Simple > WebService example which has payloads. > > - >

Re: Override bean from library on TomEE

2018-11-20 Thread Bruno Baptista
Thanks for the help Romain Bruno Baptista http://twitter.com/brunobat_ On 19/11/18 17:39, Romain Manni-Bucau wrote: Le lun. 19 nov. 2018 17:58, Bruno Baptista a écrit : Thanks Romain, It's good to know. Where is that configuration?

Re: Github not syncing?

2018-11-20 Thread Jean-Louis Monteiro
The issue has been fixed. All seems to be working now -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Tue, Nov 20, 2018 at 12:28 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I've filed a ticket with ASF infra to take a look: >

Re: Github not syncing?

2018-11-20 Thread Jonathan Gallimore
This should be working now. Thanks for reporting it. Jon On Mon, Nov 19, 2018 at 11:27 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I've filed a ticket with ASF infra to take a look: > https://issues.apache.org/jira/browse/INFRA-17276 > > Cheers > > Jon > > On Mon, Nov 19,

Re: Writing presentable examples

2018-11-20 Thread Jean-Louis Monteiro
Thanks David. Fixed few typos in it. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Tue, Nov 20, 2018 at 1:51 AM David Blevins wrote: > I gave this doc a quick review and it looks good. It doesn't have the > directory layout or SEO information in there,