Re: How can I help?

Hi José, We just got Jon answering a similar question yesterday so I'm going to copy/paste his answer as it totally applies to your query. Welcome to the community! We have a few things going on with TomEE at the > moment including: > > * Java EE 8 support > * Java 11 support > * Microprofile exa

[GitHub] tomee pull request #216: WIP create a sample for java modules usage

GitHub user jeanouii opened a pull request: https://github.com/apache/tomee/pull/216 WIP create a sample for java modules usage This is work in progress. The goal is to create an example to leverage Java Modules. The immediate goal I was looking for is to properly make tomee/mas

Re: Please review PR #201

Thanks! Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't be using snapshots. Cheers Bruno Baptista https://twitter.com/brunobat_ On 22/11/18 19:30, Roberto Cortez wrote: Cool! Thank you. I’ll have a look. On 22 Nov 2018, at 19:08, Bruno Baptista wrote: Hi! I think

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

OK, Ticket created. I would like to create a patch, too. But I`m new with that in open source projects. So I have some questions on it. Is there a process to claim a Ticket to avoid multiple people working redundantly on it? Where can I find information how to use JIRA in TomEE project? -- Sen

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

Hey, You need to register in Apache Jira (https://issues.apache.org/jira/), find the TomEE project and claim the jira for you. Additionally, send an email to this list before you start the work and explaining what you want to do. That way there will be no collisions and if someone wants to h

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

Sorry, I missed this email. I've assigned the ticket to me, but its all yours. To actually have an issue assigned to you, I believe you need to be in the openejb-developers group, and for that. I don't have the permissions to add you (someone else might). Ignore my comment on the ticket, its all yo

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

Thank you, Jon. What is the best way to claim a ticket then? Obviously we already had the case that more than one wanted to do that ... ;-) -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

You did the right thing already - post here. :-) It was me that messed up, I apologize. A few folks are out for thanksgiving, but we'll figure out what's needed to get you in the right group in JIRA so you can assign tickets to yourself. Jon On Fri, Nov 23, 2018 at 10:39 AM Frankie wrote: > Tha

Re: How can I help?

Welcome, Weverthon! I'm glad that Jonathan was able to help you and welcome you! I'm looking forward to learning more about you. Richard On Thu, Nov 22, 2018 at 2:26 PM Weverthon Medeiros wrote: > Hello guys, > I saw Richard Monson-Haefel's post on the blog, and also, talked to Daniel > Cunha

[GitHub] tomee issue #215: WIP mp-metrics-metered

Github user ivanjunckes commented on the issue: https://github.com/apache/tomee/pull/215 Hi @ferdisn, yes I spot this issue while doing my example. I started a thread about it on the mailing list: Look for "Metrics Gauge Example and Bug". Send your PR there and ask qu

Re: How can I help?

Welcome, José! I'm so glad you've decided to get involved! If you need any more help, and I'm sure you will because everyone doest at first, please let us know. Everyone here wants to see you succeed! Richard On Thu, Nov 22, 2018 at 3:31 PM Jose Henrique Ventura wrote: > Hi Guys, > > Today I

Re: Metrics Gauge Example and Bug

I was using the current master. 1.1.9 I will try to use the version Romain proposed and see how it works. On Thu, Nov 22, 2018 at 7:36 PM Roberto Cortez wrote: > Hey, > > I think metrics doesn’t even run properly on TomEE 7.x because of CDI 2.0. > > Regarding the fail, I’m not sure what is wr

Re: How can I help?

Hey Weverthon, Jonathan gave you an awesome feedback, you can ping us on the list when you need help. We will be happy to help you on this journey! I'm really happy to see you here! Em sex, 23 de nov de 2018 às 08:52, Richard Monson-Haefel < monsonhae...@gmail.com> escreveu: > Welcome, Weverth

[GitHub] tomee issue #201: TOMEE-2278 - Use Managed Executor with Safeguard Fault Tol...

Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/201 +1 ---

Re: Please review PR #201

Hey Bruno, awesome! It really sounds good! I just push my +1 :) Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista escreveu: > Thanks! > > Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't be > using snapshots. > > Cheers > > Bruno Baptista > https://twitter.com/brunobat_ > >

Re: Please review PR #201

Didnt you want to make the pool configurable and not instantiated if not used? Le ven. 23 nov. 2018 13:20, Daniel Cunha a écrit : > Hey Bruno, > > awesome! It really sounds good! I just push my +1 :) > > Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista > escreveu: > > > Thanks! > > > > Additi

Re: Please review PR #201

Hi Romain, In the end I decided to simply use the server default, for now. It will only be used if annotations are called in the code. It's lazily loaded, so no worries on that regard. Cheers. Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 12:31, Romain Manni-Bucau wrote: Didnt

Re: Please review PR #201

If we are happy, I would like to merge it. I could use some of the common project setup for other work. > On 23 Nov 2018, at 14:01, Bruno Baptista wrote: > > Hi Romain, > > In the end I decided to simply use the server default, for now. > > It will only be used if annotations are called in th

Re: Metrics Gauge Example and Bug

No point. I’ve found the issue: It’s here: https://github.com/tomitribe/tomee/commit/7f18f4bcfe64119b9001d5ac6bffeb7324987a37 This commit reverted back the new JsonbProvider to the old JohnzonProvider. The fix

Re: Please review PR #201

So... Jon suggested to me that the configurable resource can be done in an additional PR by one of the new guys. I think it's an excellent ideal. If no one disagrees, I'll create a Jira with the details for it. Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 14:05, Roberto Cortez wro

Re: Please review PR #201

Maybe add those config options in a second PR? What do you think? Jon On Fri, Nov 23, 2018 at 2:01 PM Bruno Baptista wrote: > Hi Romain, > > In the end I decided to simply use the server default, for now. > > It will only be used if annotations are called in the code. It's lazily > loaded, so n

Re: Please review PR #201

I’m ok with that. > On 23 Nov 2018, at 14:15, Bruno Baptista wrote: > > So... Jon suggested to me that the configurable resource can be done in an > additional PR by one of the new guys. I think it's an excellent ideal. > > If no one disagrees, I'll create a Jira with the details for it. > >

Re: Please review PR #201

> It's lazily loaded, so no worries on that regard. What is "it" here? :) Conretely the bean instantiation yes cause it is normal scoped and the resource too cause it is by default lazy in tomee (service-jar.xml) but it is worth a test that prevent regression on that behavior IMHO, I didn't catch

Re: Metrics Gauge Example and Bug

Yes, that was the issue. This should fix it: https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad4458f67aabcab5eff829 Try to pull the code and test it again. Cheers, Roberto > On 23 Nov 2018, at 14:14, Robe

Re: Please review PR #201

Hi Romain, Thanks for your comment. The class doing the resource injection is lazy loaded, specifically /FailsafeContainerExecutionManagerProvider/. I did verify it in development but no test was produced... And to say the truth I wouldn't know how to validate if a bean has already been loade

Re: Please review PR #201

Le ven. 23 nov. 2018 à 15:49, Bruno Baptista a écrit : > Hi Romain, > > Thanks for your comment. > > The class doing the resource injection is lazy loaded, specifically > /FailsafeContainerExecutionManagerProvider/. I did verify it in > development but no test was produced... And to say the truth

Re: Please review PR #201

Hi Romain, About "The point is not the cdi bean but the executor. So high level you deploy an app not using safeguard but it being present and you ensure the container has no executor resource instantiated (you will get one (the facade))." Sorry Romain, I still don't understand how the code in

Re: How can I help?

Hi Guys, Many thanks for the Welcome Jean and thanks for sharing your thoughts with the community, Richard. Either Java EE 8 support and Microprofile examples sound good to me but I would say the examples could be a good start to get involved how you guys work and step by step we can go pointi

Re: Please review PR #201

Le ven. 23 nov. 2018 à 16:34, Bruno Baptista a écrit : > Hi Romain, > > About "The point is not the cdi bean but the executor. So high level you > deploy an > app not using safeguard but it being present and you ensure the container > has no executor resource instantiated (you will get one (the f

How Can I Help?

Hello: My name is Michael Redlich and I was just confirmed to the TomEE Developers mailing list. Here's some background information about myself: - I live in Flemington , New Jersey with my lovely wife, Rowena. We love to visit New Orleans, LA and Newpo

[GitHub] tomee issue #215: WIP mp-metrics-metered

Github user ivanjunckes commented on the issue: https://github.com/apache/tomee/pull/215 @ferdisn good news. @radcortez has fixed the issue. There was a regression with the jsonb provider that caused the issue. https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad445

Re: Metrics Gauge Example and Bug

It worked, thanks man! On Fri, Nov 23, 2018 at 12:40 PM Roberto Cortez wrote: > Yes, that was the issue. This should fix it: > > https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad4458f67aabcab5eff829 > > Try to pull the code and test it again. > > Cheers, > Roberto > > On 23 Nov 2018, a

Re: Metrics Gauge Example and Bug

We should probably add a test for that regression. Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 15:50, Ivan Junckes Filho wrote: It worked, thanks man! On Fri, Nov 23, 2018 at 12:40 PM Roberto Cortez wrote: Yes, that was the issue. This should fix it: https://github.com/apache

Re: Metrics Gauge Example and Bug

https://github.com/apache/tomee/blob/4c7fd4af95983a92bef89dc598873310dd13dd2e/server/openejb-cxf-rs/src/test/java/org/apache/openejb/server/cxf/rs/johnzon/JsonbJaxrsProviderTest.java was supposed to cover that Romain Manni-Bucau @rmannibucau | Blog

[GitHub] tomee pull request #217: TOMEE-2288 Update commons-lang3 to current Version ...

GitHub user kaminfeuer opened a pull request: https://github.com/apache/tomee/pull/217 TOMEE-2288 Update commons-lang3 to current Version 3.8.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kaminfeuer/tomee master Alternativel

[GitHub] tomee pull request #217: TOMEE-2288 Update commons-lang3 to current Version ...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/217 ---

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

I saw your PR come in. Thanks for that - I've merged it! Jon On Fri, Nov 23, 2018 at 10:41 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > You did the right thing already - post here. :-) It was me that messed up, > I apologize. A few folks are out for thanksgiving, but we'll figu

Re: How Can I Help?

Hi Michael, great to have you here! I would suggest that you start doing some MicroProfile examples. What about taking this task? https://issues.apache.org/jira/browse/TOMEE-2287 We have very similar examples that will help you with that, it is documented in the ticket. Let us know if you have

Please review PR# 217

Could someone please review this PR? It is my first contribution to an open source project ever, so please be graceful (and give hints) if I missed something ... ;-) This trivial dependency update was the perfect issue for that, so I could focus on the tools and processes. Thank you. -- Sent f

Re: Metrics Gauge Example and Bug

And it did cover. The test was failing. > On 23 Nov 2018, at 16:00, Romain Manni-Bucau wrote: > > https://github.com/apache/tomee/blob/4c7fd4af95983a92bef89dc598873310dd13dd2e/server/openejb-cxf-rs/src/test/java/org/apache/openejb/server/cxf/rs/johnzon/JsonbJaxrsProviderTest.java > was supposed

Re: Please review PR# 217

BTW: why is the automatic generated message from the PR noted "by cesarhernandezgt"? -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Please review PR# 217

Thanks Frankie! I'll have a look. Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 16:12, Frankie wrote: Could someone please review this PR? It is my first contribution to an open source project ever, so please be graceful (and give hints) if I missed something ... ;-) This trivial

Re: Please review PR# 217

I already merged it - it looked good to me. Thanks for the PR, and congrats on your first Open Source contribution! Jon On Fri, 23 Nov 2018, 16:12 Frankie Could someone please review this PR? > > It is my first contribution to an open source project ever, so please be > graceful (and give hints)

Re: How Can I Help?

Hi Ivan: Sure thing! I will get started on that later today! Mike. On Fri, Nov 23, 2018 at 11:11 AM Ivan Junckes Filho wrote: > Hi Michael, great to have you here! > > I would suggest that you start doing some MicroProfile examples. > > What about taking this task? > https://issues.apache.org

Re: Please review PR# 217

ok Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 16:32, Jonathan Gallimore wrote: I already merged it - it looked good to me. Thanks for the PR, and congrats on your first Open Source contribution! Jon On Fri, 23 Nov 2018, 16:12 Frankie Could someone please review this PR? It is

Re: How Can I Help?

Welcome, Mike!! On Fri, Nov 23, 2018 at 9:45 AM Michael Redlich wrote: > Hello: > > My name is Michael Redlich and I was just confirmed to the TomEE Developers > mailing list. > > Here's some background information about myself: > >- I live in Flemington ,

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timed example

GitHub user ivanjunckes opened a pull request: https://github.com/apache/tomee/pull/218 TOMEE-2290 - Metrics timed example You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivanjunckes/tomee metrics-timed-example Alternatively you

Re: Metrics Gauge Example and Bug

Hey guys can anyone review and merge this? https://github.com/apache/tomee/pull/218 On Fri, Nov 23, 2018 at 2:22 PM Roberto Cortez wrote: > And it did cover. The test was failing. > > > On 23 Nov 2018, at 16:00, Romain Manni-Bucau > wrote: > > > > > https://github.com/apache/tomee/blob/4c7fd4

Write tests geronimo

Hello guys, I did a change on Geronimo Metrics. https://github.com/apache/geronimo-metrics/pull/2 geronimo-metrics, as you are aware, is a library used in TomEE. I am wondering how can I write a test for my change. Writing a test in TomEE for this is very simple, but writing a test in geronimo I

Re: MicroProfile rest client example

Thanks for the reply, Build it locally didn't solve the issue. I did this: a) Build entire TomEE using: mvn -Pquick -Dsurefire.useFile=false -DdisableXmlReport=true -DuniqueVersion=false -ff -Dassemble -DskipTests -DfailIfNoTests=false clean install b) Updated arquillian-tomee-remote version to

Re: Write tests geronimo

Hi Ivan TCK are in geronimo and they use arquillian, tomee just reapplies them to check the packaging does not break anything and its classloading is fine as well so you can write tests the same. Le ven. 23 nov. 2018 19:51, Ivan Junckes Filho a écrit : > Hello guys, I did a change on Geronim

Re: How Can I Help?

Thanks, Richard! On Fri, Nov 23, 2018 at 11:50 AM Richard Monson-Haefel < monsonhae...@gmail.com> wrote: > Welcome, Mike!! > > On Fri, Nov 23, 2018 at 9:45 AM Michael Redlich wrote: > >> Hello: >> >> My name is Michael Redlich and I was just confirmed to the TomEE >> Developers >> mailing list.

Re: MicroProfile rest client example

Hi everybody, I did a git bisect and this is the final output: a5513230e8f77a4985916f901c3eda2c5c45c6d2 is the first bad commit commit a5513230e8f77a4985916f901c3eda2c5c45c6d2 Author: Dennis Kieselhorst Date: Tue Oct 30 15:30:06 2018 +0100 Update CXF to latest release :100644 100644 42b6

Re: MicroProfile rest client example

> On Nov 23, 2018, at 3:52 PM, César Hernández Mendoza > wrote: > > Hi everybody, > > I did a git bisect and this is the final output: > > a5513230e8f77a4985916f901c3eda2c5c45c6d2 is the first bad commit > commit a5513230e8f77a4985916f901c3eda2c5c45c6d2 > Author: Dennis Kieselhorst > Date: