[GitHub] tomee pull request #265: assigning article indexes

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/265 ---

Re: Documentation Contribution Opportunities

> On Dec 9, 2018, at 5:09 PM, David Blevins wrote: > >> On Dec 9, 2018, at 3:57 PM, Daniel Dias Dos Santos >> wrote: >> >> cool . >> >> then the code for JavaDocs.java would look like this: >> >>

Re: Documentation Contribution Opportunities

> On Dec 9, 2018, at 3:57 PM, Daniel Dias Dos Santos > wrote: > > cool . > > then the code for JavaDocs.java would look like this: > > https://github.com/apache/tomee-site-generator/blob/a96d23581868abff30270115b113df7292872e8b/src/main/java/org/apache/tomee/website/Examples.java > > assign

Re: MicroProfile Samples

Hi Ivan, Welcome back :) Someone else already grabbed https://jira.apache.org/jira/browse/TOMEE-2335 , which is to show how to implement a custom health check. Please feel free to go wild and come up with some other example scenarios for MP

Re: MicroProfile Samples

Hey Roberto, it sounds interesting! My username on Jira is "luksrn" Em dom, 9 de dez de 2018 às 21:30, Roberto Cortez escreveu: > Hi Lucas, > > Wonderful. I have one for you: > > https://jira.apache.org/jira/browse/TOMEE-2351 < > https://jira.apache.org/jira/browse/TOMEE-2351> - MicroProfile >

Re: Stabilize TomEE Build

Agree on both. > On 9 Dec 2018, at 07:52, Jean-Louis Monteiro wrote: > > I only fixed the 2 imports for checkstyle > > I don't think from an end user perspective the information is very > important in the changelog so did not created any ticket. > > If everyone thinks this is important for

Re: Documentation Contribution Opportunities

The simplest task is to complete the Javadocs class I stubbed out: - https://github.com/apache/tomee-site-generator/blob/a96d23581868abff30270115b113df7292872e8b/src/main/java/org/apache/tomee/website/Javadocs.java https://issues.apache.org/jira/browse/TOMEE-2342 Publish Javadocs Give it a

Re: Documentation Contribution Opportunities

now I'm lost in what I have to do David. : ) -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em dom, 9 de dez de 2018 às 20:28, David Blevins

Re: Tomee Site Generator and Readme files

Hi José, great. thanks. : ) -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em dom, 9 de dez de 2018 às 16:59, Jose Henrique Ventura escreveu: > Hi

Re: Documentation Contribution Opportunities

> On Dec 9, 2018, at 2:10 PM, Daniel Dias Dos Santos > wrote: > > basically I would have to move the comments of: > > - > https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/resources/META-INF/org.apache.openejb/service-jar.xml#L150 > > and add the same ones here : >

Re: Documentation Contribution Opportunities

HI David, basically I would have to move the comments of: https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/resources/META-INF/org.apache.openejb/service-jar.xml#L150 and add the same ones here :

Re: Documentation Contribution Opportunities

> On Dec 9, 2018, at 9:48 AM, David Blevins wrote: > >> - Write Javadocs in Asciidoc I created a "Wish" JIRA for this one and detailed some steps: - https://issues.apache.org/jira/browse/TOMEE-2347 That would be for the main build. Here's a separate JIRA for doing that in the Javadoc

[GitHub] tomee issue #263: Add Metrics Histogram example in foler examples/mp-metrics...

Github user josehenriqueventura commented on the issue: https://github.com/apache/tomee/pull/263 Also when compiling the parent project "example/pom.xml" your mp-metrics-histogram project won't be compiled because is missing an entry of mp-metrics-histogram there. I suggest you

[GitHub] tomee issue #263: Add Metrics Histogram example in foler examples/mp-metrics...

Github user josehenriqueventura commented on the issue: https://github.com/apache/tomee/pull/263 Taking the opportunity to help to review PR as David mentioned earlier, I would like to suggest some improvements. ---

Re: Tomee Site Generator and Readme files

Hi Daniel, Yes, as a second option would be better to convert the files to asciidoc. https://github.com/github/markup/blob/master/README.md Best Regards, José Henrique Ventura. ‐‐‐ Original Message ‐‐‐ On Sunday, December 9, 2018 5:27 PM, Daniel Dias Dos Santos wrote: > Hi , > >

Re: Documentation Contribution Opportunities

> On Dec 8, 2018, at 9:06 PM, Daniel Dias Dos Santos > wrote: > > Hi David, > > Please explain these two issues to me : > > - Publish Javadocs The funny thing is I read too quickly and read "please assign these two issues to me", either way the outcome ended up being the same :) I stubbed

Re: Tomee Site Generator and Readme files

Hi , I agree . So is best convert to asciidoc the existence and the new add in format asciidoc . -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em

Re: Tomee Site Generator and Readme files

Great topic. I actually hadn't noticed till you pointed it out! > On Dec 9, 2018, at 8:48 AM, Jose Henrique Ventura > wrote: > > Hi Folks, > > I see some README.md files have been modified with asciidoctor metadata for > when JBake bake the files, the files will have its metadata ported but

Tomee Site Generator and Readme files

Hi Folks, I see some README.md files have been modified with asciidoctor metadata for when JBake bake the files, the files will have its metadata ported but on the other hand, Github does not render the those correctly because of this "~~" added to separate metadata and the content of the

Re: TOMEE-2336

You just need to ask, but as Jon already assigned the ticket to you, you are already in the contributors group :) Thanks for the help -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Sun, Dec 9, 2018 at 11:22 AM Michael Redlich wrote: > Hi Jean-Louis: > >

[GitHub] tomee pull request #265: assigning article indexes

GitHub user chongma opened a pull request: https://github.com/apache/tomee/pull/265 assigning article indexes EJB Datasource Spring You can merge this pull request into a Git repository by running: $ git pull https://github.com/chongma/tomee master Alternatively you can

Re: TOMEE-2336

Hi Jean-Louis: Thanks for the information about that. How may I be added to the contributors group? Mike. On Sun, Dec 9, 2018 at 2:49 AM Jean-Louis Monteiro wrote: > For information. You need to first be added to the contributors group and > then the ticket can be assigned to you. > > This

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r240029496 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java --- @@ -20,18 +20,25 @@ import

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on the issue: https://github.com/apache/tomee/pull/262 Reverted back to Random ---

Re: MicroProfile Samples

Hi everyone! First, let me introduce myself, as I haven't posted here for quite a long time. My name is Ivan and I am from the Bulgarian JUG. I am also the co-author of the MicroProfile Hands-on-lab ( https://github.com/bgjug/microprofile-hol-1x). Roberto, I can take the remaining sample on MP