Re: MicroProfile rest client example

Hi, Since now the current master is using mp rest client 1.1, https://issues.apache.org/jira/browse/TOMEE-2298 is no longer blocking TOMEE-2297. I updated and fixed the PR, now is ready for review: https://github.com/apache/tomee/pull/210 Ticket: https://issues.apache.org/jira/browse/TOMEE-2297

[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project

Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/210 Since now the current master is using mp rest client 1.1, https://issues.apache.org/jira/browse/TOMEE-2298 is no longer blocking this PR. This PR is ready for review. ---

[GitHub] tomee pull request #278: TOMEE-2368-example-mvc-resteasy

GitHub user Daniel-Dos opened a pull request: https://github.com/apache/tomee/pull/278 TOMEE-2368-example-mvc-resteasy https://issues.apache.org/jira/browse/TOMEE-2368 I made a simple hello world example with MVC 1.0 using RestEasy module . You can merge this pull request i

Re: Strange error starting Arquillian Test

Hi Alex, I'm having this same stranger error, when you said "remove everything in root directory" what exactly do you mean? Deleted everything in git/tomee/ ? the root directory of the test you were executing? somewhere /tmp/... ? > Yes I had write permission what I did is just debug tomee

Re: Java EE Security API for EE 8

Hi folks, I’ve now created a PR to push the work: https://github.com/apache/tomee/pull/277 It is still in the early stages. I’ve just spent a good amount of time trying to understand the spec. The ideia here is that with a ServerAuthModule we could ve

[GitHub] tomee pull request #277: WIP - TOMEE-2365 - EE Security API Implementation -...

GitHub user radcortez opened a pull request: https://github.com/apache/tomee/pull/277 WIP - TOMEE-2365 - EE Security API Implementation - JSR-375 You can merge this pull request into a Git repository by running: $ git pull https://github.com/radcortez/tomee TOMEE-2365 Alterna

[GitHub] tomee pull request #263: Add Metrics Histogram example in folder examples/mp...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/263 ---

Re: MPJWT @RolesAllowed is been applied with a all or nothing policy - TOMEE-2357

Got it, thank you, Roberto, for the detail explanation. Yes, +1 for number 2. El vie., 14 dic. 2018 a las 10:57, Roberto Cortez () escribió: > Hi César, > > We can. Let me try to give more detail: > > The modules inside tck/microprofile-tck (config, fault-tolerance, health, > jwt, metrics, open

Re: MPJWT @RolesAllowed is been applied with a all or nothing policy - TOMEE-2357

Hi César, We can. Let me try to give more detail: The modules inside tck/microprofile-tck (config, fault-tolerance, health, jwt, metrics, openapi, opentracing and rest-client), they set up an arquillian configuration to run TomEE Remote and include the TCK jar provided by each of the microprof

Re: Tests AutoConnectionTrackerTest stability

> @Jon: instead of the logs, could we instead rely on latches? > I was thinking about wrapping up the Tracker (delegate pattern) and use a > latch so the test could actually way and avoid some timing issues. That sounds like a great approach. That test and associated fix came from some pretty inte

Re: MPJWT @RolesAllowed is been applied with a all or nothing policy - TOMEE-2357

Let me see if I understood correctly, * We shouldn't add this test in the current `/tck/microprofile-tck/jwt` because this are the test provided by Eclipse MP JWT to validate that an implementor ( in this case TomEE) follow the spec and adding here a test that spinn up a TomEE remote doesn't make s

Tests AutoConnectionTrackerTest stability

Starting a new thread so hopefully it makes it easier to track and follow. So looks like on Buildbot AutoConnectionTrackerTest is failing randomly [ERROR] Failures: [ERROR] AutoConnectionTrackerTest.test:198 expected:<1> but was:<0> Thanks Roberto for reporting. I also ran this test many times

[GitHub] tomee pull request #273: Added index information to mp examples readme files...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/273 ---

[GitHub] tomee pull request #275: TOMEE-2357 - Fixed issue and updated test on exampl...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/275 ---

[GitHub] tomee issue #275: TOMEE-2357 - Fixed issue and updated test on example appli...

Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/275 Thanks @pzygielo for the review. All fixed. I tested locally and looks good. I'll merge and monitor the build to see if it's ok. ---

[GitHub] tomee pull request #275: TOMEE-2357 - Fixed issue and updated test on exampl...

Github user cesarhernandezgt commented on a diff in the pull request: https://github.com/apache/tomee/pull/275#discussion_r241796269 --- Diff: mp-jwt/src/main/java/org/apache/tomee/microprofile/jwt/jaxrs/MPJWTSecurityAnnotationsInterceptor.java --- @@ -39,14 +39,19 @@ public void

Re: Stabilize TomEE Build

Please wait a minute lol I'd rather have you help me if needed. First I don't have the feeling I spent time for nothing on it and second, at least I will learn something. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Dec 14, 2018 at 4:33 PM Jonathan G

Re: Stabilize TomEE Build

I added this test, and it was pretty stable. Happy to help look into it. On Fri, Dec 14, 2018 at 10:44 AM Roberto Cortez wrote: > It seems the build just randomly fails with this test: > AutoConnectionTrackerTest.test > > [ERROR] Failures: > [ERROR] AutoConnectionTrackerTest.test:198 expected:

Re: MPJWT @RolesAllowed is been applied with a all or nothing policy - TOMEE-2357

Well, not sure if I explained myself correctly. The other tests are just with the TCK’s because there are no implementations in TomEE. Well we could have go to the Geronimo projects and add the tests there, but we are also testing parts of the TomEE integration, so they need to live somewhere.

Re: Stabilize TomEE Build

Working on Cesar's PR. I'll have a look after. Le ven. 14 déc. 2018 à 11:44, Roberto Cortez a écrit : > It seems the build just randomly fails with this test: > AutoConnectionTrackerTest.test > > [ERROR] Failures: > [ERROR] AutoConnectionTrackerTest.test:198 expected:<1> but was:<0> > > Someti

Re: Stabilize TomEE Build

It seems the build just randomly fails with this test: AutoConnectionTrackerTest.test [ERROR] Failures: [ERROR] AutoConnectionTrackerTest.test:198 expected:<1> but was:<0> Sometimes it passes, sometimes it fails. I suspect it may be related with some timing issues / box speed of the build bot

Re: MPJWT @RolesAllowed is been applied with a all or nothing policy - TOMEE-2357

As I said, along side with the implementation. But that was a gut feeling. If others are in TCK, I'd rather vote for consistency so it's easier for us, new contributors to know where to look at -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Dec 14, 2018

Re: MPJWT @RolesAllowed is been applied with a all or nothing policy - TOMEE-2357

Well, because we don’t have any other implementations in TomEE other than JWT, in a couple of cases we did implement some additional tests, and they were done on the TCK modules (for instance Configuration). Where do you suggest to add these? > On 14 Dec 2018, at 10:35, Jean-Louis Monteiro >

Re: MPJWT @RolesAllowed is been applied with a all or nothing policy - TOMEE-2357

Hummm That is not what I would be expecting actually. I was expecting the TCK modules to be just wiring to run external TCK tests. And actual implementation tests to be along side the implementation. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Dec 1

Re: MPJWT @RolesAllowed is been applied with a all or nothing policy - TOMEE-2357

Tests can also be added in the TCK module. I think they should be added there actually, since all the other additional tests for the other MP implementations are added in their own TCK modules. > On 14 Dec 2018, at 06:34, Jean-Louis Monteiro > wrote: > > Hey Cesar, > > Thanks, I'll review an

[GitHub] tomee pull request #276: TOMEE-2363 Introduces OWASP dependency check via pr...

GitHub user rzo1 opened a pull request: https://github.com/apache/tomee/pull/276 TOMEE-2363 Introduces OWASP dependency check via profile This PR introduces the [OWASP Dependency Check Maven Plugin](https://jeremylong.github.io/DependencyCheck/index.html) in a basic configuration a

[GitHub] tomee pull request #275: TOMEE-2357 - Fixed issue and updated test on exampl...

Github user pzygielo commented on a diff in the pull request: https://github.com/apache/tomee/pull/275#discussion_r241679807 --- Diff: mp-jwt/src/main/java/org/apache/tomee/microprofile/jwt/jaxrs/MPJWTSecurityAnnotationsInterceptor.java --- @@ -39,14 +39,19 @@ public void filter(f