Re: Adding Java EE Security 1.0 Spec to geronimo-specs

2019-01-11 Thread Romain Manni-Bucau
If Roberto agrees +1 Le ven. 11 janv. 2019 20:29, Gurkan Erdogdu a écrit : > Hi folks > Regarding TomEE, we need to add Java EE Security, JSR-375 spec to > geronimo-specs and needs a release. I have committer access to > geronimo-specs and added to code (implemented by Roberto Cortez in >

Re: MP Metrics Counted / Docker

2019-01-11 Thread Carl Mosca
Glad to finally get started...looking forward to more. On Fri, Jan 11, 2019 at 2:40 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > No problem  thanks for your contribution. > > On Fri, 11 Jan 2019, 18:56 Carl Mosca > > Ah, sorry about that. Thank you for the fix. > > > > On

Re: Java EE Security API for EE 8

2019-01-11 Thread Gurkan Erdogdu
I have added geronimo-specs-security_1.0 to geronimo-specs and let geronimo-dev about the issue. After receiving some response, I can commit the code. On Fri, Jan 11, 2019 at 9:50 PM Gurkan Erdogdu wrote: > Ok then I created subtask, > https://issues.apache.org/jira/browse/TOMEE-2453 under the

Re: MP Metrics Counted / Docker

2019-01-11 Thread Jonathan Gallimore
No problem  thanks for your contribution. On Fri, 11 Jan 2019, 18:56 Carl Mosca Ah, sorry about that. Thank you for the fix. > > On Fri, Jan 11, 2019 at 8:34 AM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > This is done - any issues, please shout. > > > > Jon > > > > On

Adding Java EE Security 1.0 Spec to geronimo-specs

2019-01-11 Thread Gurkan Erdogdu
Hi folks Regarding TomEE, we need to add Java EE Security, JSR-375 spec to geronimo-specs and needs a release. I have committer access to geronimo-specs and added to code (implemented by Roberto Cortez in tomee-security) into my local. Can I commit to code to the geronimo-specs? Any objection?

Re: MP Metrics Counted / Docker

2019-01-11 Thread Carl Mosca
Ah, sorry about that. Thank you for the fix. On Fri, Jan 11, 2019 at 8:34 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > This is done - any issues, please shout. > > Jon > > On Fri, Jan 11, 2019 at 1:27 PM Ivan Junckes Filho > wrote: > > > +1 Jon > > > > On Fri, Jan 11, 2019 at

Re: Safegard compile issue

2019-01-11 Thread Jonathan Gallimore
I've sent the mail, so fingers crossed we'll get the snapshot soon. I think that is better than rolling back :) Jon On Fri, Jan 11, 2019 at 1:30 PM Bruno Baptista wrote: > Thanks Jon. > > I'll prepare a branch with the latest release, just in case. > > Bruno Baptista >

Re: Safegard compile issue

2019-01-11 Thread Bruno Baptista
Thanks Jon. I'll prepare a branch with the latest release, just in case. Bruno Baptista https://twitter.com/brunobat_ On 11/01/19 13:27, Jonathan Gallimore wrote: I'll ask nicely on the Geronimo list and see if someone can deploy the snapshot for us. Jon On Fri, Jan 11, 2019 at 1:26 PM

Re: Safegard compile issue

2019-01-11 Thread Jonathan Gallimore
I'll ask nicely on the Geronimo list and see if someone can deploy the snapshot for us. Jon On Fri, Jan 11, 2019 at 1:26 PM Bruno Baptista wrote: > yes, we are on the snapshot because it has unreleased bug fixes. > > Unfortunately it seems that the snapshot isn't available. We could use > the

Re: MP Metrics Counted / Docker

2019-01-11 Thread Ivan Junckes Filho
+1 Jon On Fri, Jan 11, 2019 at 11:23 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I'm on it. Thanks for the reply! > > Jon > > On Fri, Jan 11, 2019 at 1:22 PM Bruno Baptista wrote: > > > Hi Jon, > > > > Yes, please do add the profile. > > > > Thanks > > > > Bruno Baptista > >

Re: Safegard compile issue

2019-01-11 Thread Bruno Baptista
yes, we are on the snapshot because it has unreleased bug fixes. Unfortunately it seems that the snapshot isn't available. We could use the previous release. The TCK should pass with it. What do you think? Bruno Baptista https://twitter.com/brunobat_ On 11/01/19 13:06, Jonathan Gallimore

Safegard compile issue

2019-01-11 Thread Jonathan Gallimore
Hi We're seeing this error on the build ( https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/996/steps/compile/logs/stdio ): [ERROR] Failed to execute goal on project mp-common: Could not resolve dependencies for project org.apache.tomee:mp-common:jar:8.0.0-SNAPSHOT: Could not find

Re: MP Metrics Counted / Docker

2019-01-11 Thread Jonathan Gallimore
I'm on it. Thanks for the reply! Jon On Fri, Jan 11, 2019 at 1:22 PM Bruno Baptista wrote: > Hi Jon, > > Yes, please do add the profile. > > Thanks > > Bruno Baptista > https://twitter.com/brunobat_ > > > On 11/01/19 13:20, Jonathan Gallimore wrote: > > Hi > > > > I merged a PR (yesterday, I

Re: MP Metrics Counted / Docker

2019-01-11 Thread Bruno Baptista
Hi Jon, Yes, please do add the profile. Thanks Bruno Baptista https://twitter.com/brunobat_ On 11/01/19 13:20, Jonathan Gallimore wrote: Hi I merged a PR (yesterday, I think) that add docker to the MP Metrics Counted example. It looks like plugin runs as part of the build, and if docker

MP Metrics Counted / Docker

2019-01-11 Thread Jonathan Gallimore
Hi I merged a PR (yesterday, I think) that add docker to the MP Metrics Counted example. It looks like plugin runs as part of the build, and if docker isn't running and available, the build fails. Any objections if I tweak this so you have to specify the actual goal or use a profile to enable

Re: Java EE Security API for EE 8

2019-01-11 Thread Jean-Louis Monteiro
That’d be great. I have commit permissions so if you need help help or something. Lemme know. Le ven. 11 janv. 2019 à 07:12, Gurkan Erdogdu a écrit : > Hello Roberto > We probably need to move javax.security.enterprise.* package to geronimo > specs project

Re: Upgrade to Safeguard 1.2

2019-01-11 Thread Jean-Louis Monteiro
Ok i have reviewed it and it’s good to go. Lemme merge it for you. Le ven. 11 janv. 2019 à 09:07, Bruno Baptista a écrit : > The new test run was successful. > > It's ready for review. > > Bruno Baptista > https://twitter.com/brunobat_ > > > On 10/01/19 21:49, Bruno Baptista wrote: > > Thanks

Re: How to run test build on PR?

2019-01-11 Thread Jean-Louis Monteiro
Yes this is definitely the challenge. We might be able to setup something around buildbot and a system polling github for new PR. Ideal scenario would be to have a company to donate either a machine or build time on their CI system. Le jeu. 10 janv. 2019 à 16:39, César Hernández Mendoza a

Re: Upgrade to Safeguard 1.2

2019-01-11 Thread Bruno Baptista
The new test run was successful. It's ready for review. Bruno Baptista https://twitter.com/brunobat_ On 10/01/19 21:49, Bruno Baptista wrote: Thanks Jean-Louis. It's appreciated. :) The problem seems to be the testng version. Some TCK tests, on Config and JWT don't like the new v6.14.3.