Re: MicroProfile Integration in Plus and Plume

2019-02-09 Thread j4fm
Hey Roberto, I didn't get much time earlier but will later. The first thing I noticed is that the assert reports the expected http response and actual http response the wrong way round. Easy fix, I have ready to submit. But the important bit is that it expects 200 but gets 404... that's exactly th

Re: Examples Missing README Files

2019-02-09 Thread Bogdan Stirbat
Hi! For https://issues.apache.org/jira/browse/TOMEE-2372 I've added a new pull request: https://github.com/apache/tomee/pull/392 . Can I pick https://issues.apache.org/jira/browse/TOMEE-2393 ? Thanks, Bogdan În vin., 8 feb. 2019 la 19:55, Bruno Baptista a scris: > Hi Bogdan, > > I've reviewe

[GitHub] doychin opened a new pull request #393: Keep permissions in Set.

2019-02-09 Thread GitBox
doychin opened a new pull request #393: Keep permissions in Set. URL: https://github.com/apache/tomee/pull/393 - If it is list if same permission is added multiple times that list will grow. Signed-off-by: Doychin Bondzhev ---

[GitHub] BogdanStirbat opened a new pull request #392: Added README.adoc to cdi-realm - TOMEE-2372

2019-02-09 Thread GitBox
BogdanStirbat opened a new pull request #392: Added README.adoc to cdi-realm - TOMEE-2372 URL: https://github.com/apache/tomee/pull/392 Jira issue: https://issues.apache.org/jira/browse/TOMEE-2372. This is an automated messag

[GitHub] doychin commented on issue #360: Cleanup test code and also minor changes in the tested class.

2019-02-09 Thread GitBox
doychin commented on issue #360: Cleanup test code and also minor changes in the tested class. URL: https://github.com/apache/tomee/pull/360#issuecomment-462050946 I've implemented the idea to run setEnvironment in separate thread. Previous implementation had the problem that it will intro

[GitHub] doychin commented on issue #360: Cleanup test code and also minor changes in the tested class.

2019-02-09 Thread GitBox
doychin commented on issue #360: Cleanup test code and also minor changes in the tested class. URL: https://github.com/apache/tomee/pull/360#issuecomment-462050779 Sorry for the mess ;-( This is an automated message from the

Re: MicroProfile Integration in Plus and Plume

2019-02-09 Thread j4fm
The test passes without all-adapters specified. Fails with it. So will find out which adapter. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-02-09 Thread j4fm
No probs at all. Absolutely sure happy to look. Did open up the cdi-embdded exception yesterday but didn't get very far with the little time I had. Do you think the two are related? fyi, I changed the PR to 390 with its own tickets as I expect it helps more than just MP endpoints, so thought tha

Re: @OpenAPIDefinition not working

2019-02-09 Thread Roberto Cortez
Hi Ivan, Yes Romain is right, you should set openejb.cxf-rs.cache-application = false and it should work. We had to set that for the TCK to pass, but the config never reached the final distribution. I did notice that and I’ve added it in case a MP app is detected, but it was after M2 was releas

Re: MicroProfile Integration in Plus and Plume

2019-02-09 Thread Roberto Cortez
Hey, Sorry, I was a little bit off in the last few days. At the moment there are some other errors that we need to figure out the cause. For instance: [ERROR] Failures: [ERROR] JAXRSHttpHeadersTest.testRequestHeaderCaseInsensitive:373->JaxrsTest.assertStatusCode:82 expected:<404> but was:<