Re: How can I help?

2019-02-27 Thread Sherman Marshall
Thanks David, I'll definitely keep an eye out for fixes like that! I think I'll see if I can do some examples too, and check out the code coverage there next. I see examples for interceptors, but not filters... which seems odd. I know that capability is there in Tomcat, so it shouldn't be too dif

Re: How can I help?

2019-02-27 Thread David Blevins
> On Feb 27, 2019, at 5:14 PM, David Blevins wrote: > > I added you to the contributors group and assigned that JIRA to you. > > It's a broad sounding ticket, so I recommend picking a small spot of the code > and focusing on that in the first PR so people can get a taste of what you > have in

[GitHub] dblevins commented on issue #426: Simple code refactoring. Trying to gain familiarity with the project

2019-02-27 Thread GitBox
dblevins commented on issue #426: Simple code refactoring. Trying to gain familiarity with the project URL: https://github.com/apache/tomee/pull/426#issuecomment-468134848 Clean and simple! Merged! This is an automated messa

[GitHub] dblevins merged pull request #426: Simple code refactoring. Trying to gain familiarity with the project

2019-02-27 Thread GitBox
dblevins merged pull request #426: Simple code refactoring. Trying to gain familiarity with the project URL: https://github.com/apache/tomee/pull/426 This is an automated message from the Apache Git Service. To respond to th

Assignment of task: TOMEE-2480

2019-02-27 Thread Gabriel Ferreira
Hey guys, can someone assign this task for me? https://issues.apache.org/jira/browse/TOMEE-2480 thanks ;)

Re: How can I help?

2019-02-27 Thread Gabriel Ferreira
Welcome Sherman! :D Em qua, 27 de fev de 2019 às 22:24, David Blevins escreveu: > > On Feb 27, 2019, at 4:41 PM, Sherman Marshall < > sherman.david.marsh...@gmail.com> wrote: > > > > My name is Sherman Marshall. I live in San Diego, CA. love Java, and am > > interested in Distributed Systems, HP

Re: How can I help?

2019-02-27 Thread David Blevins
> On Feb 27, 2019, at 4:41 PM, Sherman Marshall > wrote: > > My name is Sherman Marshall. I live in San Diego, CA. love Java, and am > interested in Distributed Systems, HPC, and ML. I welcome a challenge, but > am learning that software requires diligence and finesse. I hope to be able > to lea

[GitHub] ShermanMarshall opened a new pull request #426: Simple code refactoring. Trying to gain familiarity with the project

2019-02-27 Thread GitBox
ShermanMarshall opened a new pull request #426: Simple code refactoring. Trying to gain familiarity with the project URL: https://github.com/apache/tomee/pull/426 Tested, no conflicts, project builds with both JDK8 and 10. JIRA ticket is https://issues.apache.org/jira/browse/TOMEE-2479 --

New Status of TomEE 8

2019-02-27 Thread David Blevins
> On Feb 27, 2019, at 12:47 PM, j4fm wrote: > > On Jarkata EE cert... +1 for after 8 is released. This conversation just > reminded me of this thread quite some time ago now, with some views :) > > Status-of-TomEE-8 >

How can I help?

2019-02-27 Thread Sherman Marshall
To Whom it May Concern, My name is Sherman Marshall. I live in San Diego, CA. love Java, and am interested in Distributed Systems, HPC, and ML. I welcome a challenge, but am learning that software requires diligence and finesse. I hope to be able to learn and contribute alike. I am following inst

Re: MicroProfile Integration in Plus and Plume

2019-02-27 Thread Roberto Cortez
Yes, I’ll check. Thank you! > On 27 Feb 2019, at 23:13, j4fm wrote: > > The bad news is my tests showed the default.exclusions did not fix the issue. > The good news is I found the static extension that was always registering > the JWT providers. So I've commented that out as now your new appro

Re: MicroProfile Integration in Plus and Plume

2019-02-27 Thread j4fm
The bad news is my tests showed the default.exclusions did not fix the issue. The good news is I found the static extension that was always registering the JWT providers. So I've commented that out as now your new approach of scanning the providers automatically is working just fine. I've added t

Re: TOMEE-2477 - Upgrade .gitignore to ignore files generated by test.

2019-02-27 Thread Otávio Gonçalves de Santana
+1 Nice Daniel. On Wed, Feb 27, 2019 at 1:15 PM Daniel Cunha wrote: > Hi folks, > > Ticket: https://issues.apache.org/jira/browse/TOMEE-2477 > > PR: https://github.com/apache/tomee/pull/425 > > Please review it and merge. > > Thank you. > > -- >

Re: TomEE Web vs TomEE MP vs TomEE Plus

2019-02-27 Thread j4fm
On Jarkata EE cert... +1 for after 8 is released. This conversation just reminded me of this thread quite some time ago now, with some views :) Status-of-TomEE-8 -- Sent from: http://tomee-openejb.979440.n4.nabble.

Re: TomEE Web vs TomEE MP vs TomEE Plus

2019-02-27 Thread Jean-Louis Monteiro
As many mentioned, we are working on several things before we can get a final version in my opinion. Releasing milestones is good in my opinion as it allows everyone to test new features and see the progress. It's also a perfect way to get feedback from users. >From experience we never get the fir

Re: TomEE Web vs TomEE MP vs TomEE Plus

2019-02-27 Thread Gerwin Jansen
+1 for James' proposal! -Original Message- From: j4fm Sent: woensdag 27 februari 2019 19:38 To: dev@tomee.apache.org Subject: [EXTERNAL] - Re: TomEE Web vs TomEE MP vs TomEE Plus Personally, (I'm not sure what the standard process is) I would love to see TomEE 8 final release with CXF

Re: TomEE Web vs TomEE MP vs TomEE Plus

2019-02-27 Thread Thomas Andraschko
I would like to see a bval release before a final. And i would like to see a working embedded maven plugin with Java 11. j4fm schrieb am Mi., 27. Feb. 2019, 19:37: > Personally, (I'm not sure what the standard process is) I would love to see > TomEE 8 final release with CXF 3.3.0/JAXB 2.3.2 and

Re: TomEE Web vs TomEE MP vs TomEE Plus

2019-02-27 Thread j4fm
Personally, (I'm not sure what the standard process is) I would love to see TomEE 8 final release with CXF 3.3.0/JAXB 2.3.2 and MP in Plus/Plume before end of March. An M3 with what we have (especially CXF 3.3.0/JAXB 2.3.2) would be great too to run stable for a couple of weeks or so. -- Sent f

Re: TOMEE-2476 - Fix async-method documentation

2019-02-27 Thread César Hernández Mendoza
Thank you Daniel, +1. Can some of the committers please move forward. El mié., 27 feb. 2019 a las 9:55, Daniel Cunha () escribió: > Hi folks, > > Ticket: https://issues.apache.org/jira/browse/TOMEE-2476 > PR: https://github.com/apache/tomee/pull/423 > > Please review it and merge. > > Thank you.

Re: MicroProfile Integration in Plus and Plume

2019-02-27 Thread j4fm
Cool then, PR 424 just needs merging to fix this. The setting itself is working just fine. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-02-27 Thread Roberto Cortez
Oh yes, we probably forgot about that, since it actually never gave an error like we were having with the other filters. Please remove it as well when the setting is off :) Cheers, Roberto > On 27 Feb 2019, at 16:14, j4fm wrote: > > Hi Roberto > > I have found that MP-JWT is missing from the

TOMEE-2477 - Upgrade .gitignore to ignore files generated by test.

2019-02-27 Thread Daniel Cunha
Hi folks, Ticket: https://issues.apache.org/jira/browse/TOMEE-2477 PR: https://github.com/apache/tomee/pull/425 Please review it and merge. Thank you. -- Daniel "soro" Cunha https://twitter.com/dvlc_

Re: MicroProfile Integration in Plus and Plume

2019-02-27 Thread j4fm
Hi Roberto I have found that MP-JWT is missing from the default.exclusions. Is that expected? I see the JWT Filter being added in all cases even when tomee.mp.scan=none is set but also when tomee.mp.scan=all is set, the JWT Filter is added twice. If not intended, I have submitted PR424. Thanks

[GitHub] danielsoro opened a new pull request #425: TOMEE-2477 - Upgrade .gitignore to ignore files generated by test.

2019-02-27 Thread GitBox
danielsoro opened a new pull request #425: TOMEE-2477 - Upgrade .gitignore to ignore files generated by test. URL: https://github.com/apache/tomee/pull/425 This is an automated message from the Apache Git Service. To respond

[GitHub] j4fm opened a new pull request #424: Add missing MP-JWT exclusion

2019-02-27 Thread GitBox
j4fm opened a new pull request #424: Add missing MP-JWT exclusion URL: https://github.com/apache/tomee/pull/424 Fixes JWT Filter being added in ALL cases even when tomee.mp.scan=none is set and fixes duplicate JWT Filter when tomee.mp.scan=all is set. --

TOMEE-2476 - Fix async-method documentation

2019-02-27 Thread Daniel Cunha
Hi folks, Ticket: https://issues.apache.org/jira/browse/TOMEE-2476 PR: https://github.com/apache/tomee/pull/423 Please review it and merge. Thank you. -- Daniel "soro" Cunha https://twitter.com/dvlc_

[GitHub] danielsoro opened a new pull request #423: TOMEE-2476 - Fix async-method documentation

2019-02-27 Thread GitBox
danielsoro opened a new pull request #423: TOMEE-2476 - Fix async-method documentation URL: https://github.com/apache/tomee/pull/423 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] otaviojava opened a new pull request #422: Creates Unit test to CmpJpaConversion [WIP]

2019-02-27 Thread GitBox
otaviojava opened a new pull request #422: Creates Unit test to CmpJpaConversion [WIP] URL: https://github.com/apache/tomee/pull/422 This is an automated message from the Apache Git Service. To respond to the message, please

Re: Portuguese translation of exemples/simple-rest

2019-02-27 Thread Daniel Cunha
Well, since you need to have the ticket assigned to you, that is the way at moment. So, yes, you need to ask someone here to assigned the ticket for you. Then, only open a ticket on JIRA is not enough if we don't know who is working on it (assigned for). And when you have the ticket done, is good

Re: Portuguese translation of exemples/simple-rest

2019-02-27 Thread César Hernández Mendoza
Hi Gabriel, Can I translate it? Yes you can :). Other question: whenever I want do something, should I advertise on the > list? > Or I just create a task on JIRA and I can start.. The recommended way is to Create the JIRA and notify on the mailing list so we avoid duplication of work and we all

Re: Mockito or any Mock framework at TomEE

2019-02-27 Thread Jean-Louis Monteiro
Hi, Yes we used to have an integration for Mockito. For instance, when using the application composer for tests, you can get TomEE to inject a mock for you. Check out this example for instance https://github.com/apache/tomee/tree/master/examples/rest-applicationcomposer-mockito Hope this helps -

Mockito or any Mock framework at TomEE

2019-02-27 Thread Otávio Gonçalves de Santana
Hello everyone. I have a question. Do we have any Mock framework such as JMockito at TomEE? I would like to create a test at openejb-core, but I did not find any dependency on it.

Portuguese translation of exemples/simple-rest

2019-02-27 Thread Gabriel Ferreira
Hey guys, searching for another task I find this examples/simple-rest. https://github.com/apache/tomee/tree/master/examples/simple-rest http://tomee.apache.org/tomee-8.0/examples/simple-rest.html Can I translate it? Other question: whenever I want do something, should I advertise on the list? Or

Re: Improvements and Portuguese translation of examples/jpa-hibernate - PR #421

2019-02-27 Thread Gabriel Ferreira
Awesome! I will search another example for translate and improve (if necessary). Thank you guys! Em qua, 27 de fev de 2019 às 10:44, Daniel Cunha escreveu: > Hi Gabriel, > > I reviewed your PR and sounds good. > PR approved! We need to wait some commit to merge it. > > Thank you! :) > > Em qua,

Re: Improvements and Portuguese translation of examples/jpa-hibernate - PR #421

2019-02-27 Thread Daniel Cunha
Hi Gabriel, I reviewed your PR and sounds good. PR approved! We need to wait some commit to merge it. Thank you! :) Em qua, 27 de fev de 2019 às 10:41, Daniel Cunha escreveu: > Hi Hilton, > > You can review the portuguese content and you can help to create > documentation in portuguese as well

[GitHub] danielsoro commented on issue #421: TOMEE-2474 Translate to Portuguese: examples/jpa-hibernate.

2019-02-27 Thread GitBox
danielsoro commented on issue #421: TOMEE-2474 Translate to Portuguese: examples/jpa-hibernate. URL: https://github.com/apache/tomee/pull/421#issuecomment-467866011 Seems good to go! :) +1 This is an automated message fro

Re: Improvements and Portuguese translation of examples/jpa-hibernate - PR #421

2019-02-27 Thread Daniel Cunha
Hi Hilton, You can review the portuguese content and you can help to create documentation in portuguese as well. :) Em qua, 27 de fev de 2019 às 08:58, Hilton Wichwski Silva escreveu: > Hi everyone! > > I'm a native portuguese speaker, how can I help? > > On Wed, Feb 27, 2019, 8:55 AM Gabriel F

Re: Improvements and Portuguese translation of examples/jpa-hibernate - PR #421

2019-02-27 Thread Hilton Wichwski Silva
Hi everyone! I'm a native portuguese speaker, how can I help? On Wed, Feb 27, 2019, 8:55 AM Gabriel Ferreira wrote: > Cool guys, so, what happens now ? :p > Do I have to wait until it's approved ? > Or I can get another task? > :D > > Em ter, 26 de fev de 2019 às 23:12, César Hernández Mendoza

Re: Improvements and Portuguese translation of examples/jpa-hibernate - PR #421

2019-02-27 Thread Gabriel Ferreira
Cool guys, so, what happens now ? :p Do I have to wait until it's approved ? Or I can get another task? :D Em ter, 26 de fev de 2019 às 23:12, César Hernández Mendoza < cesargu...@gmail.com> escreveu: > Thank you, Gabriel, nice work! > > +1 for the improved English version. > Unfortunately, I don

[GitHub] danielsoro closed pull request #287: Fix test for TomEECliIT

2019-02-27 Thread GitBox
danielsoro closed pull request #287: Fix test for TomEECliIT URL: https://github.com/apache/tomee/pull/287 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] danielsoro closed pull request #286: Fix test for TomEECliIT

2019-02-27 Thread GitBox
danielsoro closed pull request #286: Fix test for TomEECliIT URL: https://github.com/apache/tomee/pull/286 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the