Re: TOMEE-2369/File -2402: Add README.adoc to webservice-ws-with-resources-config/. Need to be merged

2019-03-29 Thread Richard Monson-Haefel
Hm. Well, there are over 800 Resolved tickets dating back to 2013 so I don't think they get moved to closed when a release comes out. There are an equal number marked as "Closed" so it seems to me that "Resolved" and "Closed" is a matter of style which I think is something we should get away from

[GitHub] [tomee] jgallimore merged pull request #453: Replace `openejb` references in deployments.adoc

2019-03-29 Thread GitBox
jgallimore merged pull request #453: Replace `openejb` references in deployments.adoc URL: https://github.com/apache/tomee/pull/453 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomee] doychin commented on a change in pull request #451: Remove unused method (tomee-2499)

2019-03-29 Thread GitBox
doychin commented on a change in pull request #451: Remove unused method (tomee-2499) URL: https://github.com/apache/tomee/pull/451#discussion_r270573483 ## File path: container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java ## @@ -2259,22

[GitHub] [tomee] AndyGee commented on issue #293: WIP - experimentation with Java 11

2019-03-29 Thread GitBox
AndyGee commented on issue #293: WIP - experimentation with Java 11 URL: https://github.com/apache/tomee/pull/293#issuecomment-478144928 @jgallimore 12 is out now ;-) This is an automated message from the Apache Git Service. T

[GitHub] [tomee] AndyGee commented on a change in pull request #451: Remove unused method (tomee-2499)

2019-03-29 Thread GitBox
AndyGee commented on a change in pull request #451: Remove unused method (tomee-2499) URL: https://github.com/apache/tomee/pull/451#discussion_r270568206 ## File path: container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java ## @@ -2259,22

[GitHub] [tomee] AndyGee commented on a change in pull request #451: Remove unused method (tomee-2499)

2019-03-29 Thread GitBox
AndyGee commented on a change in pull request #451: Remove unused method (tomee-2499) URL: https://github.com/apache/tomee/pull/451#discussion_r270568013 ## File path: container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java ## @@ -2259,22

Re: @OpenAPIDefinition not working

2019-03-29 Thread Otávio Gonçalves de Santana
I created the TomEEOpenAPIExtension that wrapper the GeronimoOpenAPIExtension. My question is, how can I shut down the GeronimoOpenAPIExtension extension? I tried to append this value at system.properties: openejb.classloader.forced-skip=org.apache.geronimo.microprofile.openapi.cdi But it does no

[GitHub] [tomee] AndyGee commented on issue #452: Make ArrayEnumeration generics aware

2019-03-29 Thread GitBox
AndyGee commented on issue #452: Make ArrayEnumeration generics aware URL: https://github.com/apache/tomee/pull/452#issuecomment-478143480 @jgallimore wdyt? This is an automated message from the Apache Git Service. To respond

[GitHub] [tomee] AndyGee commented on issue #360: Cleanup test code and also minor changes in the tested class.

2019-03-29 Thread GitBox
AndyGee commented on issue #360: Cleanup test code and also minor changes in the tested class. URL: https://github.com/apache/tomee/pull/360#issuecomment-478142466 @jgallimore this looks good to me. WDYT? This is an automated

[GitHub] [tomee] eminence opened a new pull request #453: Replace `openejb` references in deployments.adoc

2019-03-29 Thread GitBox
eminence opened a new pull request #453: Replace `openejb` references in deployments.adoc URL: https://github.com/apache/tomee/pull/453 This file is hosted at http://tomee.apache.org/deployments.html Note there is still a broken link to "OPENEJB:Configuration", but I don't know wher

Re: TOMEE-2369/File -2402: Add README.adoc to webservice-ws-with-resources-config/. Need to be merged

2019-03-29 Thread Jean-Louis Monteiro
And also, not saying it's optimal or we could not do otherwise if that makes more sense. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Mar 29, 2019 at 8:10 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > I haven't done a release for a while

Re: TOMEE-2369/File -2402: Add README.adoc to webservice-ws-with-resources-config/. Need to be merged

2019-03-29 Thread Jean-Louis Monteiro
I haven't done a release for a while so trying to speak from what I recall. But others can correct me. When a ticket is being worked on by someone, we assign it to the contributor. Discussion is going to happen on the mailing list and at some point contributor asks for review on the mailing list.

Re: TOMEE-2369/File -2402: Add README.adoc to webservice-ws-with-resources-config/. Need to be merged

2019-03-29 Thread Richard Monson-Haefel
Could you clarify the use of "Resolved" for me? I was under the impression that a Ticket was marked "Resolved", as opposed to "Closed", when the contributor had finished working on it and was waiting for someone to review. What am I missing? On Fri, Mar 29, 2019 at 10:53 AM Jean-Louis Monteiro <

Re: TOMEE-2465: JDK 11 compatibility on Tomee 7.1.1 Needs an Update

2019-03-29 Thread Jean-Louis Monteiro
I would need to refresh my mind on this. There are many libraries to update and a lot of work to do. Upgrading XBean on 7.1.x can be done, but under the cover ASM is updated too (shaded) and I'm not sure about the consequences. >From a community point of view, I am not sure we can yet start backp

Re: TOMEE-2369/File -2402: Add README.adoc to webservice-ws-with-resources-config/. Need to be merged

2019-03-29 Thread Jean-Louis Monteiro
done. Marked as resolved because we close during release only -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Mar 29, 2019 at 5:58 AM Richard Monson-Haefel < monsonhae...@gmail.com> wrote: > This ticket was already merged (https://github.com/apache/tomee

TOMEE-2434 Improve the `colist` css

2019-03-29 Thread Richard Monson-Haefel
Rafael (or anyone): This ticket has been worked on since December of 2018. It seems to leave off with a question from Rafael. Could someone take a look at it and let me know if it should be closed? (Also, if should be closed, than please close it because I cannot do that). https://jira.apache.

Re: @OpenAPIDefinition not working

2019-03-29 Thread Otávio Gonçalves de Santana
Unfortunately, this approach does not work. ProxyFactory proxyFactory = new ProxyFactory(); proxyFactory.setSuperclass(Application.class); proxyFactory.setFilter(new MethodFilter() { public boolean isHandled(Method m) { return !m.getName().equals("finalize"); } }); Class aClass =

TOMEE-2369/File -2402: Add README.adoc to webservice-ws-with-resources-config/. Need to be merged

2019-03-29 Thread Richard Monson-Haefel
This ticket was already merged (https://github.com/apache/tomee/pull/391) but remains InProgress. I can't change it to closed. Can someone do that please? -- Richard Monson-Haefel https://twitter.com/rmonson https://www.linkedin.com/in/monsonhaefel/

TOMEE-2465: JDK 11 compatibility on Tomee 7.1.1 Needs an Update

2019-03-29 Thread Richard Monson-Haefel
Jean-Louis, This bug, reported by and assigned to Salomon Mayengue, has what looks like closing comments referencing TOMEE-2272 which you fixed. Can you take a look at it and determine if it should be closed or merged or whatever? It's been unresolved since Feb 8th. Let me know the outcome if yo