Re: Java 11, victory day?

2019-08-22 Thread Jean-Louis Monteiro
Thanks Alex. Most of it was working, but some tests were failing in the build. It required quite a lot of testing and small tweaks. No big issue though. Making sure that all examples, all MicroProfile TCKs and a big chunk of Jakarta EE TCK are also passing is good for confidence. I'm still

Re: Java 11, victory day?

2019-08-22 Thread Alex The Rocker
Hello Jean-Louis, Congratulations for this great achievement! This will eventually make newcomers to TomEE more confortable at using it with current LTS Java version (yeah, Java 11). On a side note, I've been running in production TomEE+ 7.0.6 with Java 11 with web apps relying on JAX-WS,

Re: Getting a TomEE 8.0.0 final out the door

2019-08-22 Thread Jean-Louis Monteiro
Pulling this thread up to the list Now that we have Java 11 support, and a good MicroProfile coverage. What about trying something out end of the month? We could have something for CodeOne and use the event to promote TomEE. Thoughts? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro

Java 11, victory day?

2019-08-22 Thread Jean-Louis Monteiro
Hi everyone, Should we claim victory? Master is now green with full build + test using JDK 8. https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1165 Master is also green with full build JDK 8 + Java 11 test profile.

Re: Yank Polling application example

2019-08-22 Thread Jean-Louis Monteiro
Thanks Richard. I am ok with plan 1/ if someone wants to contribute it. I would still yank the polling-mdb module. It has nothing to do with the rest of the application and does not bring anything useful to teach. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com

Re: Yank Polling application example

2019-08-22 Thread Zowalla, Richard
Hi, I did a quick scan of the module. From an outside point of view: I have no idea, what is going on in this example.The biggest point is the missing documentation / explanation. I see two options: (a) add explanation / documentation and rework the example (b) remove it Best,Richard Am

Yank Polling application example

2019-08-22 Thread Jean-Louis Monteiro
Hi While working on Java 11, I was facing some issues with the polling sample, especially the polling-mdb module. I ended up commenting out the entire module, but it's not clear to me, what we are teaching in this example. The polling-mdb module does not do much and there is zero explanation. I

[GitHub] [tomee] Daniel-Dos commented on issue #540: TOMEE-2631 - Update Deltaspike version to 1.9.1

2019-08-22 Thread GitBox
Daniel-Dos commented on issue #540: TOMEE-2631 - Update Deltaspike version to 1.9.1 URL: https://github.com/apache/tomee/pull/540#issuecomment-523886577 I need see that. I must has made a copy for accident. Thanks for review.

[GitHub] asf-ci posts the same message multiple times?

2019-08-22 Thread Zowalla, Richard
Hi, why does "asf-ci" post multiple times inside certain PRs, i.e. https://github.com/apache/tomee/pull/541 I dont think, that I can report this directly to infrastructure? Bestg, Richard -- Richard Zowalla, M.Sc. Research Associate, PhD Student | Medical Informatics Hochschule Heilbronn

[GitHub] [tomee] rzo1 opened a new pull request #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
rzo1 opened a new pull request #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/541 Hi, this PR is a follow up of the discussion in https://github.com/apache/tomee/pull/427 and reflects the

[GitHub] [tomee] asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/541#issuecomment-523874982 Can one of the admins verify this patch?

[GitHub] [tomee] asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/541#issuecomment-523874985 Can one of the admins verify this patch?

[GitHub] [tomee] asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/541#issuecomment-523874983 Can one of the admins verify this patch?

[GitHub] [tomee] asf-ci commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/427#issuecomment-523873646 Can one of the admins verify this patch?

[GitHub] [tomee] asf-ci commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/427#issuecomment-523873644 Can one of the admins verify this patch?

[GitHub] [tomee] rzo1 commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
rzo1 commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/427#issuecomment-523873636 @jeanouii Ok - i will submit a PR soon

[GitHub] [tomee] asf-ci commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/427#issuecomment-523873649 Can one of the admins verify this patch?

TOMEE-2419 - Web Server Configuration for TomEE Website - Easy fix available?

2019-08-22 Thread Zowalla, Richard
Hi, I think TOMEE-2419 can be fixed easiliy. https://tomee.apache.org/ is reachable via a valid certificate but there is no permanent redirect from plain http to https. I think this would be a benefit (also in terms of search engine rankings) Can we change this easily ? Or who is in charge for