[GitHub] [tomee] asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class

2019-10-15 Thread GitBox
asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589#issuecomment-542504156 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [tomee] asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class

2019-10-15 Thread GitBox
asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589#issuecomment-542504158 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [tomee] asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class

2019-10-15 Thread GitBox
asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589#issuecomment-542504157 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [tomee] asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class

2019-10-15 Thread GitBox
asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589#issuecomment-542504154 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [tomee] sercheo87 opened a new pull request #589: [TOMEE-2114] - Put elements to member of class

2019-10-15 Thread GitBox
sercheo87 opened a new pull request #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [tomee] asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class

2019-10-15 Thread GitBox
asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589#issuecomment-542504160 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [tomee] jgallimore merged pull request #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation

2019-10-15 Thread GitBox
jgallimore merged pull request #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation URL: https://github.com/apache/tomee/pull/576 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [tomee] monsonhaefel commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation

2019-10-15 Thread GitBox
monsonhaefel commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation URL: https://github.com/apache/tomee/pull/576#issuecomment-542279576 Perfect. Let's get this merged! This is an automat

[GitHub] [tomee] emecas commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation

2019-10-15 Thread GitBox
emecas commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation URL: https://github.com/apache/tomee/pull/576#issuecomment-542273158 addressed @monsonhaefel review at commit 173d75728 This

[GitHub] [tomee] jgallimore merged pull request #579: TOMEE-2697-Translate to portuguese-async-servlet

2019-10-15 Thread GitBox
jgallimore merged pull request #579: TOMEE-2697-Translate to portuguese-async-servlet URL: https://github.com/apache/tomee/pull/579 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomee] jgallimore merged pull request #581: TOMEE-2699-Translate to portuguese MicroProfile - Timeout

2019-10-15 Thread GitBox
jgallimore merged pull request #581: TOMEE-2699-Translate to portuguese MicroProfile - Timeout URL: https://github.com/apache/tomee/pull/581 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [tomee] monsonhaefel commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation

2019-10-15 Thread GitBox
monsonhaefel commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation URL: https://github.com/apache/tomee/pull/576#issuecomment-542219564 This looks great! Nice job! I found one very minor error. Change "need to beging" to "need to begin" removing the

[GitHub] [tomee] jgallimore merged pull request #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm

2019-10-15 Thread GitBox
jgallimore merged pull request #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm URL: https://github.com/apache/tomee/pull/585 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomee] monsonhaefel commented on issue #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm

2019-10-15 Thread GitBox
monsonhaefel commented on issue #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm URL: https://github.com/apache/tomee/pull/585#issuecomment-542194323 I've reviewed this with Google Translate and it reads well in English. I think its ready to be merged. -

[GitHub] [tomee] Daniel-Dos commented on issue #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm

2019-10-15 Thread GitBox
Daniel-Dos commented on issue #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm URL: https://github.com/apache/tomee/pull/585#issuecomment-542177085 Done, review again please. This is an automated message from the Apach

[GitHub] [tomee] jgallimore merged pull request #588: TOMEE-2711 translation into portuguese examples/vaadin-lts-v10 and fix in jbake english version

2019-10-15 Thread GitBox
jgallimore merged pull request #588: TOMEE-2711 translation into portuguese examples/vaadin-lts-v10 and fix in jbake english version URL: https://github.com/apache/tomee/pull/588 This is an automated message from the Apache

[GitHub] [tomee] jgallimore merged pull request #586: TOMEE-2707-Translate example datasource-ciphered-password

2019-10-15 Thread GitBox
jgallimore merged pull request #586: TOMEE-2707-Translate example datasource-ciphered-password URL: https://github.com/apache/tomee/pull/586 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [tomee] jgallimore merged pull request #587: TOMEE-2710 jbake fix in examples/vaadin-lts-v08

2019-10-15 Thread GitBox
jgallimore merged pull request #587: TOMEE-2710 jbake fix in examples/vaadin-lts-v08 URL: https://github.com/apache/tomee/pull/587 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [tomee] monsonhaefel commented on issue #588: TOMEE-2711 translation into portuguese examples/vaadin-lts-v10 and fix in jbake english version

2019-10-15 Thread GitBox
monsonhaefel commented on issue #588: TOMEE-2711 translation into portuguese examples/vaadin-lts-v10 and fix in jbake english version URL: https://github.com/apache/tomee/pull/588#issuecomment-542160582 I looked it over in Google translate and it looks good to me! -

Re: [GitHub] [tomee] marcoantoniobferreira commented on a change in pull request #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm

2019-10-15 Thread Richard Monson-Haefel
Great job on the review, Marco! Daniel, with a few quick changes, suggested by Marco we can get this done and merged! On Mon, Oct 14, 2019 at 9:33 PM GitBox wrote: > marcoantoniobferreira commented on a change in pull request #585: > TOMEE-2700-Translate to portuguese - Cucumber-jvm > URL: http

[GitHub] [tomee] monsonhaefel commented on a change in pull request #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm

2019-10-15 Thread GitBox
monsonhaefel commented on a change in pull request #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm URL: https://github.com/apache/tomee/pull/585#discussion_r334884652 ## File path: examples/cucumber-jvm/README_pt.adoc ## @@ -0,0 +1,187 @@ += Cucumber JVM +:index-gr