[GitHub] [tomee] marcoantoniobferreira commented on issue #629: TOMEE-2780 translation into portuguese of vaadin example

2020-02-25 Thread GitBox
marcoantoniobferreira commented on issue #629: TOMEE-2780 translation into portuguese of vaadin example URL: https://github.com/apache/tomee/pull/629#issuecomment-591136400 @cesarhernandezgt yes, i agree! This is an automated

[GitHub] [tomee] cesarhernandezgt commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo

2020-02-25 Thread GitBox
cesarhernandezgt commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo URL: https://github.com/apache/tomee/pull/626#issuecomment-591124534 > Since this upgrade only applied for those 3 examples, is there a way to include a check to validate the tests for each example are still passi

[GitHub] [tomee] marcoantoniobferreira commented on issue #629: TOMEE-2780 translation into portuguese of vaadin example

2020-02-25 Thread GitBox
marcoantoniobferreira commented on issue #629: TOMEE-2780 translation into portuguese of vaadin example URL: https://github.com/apache/tomee/pull/629#issuecomment-591107573 fixed! @cesarhernandezgt This is an automated messa

[GitHub] [tomee] emecas edited a comment on issue #626: TOMEE-2759-Update-Eclipse-Krazo

2020-02-25 Thread GitBox
emecas edited a comment on issue #626: TOMEE-2759-Update-Eclipse-Krazo URL: https://github.com/apache/tomee/pull/626#issuecomment-591094503 @cesarhernandezgt @Daniel-Dos This could be a little off-topic [or not :)] Since this upgrade only applied for those 3 examples, is the

[GitHub] [tomee] emecas commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo

2020-02-25 Thread GitBox
emecas commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo URL: https://github.com/apache/tomee/pull/626#issuecomment-591094503 This could be a little off-topic [or not :)] Since this upgrade only applied for those 3 examples, is there a way to include a check to validate the t

Re: Docker images for 8.0.0

2020-02-25 Thread Cesar Hernandez
Thanks much Rod, Jonathan and all in the community who made possible TomEE 8.0.1 available on docker hub. I checked the commits to understand the changes a new release will require for the docker files [1] but I wonder if there is some part of the Process that I can learn first and then contribute

Re: [VOTE] Release javaee-api 7.0-2

2020-02-25 Thread Cesar Hernandez
+1 Thanks Jonathan! El mar., 25 feb. 2020 a las 14:13, Jonathan Gallimore (< jonathan.gallim...@gmail.com>) escribió: > Hi > > This is a vote for an updated Java EE spec jar. This has a key change, > which is to use the Tomcat API libraries from 8.5.51 as opposed to 8.5.6. > > This is required to

Re: [VOTE] Release javaee-api 8.0-4

2020-02-25 Thread Cesar Hernandez
+1 thanks, Jonathan! El mar., 25 feb. 2020 a las 14:10, Jonathan Gallimore (< jonathan.gallim...@gmail.com>) escribió: > Hi > > This is a vote for an updated Java EE spec jar, with one single change over > javaee-api:8.0-3, which is to use the Tomcat API libraries from 9.0.31 as > opposed to 9.0.

[VOTE] Release javaee-api 7.0-2

2020-02-25 Thread Jonathan Gallimore
Hi This is a vote for an updated Java EE spec jar. This has a key change, which is to use the Tomcat API libraries from 8.5.51 as opposed to 8.5.6. This is required to fix an issue in the TomEE builds where javax.el.ExpressionFactory#getClassNameServices was returning the first line of the ASF li

[VOTE] Release javaee-api 8.0-4

2020-02-25 Thread Jonathan Gallimore
Hi This is a vote for an updated Java EE spec jar, with one single change over javaee-api:8.0-3, which is to use the Tomcat API libraries from 9.0.31 as opposed to 9.0.22. This is required to fix an issue in the TomEE builds where javax.el.ExpressionFactory#getClassNameServices was returning the

Java EE API jar release heads up

2020-02-25 Thread Jonathan Gallimore
Hi All, I've fixed the TomEE 8, 7.1.x and 7.0.x builds, which has required updating the Java EE API jar that we include with TomEE to pick up an update from Tomcat EL - specifically javax.el.ExpressionFactory#getClassNameServices was returning the first line of the ASF license header as opposed to

[GitHub] [tomee] cesarhernandezgt commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo

2020-02-25 Thread GitBox
cesarhernandezgt commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo URL: https://github.com/apache/tomee/pull/626#issuecomment-590915470 Hi @Daniel-Dos I couldn't merge the PR since it seems there is a small conflict. I'm happy to review again after that gets fixed. ---

Parent / child classloading control

2020-02-25 Thread Jonathan Gallimore
Hey folks I'm looking at an issue where a third-party library used in a webapp includes an API and implementation - in this case MicroProfile config 1.3. The API is using the service loader mechanism to load the implementation, but has code in it to force the parent classloader to be used. The Mic