[GitHub] [tomee] rzo1 opened a new pull request #723: TOMEE-2933 - Updates to eclipselink 2.7.7

2020-11-27 Thread GitBox
rzo1 opened a new pull request #723: URL: https://github.com/apache/tomee/pull/723 # What does this PR do? This PR updates to `eclipselink` in version 2.7.7 (was 2.7.4). This version fixes [runtime issues](https://bugs.eclipse.org/bugs/show_bug.cgi?id=551398) in J11+ For

[GitHub] [tomee] rzo1 opened a new pull request #722: TOMEE-2932 - Fixes javax.ws.rs.NotSupportedException: HTTP 415 Unsupported Media Type

2020-11-27 Thread GitBox
rzo1 opened a new pull request #722: URL: https://github.com/apache/tomee/pull/722 # What does this PR do? As discussed on the mailing list [1], we found test errors in `MovieServiceTest`. The root cause is, that the server only accepts `application/json` but the test was

[GitHub] [tomee] rzo1 opened a new pull request #721: TOMEE-2324 - DRAFT: Remove Corba ORB APIs from Codebase

2020-11-27 Thread GitBox
rzo1 opened a new pull request #721: URL: https://github.com/apache/tomee/pull/721 # What does this PR do? As dicussed on the mailing list a few months ago [[1]](https://www.mail-archive.com/dev@tomee.apache.org/msg14097.html), building TomEE with Java 11 fails because of two

[GitHub] [tomee] rzo1 closed pull request #713: TOMEE-2324 - Remove Corba ORB APIs from Codebase

2020-11-27 Thread GitBox
rzo1 closed pull request #713: URL: https://github.com/apache/tomee/pull/713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomee] rmannibucau commented on pull request #713: TOMEE-2324 - Remove Corba ORB APIs from Codebase

2020-11-27 Thread GitBox
rmannibucau commented on pull request #713: URL: https://github.com/apache/tomee/pull/713#issuecomment-734784235 I think API can be in openejb-core spi package, corba impl depends on openejb-core and corba tests move to corba-integration module (we should avoid having a module for this

Re: JSON Pointer/Patch issue with /-

2020-11-27 Thread Romain Manni-Bucau
Hi JL, As discussed together - but sharing for others - we must take into account some points: 1. reading both spec, JSON-Patch enables to handle /- as your first did (ie consider it is last element). JSON-Patch uses JSON-Pointer but nowhere it is written it behaves as JSON-Pointer in all cases

[TCK] JPA issue

2020-11-27 Thread Jean-Louis Monteiro
Hello, As mentioned, I'm currently working on JPA to address the TCK issues. I'm facing one where I'd like to get some feedback. I think it's again a TCK bug that's why I would appreciate some more eyes before opening a challenge. The test is com.sun.ts.tests.jpa.ee.packaging.jar.Client -->

JSON Pointer/Patch issue with /-

2020-11-27 Thread Jean-Louis Monteiro
Hi, I was working to pass the TCK with Johnzon, but I have failures around the usage of "/-" in arrays. >From JSON Pointer RCF https://tools.ietf.org/html/rfc6901 > If the currently referenced value is a JSON array, the reference > token MUST contain either: > > * characters

[GitHub] [tomee] rzo1 commented on pull request #720: TOMEE-2930 - MoviesArquillianHtmlUnitTest -> Invalid byte 2 of 2-byte UTF-8 sequence. error.

2020-11-27 Thread GitBox
rzo1 commented on pull request #720: URL: https://github.com/apache/tomee/pull/720#issuecomment-734741694 > @rzo1 what about adding in surefire plugin the system property "project.version" and just do a System.getProperty("project.version", "default value SNAPSHOT") in the code? will stay

[GitHub] [tomee] rmannibucau commented on pull request #720: TOMEE-2930 - MoviesArquillianHtmlUnitTest -> Invalid byte 2 of 2-byte UTF-8 sequence. error.

2020-11-27 Thread GitBox
rmannibucau commented on pull request #720: URL: https://github.com/apache/tomee/pull/720#issuecomment-734741156 @rzo1 what about adding in surefire plugin the system property "project.version" and just do a System.getProperty("project.version", "default value SNAPSHOT") in the code? will

[GitHub] [tomee] rmannibucau commented on pull request #713: TOMEE-2324 - Remove Corba ORB APIs from Codebase

2020-11-27 Thread GitBox
rmannibucau commented on pull request #713: URL: https://github.com/apache/tomee/pull/713#issuecomment-734738706 @rzo1 yes except META-INF/services part, just org.apache.openejb.cx.CorbasProvider=org.apache.openejb..CorbasProviderImpl in system.properties OR an openejb event

[GitHub] [tomee] rzo1 commented on pull request #713: TOMEE-2324 - Remove Corba ORB APIs from Codebase

2020-11-27 Thread GitBox
rzo1 commented on pull request #713: URL: https://github.com/apache/tomee/pull/713#issuecomment-734730281 Thanks for the feedback, @rmannibucau. > create an org.apache.tomee:corba-integration module released independently (like javaee-api module) and depend on it. Would be

[GitHub] [tomee] rzo1 opened a new pull request #720: TOMEE-2930 - MoviesArquillianHtmlUnitTest -> Invalid byte 2 of 2-byte UTF-8 sequence. error.

2020-11-27 Thread GitBox
rzo1 opened a new pull request #720: URL: https://github.com/apache/tomee/pull/720 # What does this PR do? As discussed on the mailing list [3], we found test errors in `MoviesArquillianHtmlUnitTest`. While trying to reproduce it on my Linux machine, I found, that the

[GitHub] [tomee] rmannibucau commented on pull request #713: TOMEE-2324 - Remove Corba ORB APIs from Codebase

2020-11-27 Thread GitBox
rmannibucau commented on pull request #713: URL: https://github.com/apache/tomee/pull/713#issuecomment-734714050 Maybe two notes checking this PR: 1. generating the bytecode at build time can be an issue (if you check the TODO they will never happen with such an option). It can be

Re: CI job for tomee-7.0.x

2020-11-27 Thread Zowalla, Richard
Hi Cesar, i will give > The second failing test trowed a: [Fatal Error] :8:23: Invalid byte 2 > of2-byte UTF-8 sequence. error. >