Re: How can I help?

2022-04-26 Thread Zowalla, Richard
Hi, it would certainly help to track these issues as an issue. Maybe they are already solved (as the code has evolved) but maybe not, so it would be good to have them. Gruß Richard Am Dienstag, dem 26.04.2022 um 21:54 +0200 schrieb Zoltán Tichov: > Hi Richard! > > I have found two errors in To

Re: TomEE 9.x - from javax to jakarta namespace

2022-04-26 Thread Zowalla, Richard
Hi, I am not aware of any public reference list. There are some things, which floated around the mailing list or in the heads, which are: - Javamail is currently broken. We need to have a jakarta compatible version of Geronimo Javamail. This currently breaks 2 examples and prevents platform tck f

Re: TomEE 9.x - from javax to jakarta namespace

2022-04-26 Thread Cesar Hernandez
Hi all, Late last week I started to pick and create sub-task related to https://issues.apache.org/jira/browse/TOMEE-3862. The current CI master status [1] has helped me to identify tests that need fixes, examples that need dependencies updates to match the javax. -> jakarta , etc. Do we have a pl

[GitHub] [tomee] cesarhernandezgt closed pull request #794: Fix for random JMS2AMQTest failure

2022-04-26 Thread GitBox
cesarhernandezgt closed pull request #794: Fix for random JMS2AMQTest failure URL: https://github.com/apache/tomee/pull/794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [tomee] cesarhernandezgt commented on pull request #794: Fix for random JMS2AMQTest failure

2022-04-26 Thread GitBox
cesarhernandezgt commented on PR #794: URL: https://github.com/apache/tomee/pull/794#issuecomment-1110484766 @rzo1 I'm going to close this PR since the random failure hasn't been present anymore. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [tomee] cesarhernandezgt merged pull request #871: TOMEE-3927 fixs for sendToMdbWithTxAndCheckLeaks test

2022-04-26 Thread GitBox
cesarhernandezgt merged PR #871: URL: https://github.com/apache/tomee/pull/871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apa

[GitHub] [tomee] cesarhernandezgt commented on pull request #871: TOMEE-3927 fixs for sendToMdbWithTxAndCheckLeaks test

2022-04-26 Thread GitBox
cesarhernandezgt commented on PR #871: URL: https://github.com/apache/tomee/pull/871#issuecomment-1110483546 Thank you @rzo1 for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: How can I help?

2022-04-26 Thread Zoltán Tichov
Hi Richard! I have found two errors in Tomee 9.0.0-M7. Should I make tickets for these errors and try to fix them? Although they may have been fixed in the next version (9.0.0-M8) Zoltán On Sun, Apr 24, 2022 at 11:06 AM Zowalla, Richard < richard.zowa...@hs-heilbronn.de> wrote: > Hi Zoltán, > >

Re: Increasing Discard Old Builds strategy in CI

2022-04-26 Thread Cesar Hernandez
I forgot that /home/jenkins/.m2 is in the Agent and what is actually analyzed for the test results are the surefire files as Richard mentioned: /home/jenkins/jenkins-agent/workspace/Tomee/master-pull-request/ I'm +1 on trying a mvn clean as a post step to see if that reduces the size of the job

Re: TCK Work - Smoothing the path (was Re: How can I help?)

2022-04-26 Thread Zowalla, Richard
I slightly increased the default stack size limit of the forked test jvm in the related groovy script. It now works with Java 11 too. To summarize: The documentation is updated and setting up the EE9.1 TCK is quite easy. It basically boils down to: (0) Ensure to have Maven and Java (11/14). (1)

Re: Increasing Discard Old Builds strategy in CI

2022-04-26 Thread Cesar Hernandez
In the job, after the test results are executed we can add a post-build doing a: rm -rf /home/jenkins/.m2/ El mar, 26 abr 2022 a las 12:51, Zowalla, Richard (< richard.zowa...@hs-heilbronn.de>) escribió: > Afaik Jenkins is parsing the surefire report files. The log files might > also be import

Re: Increasing Discard Old Builds strategy in CI

2022-04-26 Thread Zowalla, Richard
Afaik Jenkins is parsing the surefire report files. The log files might also be important for the creator of the PR, so we would need to keep them too. Might be worth a try, I guess. Gruß Richard Am Dienstag, dem 26.04.2022 um 11:15 -0700 schrieb David Blevins: > > On Apr 26, 2022, at 10:47 AM,

Re: TCK Work - Smoothing the path (was Re: How can I help?)

2022-04-26 Thread Zowalla, Richard
Thanks & You are right! Running with JDK 14 works. JDK 17 has some issues with illegal access within the groovy code used. With JDK 14 I am hitting the Javamail issue - so the setup procedere basically works. That are good news. Gruß Richard Am Dienstag, dem 26.04.2022 um 19:48 +0200 schrieb

Re: Increasing Discard Old Builds strategy in CI

2022-04-26 Thread David Blevins
> On Apr 26, 2022, at 10:47 AM, Zowalla, Richard > wrote: > > However, we need to carefully monitor the disk usage / volume used as > INFRA has a problem if our used storage volume per jobs exceeds a > certain quota. > > We occupied 1,5T last week (cumulated over a few weeks) and they were a >

Re: Increasing Discard Old Builds strategy in CI

2022-04-26 Thread Cesar Hernandez
Thank you for the context Richard, My proposal is for master PR's only since I think this is where most of the activity is going on at the moment. We occupied 1,5T last week In that case, I think a more conservative proposal would be: Days to keep builds: 8 Max # of builds to keep: 15 El ma

[GitHub] [tomee] rzo1 commented on pull request #871: TOMEE-3927 fixs for sendToMdbWithTxAndCheckLeaks test

2022-04-26 Thread GitBox
rzo1 commented on PR #871: URL: https://github.com/apache/tomee/pull/871#issuecomment-1110084410 @cesarhernandezgt Is this related to https://github.com/apache/tomee/pull/678 (targets the same test case) ? -- This is an automated message from the Apache Git Service. To respond to the mess

Re: TCK Work - Smoothing the path (was Re: How can I help?)

2022-04-26 Thread Jean-Louis Monteiro
Sorry for the late reply. I managed to reproduce your issue. It does not seem to be a regular stackoverflow (loop without exit condition). Debugging the code with some additional traces, it looks like we are loading jar after jar and the stack isn't big enough to handle it in Java 11. I moved to a

Re: Increasing Discard Old Builds strategy in CI

2022-04-26 Thread Zowalla, Richard
Hi Cesar, I have no problem with increasing the values for the discard strategy. It makes sense to keep it a bit longer for PRs. However, we need to carefully monitor the disk usage / volume used as INFRA has a problem if our used storage volume per jobs exceeds a certain quota. We occupied 1,5

Re: TCK Work - Smoothing the path (was Re: How can I help?)

2022-04-26 Thread Zowalla, Richard
It looks like the SQL is not the real issue here - although it is a bit confusing because the select statements look ok to me. However, after same additional digging / fiddling arround, I am at a point, there the JVM for the tests does not startup due to an StackOverflowError [1]. I tried remote

Increasing Discard Old Builds strategy in CI

2022-04-26 Thread Cesar Hernandez
Hello, Our current Discard old builds Strategy in CI for PR's for the master branch is [1]: Days to keep builds: 2 Max # of builds to keep: 3 Is there any objection if I update this to at least: Days to keep builds: 15 Max # of builds to keep: 30 Currently, if one opens a PR on a Friday and tri

Re: TCK Work - Smoothing the path (was Re: How can I help?)

2022-04-26 Thread Zowalla, Richard
Hi, I changed the script pointing to the released ee9.1 tck now and updated the README accordingly. If the instructions are followed carefully, it will lead to a fresh installation. In the process, I noticed, that Glassfish 6.0.0 isn't available anymore and is replaced by 6.2.5 - JL mentioned on