rzo1 commented on PR #1232:
URL: https://github.com/apache/tomee/pull/1232#issuecomment-2210239887
LGTM, too :) - thanks @rmannibucau for review, feedback and (long)
explanation. It is really appreciated!
The CI gave some test failures originating from the change:
```
Tester
jungm commented on code in PR #1232:
URL: https://github.com/apache/tomee/pull/1232#discussion_r1666014083
##
container/openejb-core/src/main/java/org/apache/openejb/threads/impl/ContextServiceImplFactory.java:
##
@@ -77,6 +86,36 @@ public static ContextServiceImpl
newPropagate
jungm commented on code in PR #1232:
URL: https://github.com/apache/tomee/pull/1232#discussion_r1666012951
##
container/openejb-core/src/main/java/org/apache/openejb/threads/impl/ContextServiceImplFactory.java:
##
@@ -77,6 +86,36 @@ public static ContextServiceImpl
newPropagate
jungm commented on code in PR #1232:
URL: https://github.com/apache/tomee/pull/1232#discussion_r1666012747
##
container/openejb-core/src/main/java/org/apache/openejb/config/BuiltInEnvironmentEntries.java:
##
@@ -105,7 +105,6 @@ private void add(final JndiConsumer jndi, final
De
rmannibucau commented on code in PR #1232:
URL: https://github.com/apache/tomee/pull/1232#discussion_r1665752590
##
container/openejb-core/src/main/java/org/apache/openejb/threads/impl/ContextServiceImplFactory.java:
##
@@ -77,6 +86,36 @@ public static ContextServiceImpl
newPro
jungm commented on PR #1232:
URL: https://github.com/apache/tomee/pull/1232#issuecomment-2209056221
reworked now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
jungm commented on PR #1232:
URL: https://github.com/apache/tomee/pull/1232#issuecomment-220107
fair enough, I have next to no experience using JNDI so I guess you are
right ;)
Singleton in factory sounds like a good option
--
This is an automated message from the Apache Git Se
rmannibucau commented on PR #1232:
URL: https://github.com/apache/tomee/pull/1232#issuecomment-2208854388
@jungm I'd avoid global bindings whenever possible (there are no more useful
in 90% of the apps since JNDI got superseeded by annotation based injections -
EE 5). For your good point ab
jungm commented on PR #1232:
URL: https://github.com/apache/tomee/pull/1232#issuecomment-2208812288
I was thinking about two ways to fix this, either fix the factory so it just
works (like you suggested Romain) or to make sure there is a ContextService
bound in JNDI
Do you think we s
rmannibucau commented on PR #1232:
URL: https://github.com/apache/tomee/pull/1232#issuecomment-2208791509
Well there are a lot of things there. If you don't care of the detail just
read the last sentence ;).
> It is not about the TCK/tests, it is more or less about the requirement to
rzo1 commented on PR #1232:
URL: https://github.com/apache/tomee/pull/1232#issuecomment-2208750172
@rmannibucau I see. Just looked in 8.x and it was like that before, so I
agree, that we might just want to change the default and people not needing it,
can still disable.
--
This is an aut
rmannibucau commented on PR #1232:
URL: https://github.com/apache/tomee/pull/1232#issuecomment-2208744296
Not really, this 9 years old behavior intent is to not create default
resources when it is not needed (in all apps except TCK ;)) so think it is sane
to revert back to the original beha
rzo1 commented on PR #1232:
URL: https://github.com/apache/tomee/pull/1232#issuecomment-2208614240
Think the original intention of the flag was to prevent creartion of JMS
stuff (if one looks into the history)
--
This is an automated message from the Apache Git Service.
To respond to the
jungm commented on PR #1232:
URL: https://github.com/apache/tomee/pull/1232#issuecomment-2208610651
These services were added unconditionally before as well until
https://github.com/apache/tomee/commit/2c2fa2d95a68ded5ef52526b27838915730ff339
to fix ConfigurationFactoryTest, I reverted this
rmannibucau commented on PR #1232:
URL: https://github.com/apache/tomee/pull/1232#issuecomment-2208598614
maybe just change the default of `openejb.environment.default` instead of
the code which prevent to disable it (main case)
--
This is an automated message from the Apache Git Service.
+1
Am Do., 4. Juli 2024 um 11:28 Uhr schrieb Richard Zowalla <
rich...@zowalla.com>:
> Agreed.
>
> Am 4. Juli 2024 11:07:21 MESZ schrieb Markus Jung :
> >Hey all,
> >
> >
> >took a look at the Concurrency 3.0 spec - it states:
> >
> >The Jakarta EE Product Provider must provide a preconfigured, d
Agreed.
Am 4. Juli 2024 11:07:21 MESZ schrieb Markus Jung :
>Hey all,
>
>
>took a look at the Concurrency 3.0 spec - it states:
>
>The Jakarta EE Product Provider must provide a preconfigured, default
>ContextService for use by application components under the JNDI name
>java:comp/DefaultContex
jungm opened a new pull request, #1232:
URL: https://github.com/apache/tomee/pull/1232
Resolves [TOMEE-4354](https://issues.apache.org/jira/browse/TOMEE-4354)
Makes the following configuration work again on TomEE 10 (note that Context
is omitted):
```
Core = 5
M
Hey all,
took a look at the Concurrency 3.0 spec - it states:
The Jakarta EE Product Provider must provide a preconfigured, default
ContextService for use by application components under the JNDI name
java:comp/DefaultContextService
IMO considering this it makes sense to automatically reso
19 matches
Mail list logo
