Re: JUnit5 Jupiter support with Arquillian

2021-03-06 Thread brunobat
Hi All! 2 years have passed. Any news about this? Can we now test with Arquillian and TomEE with JUnit 5? Cheers Bruno Baptista https://twitter.com/brunobat_ -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

[GitHub] tomee pull request #345: Incorrect artifact version in the test

2019-01-03 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/345#discussion_r244945167 --- Diff: examples/simple-ear/moviefun-functional-tests/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java --- @@ -37,7 +37,7

[GitHub] tomee issue #349: Some of the returned values are performance dependant - st...

2019-01-03 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/349 Hi @doychin. Thanks for the PR. Can you please resolve the conflict? ---

[GitHub] tomee pull request #345: Incorrect artifact version in the test

2019-01-03 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/345#discussion_r244943871 --- Diff: examples/simple-ear/moviefun-functional-tests/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java --- @@ -37,7 +37,7

[GitHub] tomee issue #329: Example Project - Kotlin, CDI, JAX-RS

2018-12-31 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/329 Please register and send us an email to dev@tomee.apache.org. We would love to hear from you over there! ---

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

2018-12-31 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244580685 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -71,57 +50,74 @@ import java.net.MalformedURLException

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

2018-12-31 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244574001 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -221,12 +218,13 @@ private static Logger logger() { // don't

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

2018-12-31 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244574174 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -71,57 +50,74 @@ import java.net.MalformedURLException

[GitHub] tomee issue #305: ApplicationComposerExtension. Problem: When I add junit-ju...

2018-12-27 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/305 Hi @cocorossello I now get and error when I run: `mvn clean test -Dtest=ApplicationComposerExtension*` > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-suref

[GitHub] tomee issue #289: TOMEE-2301 Concurrency utilities example

2018-12-26 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/289 Hey, This should be ok for reviewing now. ---

[GitHub] tomee issue #180: TOMEE-2267 Check Bean Validation signatures at build time

2018-12-26 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/180 @gsmet can you please rebase? ---

[GitHub] tomee issue #305: ApplicationComposerExtension. Problem: When I add junit-ju...

2018-12-24 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/305 @cocorossello That test duplication only happens when running the test-testng profile, right? ---

[GitHub] tomee issue #299: TOMEE-2361 Improve main README file (WIP)

2018-12-24 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/299 I cannot commit or push or make a PR against your branch/Repo. I guess we can merge this and I can later do a PR adding my changes. ---

[GitHub] tomee issue #305: ApplicationComposerExtension. Problem: When I add junit-ju...

2018-12-24 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/305 Hi @cocorossello, Thanks for the PR. Which excludes are being ignored? Tests in particular or the maven dependency exclude you are adding in the pom.xml? ---

[GitHub] tomee pull request #289: [Work in Progress] TOMEE-2301 Concurrency utilities...

2018-12-17 Thread brunobat
GitHub user brunobat opened a pull request: https://github.com/apache/tomee/pull/289 [Work in Progress] TOMEE-2301 Concurrency utilities example This is the second part of the example. Adding a thread factory. Will improve the example by using countdown latch. You can merge

[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/210#discussion_r242252858 --- Diff: examples/mp-rest-client/src/test/java/org/superbiz/rest/BookResourceTest.java --- @@ -0,0 +1,60 @@ +package org.superbiz.rest; --- End

[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/210#discussion_r242252654 --- Diff: examples/mp-rest-client/src/main/java/org/superbiz/rest/BookBean.java --- @@ -0,0 +1,43 @@ +package org.superbiz.rest; --- End diff

[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/210#discussion_r242252818 --- Diff: examples/mp-rest-client/src/test/java/org/superbiz/rest/BookResourceClient.java --- @@ -0,0 +1,40 @@ +package org.superbiz.rest; --- End

[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/210#discussion_r242252727 --- Diff: examples/mp-rest-client/src/main/java/org/superbiz/rest/BookResource.java --- @@ -0,0 +1,54 @@ +package org.superbiz.rest; --- End diff

[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/210#discussion_r242252435 --- Diff: examples/mp-rest-client/src/main/java/org/superbiz/rest/ApplicationConfig.java --- @@ -0,0 +1,9 @@ +package org.superbiz.rest; --- End

[GitHub] tomee pull request #210: TOMEE-2297 - Added mp-rest-client example maven pro...

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/210#discussion_r242252591 --- Diff: examples/mp-rest-client/src/main/java/org/superbiz/rest/Book.java --- @@ -0,0 +1,33 @@ +package org.superbiz.rest; --- End diff

[GitHub] tomee issue #283: Tomee 2330 backport 7 0

2018-12-17 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/283 The full build has some **unrelated** tests failing: MaxSizePoolEndpointHandlerTest.shouldSendMessage:109 expected:<30> but was:<1> AutoConnectionTrackerTest.test:207 expected:&l

[GitHub] tomee issue #285: Tomee 2330 backport 7.0.x

2018-12-17 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/285 Will do a full build. ---

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/283#discussion_r242121288 --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/MyLocalObject.java

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/283#discussion_r242121452 --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/CmpServlet.java

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/283#discussion_r242121418 --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/MyCmpBean.java

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/283#discussion_r242120895 --- Diff: container/openejb-core/src/test/java/org/apache/openejb/core/webservices/JPACMDIntegrationTest.java --- @@ -0,0 +1,325 @@ +package

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/283#discussion_r242121386 --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/MyLocalHome.java

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/283#discussion_r242121257 --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/MyRemoteHome.java

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

2018-12-17 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/283#discussion_r242121229 --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/MyRemoteObject.java

[GitHub] tomee issue #283: Tomee 2330 backport 7 0

2018-12-17 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/283 I'm running a full build with Java 7 ---

[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project

2018-12-17 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/210 @cesarhernandezgt can you please fix the conflict? I'd like to review your PR. ---

[GitHub] tomee pull request #268: [Work in Progress] TOMEE-2176 - Arquillian test can...

2018-12-11 Thread brunobat
GitHub user brunobat opened a pull request: https://github.com/apache/tomee/pull/268 [Work in Progress] TOMEE-2176 - Arquillian test cannot be run in parallel You can merge this pull request into a Git repository by running: $ git pull https://github.com/brunobat/tomee fix

[GitHub] tomee issue #263: Add Metrics Histogram example in folder examples/mp-metric...

2018-12-10 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/263 Hi @mpredli01, You can delete those files on your local branch and push the changes. That should be enough. Cheers! ---

[GitHub] tomee pull request #220: TOMEE-2292 - Config Microprofile Example

2018-12-10 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/220#discussion_r240168601 --- Diff: examples/mp-config-example/pom.xml --- @@ -0,0 +1,72 @@ + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w

[GitHub] tomee pull request #263: Add Metrics Histogram example in folder examples/mp...

2018-12-10 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/263#discussion_r240161136 --- Diff: examples/mp-metrics-histogram/pom.xml --- @@ -0,0 +1,87 @@ + + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="

[GitHub] tomee pull request #263: Add Metrics Histogram example in folder examples/mp...

2018-12-10 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/263#discussion_r240161751 --- Diff: examples/mp-opentracing-traced/pom.xml --- @@ -0,0 +1,88 @@ + --- End diff -- Is this file really needed? It seems to be related

[GitHub] tomee pull request #263: Add Metrics Histogram example in folder examples/mp...

2018-12-10 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/263#discussion_r240161377 --- Diff: examples/mp-metrics-histogram/url-output.txt --- @@ -0,0 +1,164 @@ +Last login: Tue Dec 4 18:42:11 on ttys001 --- End diff

[GitHub] tomee pull request #263: Add Metrics Histogram example in folder examples/mp...

2018-12-10 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/263#discussion_r240162023 --- Diff: examples/mp-opentracing-traced/src/test/resources/arquillian.xml --- @@ -0,0 +1,30 @@ + --- End diff -- Is this file really

[GitHub] tomee pull request #259: TOMEE-2328 - Cleanup examples maven structure

2018-12-07 Thread brunobat
GitHub user brunobat opened a pull request: https://github.com/apache/tomee/pull/259 TOMEE-2328 - Cleanup examples maven structure @ivanjunckes please take a look at this one because I changed the pom of some metrics examples. You can merge this pull request into a Git

[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

2018-12-06 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/257#discussion_r239482358 --- Diff: examples/README.adoc --- @@ -0,0 +1,21 @@ += TomEE Examples + +These examples demonstrate particular features of the JEE ecosystem

[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

2018-12-06 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/257#discussion_r239482263 --- Diff: examples/README.adoc --- @@ -0,0 +1,21 @@ += TomEE Examples + +These examples demonstrate particular features of the JEE ecosystem

[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

2018-12-06 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/257#discussion_r239482157 --- Diff: examples/README.adoc --- @@ -0,0 +1,21 @@ += TomEE Examples + +These examples demonstrate particular features of the JEE ecosystem

[GitHub] tomee pull request #240: TOMEE-2291 - Fault Tolerance Microprofile example f...

2018-12-05 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/240#discussion_r239263340 --- Diff: examples/mp-faulttolerance-retry/src/main/java/org/superbiz/rest/WeatherGateway.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache

[GitHub] tomee pull request #240: TOMEE-2291 - Fault Tolerance Microprofile example f...

2018-12-05 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/240#discussion_r239263289 --- Diff: examples/mp-faulttolerance-retry/pom.xml --- @@ -0,0 +1,69 @@ + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://w

[GitHub] tomee issue #240: TOMEE-2291 - Fault Tolerance Microprofile example for @Ret...

2018-12-05 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/240 Hi @josehenriqueventura you have a conflict. Please rebase your branch with the latest master. ---

[GitHub] tomee pull request #240: TOMEE-2291 - Fault Tolerance Microprofile example f...

2018-12-05 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/240#discussion_r239194657 --- Diff: examples/mp-faulttolerance-retry/src/main/java/org/superbiz/rest/WeatherGatewayBusyServiceException.java --- @@ -0,0 +1,22

[GitHub] tomee pull request #240: TOMEE-2291 - Fault Tolerance Microprofile example f...

2018-12-05 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/240#discussion_r239190370 --- Diff: examples/mp-faulttolerance-retry/src/main/java/org/superbiz/rest/WeatherGateway.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache

[GitHub] tomee pull request #240: TOMEE-2291 - Fault Tolerance Microprofile example f...

2018-12-05 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/240#discussion_r239174458 --- Diff: examples/mp-faulttolerance-retry/pom.xml --- @@ -0,0 +1,69 @@ + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://w

[GitHub] tomee issue #235: Improve performance using Collections in TomEE container

2018-12-05 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/235 ![image](https://user-images.githubusercontent.com/2318030/49528236-7fade900-f8ab-11e8-9e9f-48d5c1664bc3.png) Looks ok ---

[GitHub] tomee issue #235: Improve performance using Collections in TomEE container

2018-12-05 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/235 will do ---

[GitHub] tomee issue #235: Improve performance using Collections in TomEE container

2018-12-04 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/235 Well... The build failed on the Container Core project, but it was a transient. The build is unstable right now ---

[GitHub] tomee issue #223: TOMEE-2301 - Concurrency utilities example

2018-12-04 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/223 Hi @jeanouii I'm still working on some additional examples. Will send an email to the list when ready. ---

[GitHub] tomee pull request #223: TOMEE-2301 - Concurrency utilities example

2018-12-03 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/223#discussion_r238332043 --- Diff: examples/concurrency-utils/pom.xml --- @@ -0,0 +1,68 @@ + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w

[GitHub] tomee pull request #223: TOMEE-2301 - Concurrency utilities example

2018-11-30 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/223#discussion_r237940616 --- Diff: examples/concurrency-utils/pom.xml --- @@ -0,0 +1,68 @@ + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w

[GitHub] tomee pull request #223: TOMEE-2301 - Concurrency utilities example

2018-11-30 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/223#discussion_r237937619 --- Diff: examples/concurrency-utils/src/main/java/org/superbiz/executor/ManagedService.java --- @@ -0,0 +1,89 @@ +package org.superbiz.executor

[GitHub] tomee issue #223: TOMEE-2301 - Concurrency utilities example

2018-11-30 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/223 This is still a work in progress ---

[GitHub] tomee pull request #223: TOMEE-2301 - Concurrency utilities example

2018-11-30 Thread brunobat
GitHub user brunobat opened a pull request: https://github.com/apache/tomee/pull/223 TOMEE-2301 - Concurrency utilities example You can merge this pull request into a Git repository by running: $ git pull https://github.com/brunobat/tomee executor-example Alternatively you

[GitHub] tomee issue #214: TOMEE-2283 - Websocket tls basic auth example

2018-11-29 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/214 Resolved conflict and edited some commits with the wrong jira id ---

[GitHub] tomee issue #214: TOMEE-2283 - Websocket tls basic auth example

2018-11-26 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/214 Hi @rmannibucau , Thanks for your comments. I've performed the following changes: * I've removed the NOTICE/LICENSE files. * Added missing headers to a few files. * I updated

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236229984 --- Diff: pom.xml --- @@ -208,7 +208,7 @@ 1.0 1.0.0 1.1 - 1.0.0 + 1.0.1-SNAPSHOT --- End diff -- Hi

[GitHub] tomee pull request #214: TOMEE-2283 - Websocket tls basic auth example

2018-11-21 Thread brunobat
GitHub user brunobat opened a pull request: https://github.com/apache/tomee/pull/214 TOMEE-2283 - Websocket tls basic auth example This is still a work in progress. You can merge this pull request into a Git repository by running: $ git pull https://github.com/brunobat/tomee

[GitHub] tomee issue #201: TOMEE-2278 - Use Managed Executor with Safeguard Fault Tol...

2018-11-21 Thread brunobat
Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/201 This is still not ready. The new Lib code is loaded but the bean override is not happening yet. ---

[GitHub] tomee pull request #201: TOMEE-2278 - Use Managed Executor with Safeguard Fa...

2018-11-19 Thread brunobat
GitHub user brunobat opened a pull request: https://github.com/apache/tomee/pull/201 TOMEE-2278 - Use Managed Executor with Safeguard Fault Tolerance lib Well... when we include the SafeguardInterceptor, Our alternative is not picked up on the test. We still need to figure out

[GitHub] tomee pull request #178: TOMEE-2261 - Make service.bat compatible with JDK11...

2018-10-23 Thread brunobat
GitHub user brunobat opened a pull request: https://github.com/apache/tomee/pull/178 TOMEE-2261 - Make service.bat compatible with JDK11+ Detect java version and act on it. After java 11: - Remove jre references because they are invalid when using the JDK. - Remove