[GitHub] tomee pull request #326: tomee-directory-structure.html formatting additions

2019-01-02 Thread cesarhernandezgt
Github user cesarhernandezgt commented on a diff in the pull request: https://github.com/apache/tomee/pull/326#discussion_r244879966 --- Diff: docs/tomee-directory-structure.adoc --- @@ -17,9 +17,9 @@ CONDITIONS OF ANY KIND, either express or implied. See the License

[GitHub] tomee issue #299: TOMEE-2361 Improve main README file (WIP)

2019-01-02 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/299 👍 to Bruno's updates. ---

[GitHub] tomee issue #299: TOMEE-2361 Improve main README file (WIP)

2018-12-21 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/299 Sure, go ahead. ---

[GitHub] tomee pull request #299: TOMEE-2361 Improve main README file (WIP)

2018-12-20 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/299 TOMEE-2361 Improve main README file (WIP) You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee TOMEE-2361

[GitHub] tomee pull request #295: TOMEE-2405 Migrate MP README's to adoc and create M...

2018-12-19 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/295 TOMEE-2405 Migrate MP README's to adoc and create MP index-group You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee

[GitHub] tomee issue #290: TOMEE-2385 Adding README.md for moviefun-rest example

2018-12-19 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/290 Nice work @joedayz, I successfully review the PR locally. ---

[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project

2018-12-17 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/210 @brunobat thank you for the catch. I just pushed a new commit with the changes. ---

[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project

2018-12-17 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/210 @brunobat , conflict is now fixed. thanks. ---

[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project

2018-12-14 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/210 Since now the current master is using mp rest client 1.1, https://issues.apache.org/jira/browse/TOMEE-2298 is no longer blocking this PR. This PR is ready for review. ---

[GitHub] tomee pull request #275: TOMEE-2357 - Fixed issue and updated test on exampl...

2018-12-14 Thread cesarhernandezgt
Github user cesarhernandezgt commented on a diff in the pull request: https://github.com/apache/tomee/pull/275#discussion_r241796269 --- Diff: mp-jwt/src/main/java/org/apache/tomee/microprofile/jwt/jaxrs/MPJWTSecurityAnnotationsInterceptor.java --- @@ -39,14 +39,19 @@ public void

[GitHub] tomee pull request #275: TOMEE-2357 - Fixed issue and updated test on exampl...

2018-12-13 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/275 TOMEE-2357 - Fixed issue and updated test on example application. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt

[GitHub] tomee pull request #273: Added index information to mp examples readme files...

2018-12-12 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/273 Added index information to mp examples readme files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee minor-fixes

[GitHub] tomee issue #233: TOMEE-2304 Improving MP-REST-JWT example (WIP)

2018-12-10 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/233 Hi @radcortez , I fixed the conflict. This PR is still a WIP. ---

[GitHub] tomee-site-generator pull request #11: TOMEE-2317 - Added contribution tips ...

2018-12-04 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee-site-generator/pull/11 TOMEE-2317 - Added contribution tips and create link for existing sources page. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] tomee issue #238: [IMPROVEMENT] TOMEE-2313 - Fixed surefire and openjpa vers...

2018-12-04 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/238 nice work @danielsoro , do you think `maven-surefire-plugin` would also need this improvement? ---

[GitHub] tomee issue #204: fixed cdi-basic-typos

2018-12-04 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/204 @jeanouii The conflict was fixed. Please move forward this PR. ---

[GitHub] tomee issue #209: mp-metrics-counted fixed a couple of typos

2018-12-04 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/209 @jeanouii Conflict was fixed. Plase proceed with the merge. ---

[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project

2018-12-04 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/210 Hi, @jeanouii This PR can't be merged now, we need a new cxf release to execute first: https://issues.apache.org/jira/browse/TOMEE-2298 and only after we can merge this PR. I

[GitHub] tomee issue #232: TOMEE-2313 - fixing tomee-webapp archetype.

2018-12-04 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/232 @jeanouii , please proceed with the merge of this ticket. I'm going to create another one with the improved version so we can move forward. ---

[GitHub] tomee pull request #233: TOMEE-2304 Improving MP-REST-JWT example (WIP)

2018-12-03 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/233 TOMEE-2304 Improving MP-REST-JWT example (WIP) You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee TOMEE-2304

[GitHub] tomee issue #232: TOMEE-2313 - fixing tomee-webapp archetype.

2018-12-03 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/232 Thank you @danielsoro for the awesome approach. Tomorrow I'll update my PR with this improvement. ---

[GitHub] tomee pull request #232: TOMEE-2313 - fixing tomee-webapp archetype.

2018-12-03 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/232 TOMEE-2313 - fixing tomee-webapp archetype. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee TOMEE-2313

[GitHub] tomee pull request #223: TOMEE-2301 - Concurrency utilities example

2018-11-30 Thread cesarhernandezgt
Github user cesarhernandezgt commented on a diff in the pull request: https://github.com/apache/tomee/pull/223#discussion_r237923742 --- Diff: examples/concurrency-utils/pom.xml --- @@ -0,0 +1,68 @@ + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="

[GitHub] tomee pull request #223: TOMEE-2301 - Concurrency utilities example

2018-11-30 Thread cesarhernandezgt
Github user cesarhernandezgt commented on a diff in the pull request: https://github.com/apache/tomee/pull/223#discussion_r237923335 --- Diff: examples/concurrency-utils/src/main/java/org/superbiz/executor/ManagedService.java --- @@ -0,0 +1,89 @@ +package

[GitHub] tomee-site-generator pull request #6: TOMEE-2300 - Improvement for Community...

2018-11-29 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee-site-generator/pull/6 TOMEE-2300 - Improvement for Community section from the website You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] tomee pull request #210: WIP - Added basic structure for mp-rest-client exam...

2018-11-20 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/210 WIP - Added basic structure for mp-rest-client example maven project You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt

[GitHub] tomee pull request #209: mp-metrics-counted fixed a couple of typos

2018-11-20 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/209 mp-metrics-counted fixed a couple of typos You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee mp-metrics-counted

[GitHub] tomee pull request #205: added ignore folder from vscode.

2018-11-19 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/205 added ignore folder from vscode. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee gitignore-for-vscode

[GitHub] tomee pull request #204: fixed cdi-basic-typos

2018-11-19 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/204 fixed cdi-basic-typos You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee cdi-basic-spelling-review Alternatively