[GitHub] tomee issue #287: Fix test for TomEECliIT

2019-01-02 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/287 @radcortez That is really weird, I can't reproduce the error here. Can you run it in the buildbot to see the results? ---

[GitHub] tomee pull request #292: TOMEE-2276 - Update TomEE with Johnzon 1.0.2

2018-12-18 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/292 TOMEE-2276 - Update TomEE with Johnzon 1.0.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee patch-1 Alternatively you can

[GitHub] tomee pull request #291: TOMEE-2276 - Update TomEE with Johnzon 1.0.2

2018-12-18 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/291 TOMEE-2276 - Update TomEE with Johnzon 1.0.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee johnzon-update-tomee-7.0.x

[GitHub] tomee pull request #288: Fix test for TomEECliIT

2018-12-17 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/288 Fix test for TomEECliIT You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee master-fix-tests-tomee-cli Alternatively you can

[GitHub] tomee pull request #287: Fix test for TomEECliIT

2018-12-17 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/287 Fix test for TomEECliIT You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee tomeE-7.1.x-fix-tests Alternatively you can review

[GitHub] tomee pull request #286: Fix test for TomEECliIT

2018-12-17 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/286 Fix test for TomEECliIT You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee tomeE-7.0.x-fix-test Alternatively you can review

[GitHub] tomee pull request #267: Update bval for 2.0.1-SNAPSHOT

2018-12-10 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/267 Update bval for 2.0.1-SNAPSHOT You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee bva-update Alternatively you can review and

[GitHub] tomee issue #238: [IMPROVEMENT] TOMEE-2313 - Fixed surefire and openjpa vers...

2018-12-04 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/238 @cesarhernandezgt, well.. I believe which we don't need to have it sync with version used on TomEE. Just the others make sense. It will depends of the maven version that user are using

[GitHub] tomee pull request #238: [IMPROVEMENT] TOMEE-2313 - Fixed surefire and openj...

2018-12-04 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/238 [IMPROVEMENT] TOMEE-2313 - Fixed surefire and openjpa versions on webapp archetype … …resource pom Fixed OPENJB replace and add improvement to dependencies version for OPENJPA and

[GitHub] tomee pull request #237: [BACKPORT 7.1.x] TOMEE-2253 - tomee.sh -version not...

2018-12-04 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/237 [BACKPORT 7.1.x] TOMEE-2253 - tomee.sh -version not working properly with Java 11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro

[GitHub] tomee pull request #236: [BACKPORT 7.0.x] TOMEE-2253 - tomee.sh -version not...

2018-12-04 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/236 [BACKPORT 7.0.x] TOMEE-2253 - tomee.sh -version not working properly with Java 11 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-12-04 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 Hey @jeanouii, I've push a update for it Just need the review. ---

[GitHub] tomee issue #232: TOMEE-2313 - fixing tomee-webapp archetype.

2018-12-03 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/232 Hey @cesarhernandezgt, What do you think to use that approach: https://github.com/apache/tomee/blob/master/maven/tomee-webapp-archetype/pom.xml#L45 Than you can use the

[GitHub] tomee pull request #229: Upgrade johnzon for 1.1.10

2018-12-03 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/229 Upgrade johnzon for 1.1.10 You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee johnzon-update Alternatively you can review and

[GitHub] tomee pull request #220: [WIP] TOMEE-2292 - Config Microprofile Example

2018-11-26 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/220 [WIP] TOMEE-2292 - Config Microprofile Example You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee mp-config-sample

[GitHub] tomee pull request #219: Avoid String in a loop

2018-11-26 Thread danielsoro
Github user danielsoro commented on a diff in the pull request: https://github.com/apache/tomee/pull/219#discussion_r236279011 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java --- @@ -2939,12 +2939,14 @@ public EjbModule deploy

[GitHub] tomee issue #201: TOMEE-2278 - Use Managed Executor with Safeguard Fault Tol...

2018-11-23 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/201 +1 ---

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-29 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 btw, it is what we already doing on tomee.sh: `"$_RUNJAVA" $DEBUG $LOGGING_MANAGER -Dopenejb.base="$CATALINA_BASE" -cp "$CLASSPATH" org.apache.openejb.cli.B

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-29 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 Well.. it is calling inside a try-statement, I believe which the close will be called in the end of the program or when some exception occur: https://github.com/apache/tomee/pull/176/files#diff

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-24 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 @rmannibucau I get it, but we isolate it just for the CLI. What is the scenario which you are seeing which can break something with that change? It should not have any impact on the

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-24 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 @rmannibucau, Yeah, I'm closing it before, going to fix it. I didn't get your question about j8's user, but it should not have an impact on j8's user. ---

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-23 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 Ok @rmannibucau, sent the correct patch, let me know what do you think. Thank you! ---

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-23 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 Ohh.. sorry I sent the wrong patch. Pushing the correct one. ---

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-23 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 Hi @rmannibucau, patch updated. It seems to look better now. Please, review it and thank you for all the help, I really appreciate it. ---

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-23 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 @rmannibucau, Nice.. working on it. Thank you! :) ---

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-23 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 @rmannibucau, TomEE is not showing any exception when running with j11 (I was able to start and deploy a simple application on it really fine), that is not the issue. It just

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-23 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 Hey @rmannibucau, I updated it to call `close` and also now we call the ClassLoader.registerAsParallelCapable(); in a static block. hashcode and equals still using the super, the

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-10 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 @rmannibucau hmm.. my question is: If we need to call close, why are not we doing it when using CustomizableURLClassLoader? is it means which we need to do the same for CustomizableURLClassLoader? ---

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-10 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 @rmannibucau What do you want mean: should likely be closed? ---

[GitHub] tomee pull request #176: TOMEE-2253 - tomee.sh -version not working properly...

2018-10-09 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/176 TOMEE-2253 - tomee.sh -version not working properly with Java 11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee tomee-2253

[GitHub] tomee pull request #102: TOMEE-2109 - Default Resource should always be load...

2017-08-07 Thread danielsoro
Github user danielsoro closed the pull request at: https://github.com/apache/tomee/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] tomee pull request #103: TOMEE-2110 - DefaultContextService missing like def...

2017-08-06 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/103 TOMEE-2110 - DefaultContextService missing like default resource. You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee TOMEE-2110

[GitHub] tomee pull request #102: TOMEE-2109 - Default Resource should always be load...

2017-08-06 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/102 TOMEE-2109 - Default Resource should always be loaded by default You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee TOMEE-2109

[GitHub] tomee pull request #101: TOMEE-2107 - Upgrade CXF

2017-08-04 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/101 TOMEE-2107 - Upgrade CXF You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee TOMEE-2107 Alternatively you can review and apply

[GitHub] tomee pull request #100: TOMEE-2105 - Upgrade Eclipselink

2017-08-03 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/100 TOMEE-2105 - Upgrade Eclipselink You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee eclipselink-update Alternatively you can