[GitHub] tomee issue #337: Added new example cdi qualifier

2018-12-31 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/337 Thanks for the PR! ---

[GitHub] tomee issue #338: Use correct line separator when checking call result.

2018-12-31 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/338 That's awesome, thank you! ---

[GitHub] tomee pull request #336: TOMEE-2436 Get code coverage report from JaCoCo

2018-12-31 Thread jgallimore
GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/336 TOMEE-2436 Get code coverage report from JaCoCo This starts this task off, introducing the plugin at the root level under pluginManagement, and using it in a `coverage` profile on openejb-core

[GitHub] tomee issue #332: (TOMEE-2435) Simplify the Code in org.apache.openejb.OpenE...

2018-12-31 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/332 Happy for you to do that, but your last push to this branch looked fine to merge. ---

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

2018-12-31 Thread jgallimore
Github user jgallimore commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244586465 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -71,57 +50,74 @@ import

[GitHub] tomee issue #301: Fixes TOMEE-2261 Make service.bat compatible with JDK11+

2018-12-21 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/301 I've merged this in, many thanks for the PR! ---

[GitHub] tomee issue #301: Fixes TOMEE-2261 Make service.bat compatible with JDK11+

2018-12-21 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/301 Thanks for this. I'll give it a quick test and we'll merge it in. ---

[GitHub] tomee issue #294: Defining category

2018-12-19 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/294 Thank you for the PR! ---

[GitHub] tomee pull request #293: WIP - experimentation with Java 11

2018-12-19 Thread jgallimore
GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/293 WIP - experimentation with Java 11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jgallimore/tomee java11-experimentation Alternatively you

[GitHub] tomee issue #60: amq and ibm mq portability using tomee

2018-12-12 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/60 @suyogbarve Thank you for putting this together, it looks great. I have a couple of points for feedback: * Can you add the ASL header to your source files? * Can ChatBean and

[GitHub] tomee issue #60: amq and ibm mq portability using tomee

2018-12-12 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/60 Yes, I'll get that done today. Thanks for the nudge. ---

[GitHub] tomee pull request #272: TOMEE-2234 - WIP

2018-12-12 Thread jgallimore
GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/272 TOMEE-2234 - WIP This PR introduces Arquillian tests for BMP finder methods, and addresses an issue when there are more than 256 handles in the stack. The root issue is that when proxies are

[GitHub] tomee pull request #266: TOMEE-2330 fix issue with incorrect base URL for ge...

2018-12-10 Thread jgallimore
GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/266 TOMEE-2330 fix issue with incorrect base URL for generated persistenc… …e units This uses the full path for the module as opposed to just the module ID. The doesn't seem to a

[GitHub] tomee pull request #258: TOMEE-2232

2018-12-06 Thread jgallimore
GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/258 TOMEE-2232 These changes should resolve the itest failures, but Daniel's new additional tests still pass. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] tomee pull request #239: TOMEE-2321-exemple-mvc-cxf

2018-12-05 Thread jgallimore
Github user jgallimore commented on a diff in the pull request: https://github.com/apache/tomee/pull/239#discussion_r239267154 --- Diff: examples/mvc-cxf/src/main/resources/META-INF/persistence.xml --- @@ -0,0 +1,22 @@ + +http://java.sun.com/xml/ns/persistence

[GitHub] tomee issue #239: TOMEE-2321-exemple-mvc-cxf

2018-12-05 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/239 I'm just looking through this now. Thanks for the contribution @Daniel-Dos !! Could you add the ASL headers to the new files? ---

[GitHub] tomee issue #227: TOMEE-2233 - Custom Configuration of TomEEJsonbProvider

2018-12-03 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/227 Awesome, thanks for the PR! I'll pull this, and get it merged for you. ---

[GitHub] tomee pull request #222: TOMEE-2295 fix being ignored

2018-11-29 Thread jgallimore
GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/222 TOMEE-2295 fix being ignored This is still a work in progress as I'd like to incorporate some Arquillian tests today, and ensure that this works with things like relationships between ent

[GitHub] tomee pull request #113: Investigate issues with connectors in EAR and WAR f...

2018-11-27 Thread jgallimore
Github user jgallimore closed the pull request at: https://github.com/apache/tomee/pull/113 ---

[GitHub] tomee pull request #112: Investigate issues with connectors in EAR and WAR f...

2018-11-27 Thread jgallimore
Github user jgallimore closed the pull request at: https://github.com/apache/tomee/pull/112 ---

[GitHub] tomee pull request #199: Hacking around with loading CMP modules

2018-11-16 Thread jgallimore
GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/199 Hacking around with loading CMP modules This is not intended for merge but collaboration and discussion. This PR adds a simple test to `LegacyInterfaceTest` to ensure that user-provided mappings

[GitHub] tomee pull request #176: TOMEE-2253 - tomee.sh -version not working properly...

2018-10-29 Thread jgallimore
Github user jgallimore commented on a diff in the pull request: https://github.com/apache/tomee/pull/176#discussion_r228923707 --- Diff: tomee/apache-tomee/src/test/java/org/apache/tomee/TomEECliIT.java --- @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee pull request #176: TOMEE-2253 - tomee.sh -version not working properly...

2018-10-29 Thread jgallimore
Github user jgallimore commented on a diff in the pull request: https://github.com/apache/tomee/pull/176#discussion_r228923550 --- Diff: tomee/apache-tomee/src/test/java/org/apache/tomee/TomEECliIT.java --- @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee pull request #176: TOMEE-2253 - tomee.sh -version not working properly...

2018-10-29 Thread jgallimore
Github user jgallimore commented on a diff in the pull request: https://github.com/apache/tomee/pull/176#discussion_r228922983 --- Diff: tomee/apache-tomee/src/test/java/org/apache/tomee/TomEECliIT.java --- @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-29 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/176 I think adding the test anyway is a good call. ---

[GitHub] tomee-site-generator pull request #5: Provide TomEE 8.0.0-M1 download

2018-10-18 Thread jgallimore
GitHub user jgallimore opened a pull request: https://github.com/apache/tomee-site-generator/pull/5 Provide TomEE 8.0.0-M1 download You can merge this pull request into a Git repository by running: $ git pull https://github.com/jgallimore/tomee-site-generator master

[GitHub] tomee pull request #174: Track abandoned connection proxies in the transacti...

2018-10-10 Thread jgallimore
Github user jgallimore closed the pull request at: https://github.com/apache/tomee/pull/174 ---

[GitHub] tomee pull request #174: Allow proxy to be disabled

2018-09-28 Thread jgallimore
GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/174 Allow proxy to be disabled You can merge this pull request into a Git repository by running: $ git pull https://github.com/jgallimore/tomee proxy-disable-master Alternatively you can

[GitHub] tomee issue #166: Apply Jonathan Gallimore's JMX Patch to 7.0.5

2018-09-27 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/166 @exabrial - fixed here: https://github.com/apache/tomee/commit/e1853b10c52f72c7e9dd43c049098d7f69a43a49 thanks for the report! ---

[GitHub] tomee pull request #99: Forward port changes to allow allow classes with no-...

2017-08-02 Thread jgallimore
GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/99 Forward port changes to allow allow classes with no-arg constructors to be sub-classes You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] tomee pull request #96: TOMEE-2100 add @Priority to default sorting

2017-08-02 Thread jgallimore
Github user jgallimore closed the pull request at: https://github.com/apache/tomee/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] tomee pull request #96: TOMEE-2100 add @Priority to default sorting

2017-07-27 Thread jgallimore
GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/96 TOMEE-2100 add @Priority to default sorting This creates a default comparator when no setting for cxf.jaxrs.provider-comparator is specified. This will order by priority first, but will still

Re: Adds an option to ignore mdb.activation fields

2017-07-12 Thread jgallimore
Hi Otavio, Can you give us a bit of a description about the change, and maybe a sample config? Just so everyone has some context on the change? At first glance, I'd say your testing is missing at least a scenario where the container activation properties (mdb.container.[containerID].activation.[p

[GitHub] tomee issue #55: backport cipher change from tomee 7

2017-01-06 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/55 This is for https://issues.apache.org/jira/browse/TOMEE-1995. Many thanks for the fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as