Github user rmannibucau commented on a diff in the pull request:
https://github.com/apache/tomee/pull/218#discussion_r236342694
--- Diff: examples/mp-metrics-timed/pom.xml ---
@@ -0,0 +1,71 @@
+
--- End diff --
header ;)
---
Github user rmannibucau commented on a diff in the pull request:
https://github.com/apache/tomee/pull/218#discussion_r236342580
--- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java
---
@@ -157,7 +159,10 @@ private void assertJsonFormat(final String metricPath
Github user rmannibucau commented on a diff in the pull request:
https://github.com/apache/tomee/pull/218#discussion_r236314041
--- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java
---
@@ -0,0 +1,151 @@
+/**
+ * Licensed to the Apache Software
Github user rmannibucau commented on a diff in the pull request:
https://github.com/apache/tomee/pull/218#discussion_r236249672
--- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java
---
@@ -0,0 +1,151 @@
+/**
+ * Licensed to the Apache Software
Github user rmannibucau commented on a diff in the pull request:
https://github.com/apache/tomee/pull/218#discussion_r236248226
--- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java
---
@@ -0,0 +1,151 @@
+/**
+ * Licensed to the Apache Software
Github user rmannibucau commented on a diff in the pull request:
https://github.com/apache/tomee/pull/218#discussion_r236248396
--- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java
---
@@ -0,0 +1,151 @@
+/**
+ * Licensed to the Apache Software
Github user rmannibucau commented on a diff in the pull request:
https://github.com/apache/tomee/pull/218#discussion_r236248868
--- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java
---
@@ -0,0 +1,151 @@
+/**
+ * Licensed to the Apache Software
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/180
@gsmet updated master to pass the tck with bval 2.0.1-SNAPSHOT, do you care
rebasing your PR and checking it works for you?
---
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
Thnking to users having a java -cp command launching Cli (we have a few).
Side note: i think you still close the classloader before it is finished to
be used - after cli execution pby
---
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
@danielsoro if you change the classloader it can impact the users relying
on that (it can be the case if they tune java or use system classloader only
libs. This is rare but already saw it. This
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
Hmm, you close the classloader before it is used so it is no more usable
normally - or it will leak.
Side question: any issue having an impl os ClassPath using the classloader
to keep
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
Hope i didnt misread the diff (starts to be late ;)) but it misses a close
and the urlclassloader cast will not work on all java versions right?
---
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
Yes, this is what i had in mind as well. That said if it is just for our
CLI your hack is fine, we should just lock it for other cases like
openejb-standalone
---
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
well some thoughts:
1. most of the time we dont need this dynamism so maybe we can just rework
the distro and delete it
2. we already hack equals/hashcode in cxf container loader but
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
Java 6 didnt have that method but we should close all our classloaders once
yes.
---
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
@danielsoro classloader.close() must be called to not leak and enable to
read files after the end of the container.
---
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/175
Ok so let's merge it.
On the fail point we must not start if we are broken so let's drop it also
;)
---
Github user rmannibucau commented on a diff in the pull request:
https://github.com/apache/tomee/pull/175#discussion_r223478552
--- Diff:
container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/OpenEJBServerPlatform.java
---
@@ -26,13 +27,14
Github user rmannibucau commented on a diff in the pull request:
https://github.com/apache/tomee/pull/175#discussion_r223478337
--- Diff:
container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/MBeanOpenEJBRuntimeServices.java
---
@@ -0,0
Github user rmannibucau commented on a diff in the pull request:
https://github.com/apache/tomee/pull/175#discussion_r221449894
--- Diff:
container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/OpenEJBServerPlatform.java
---
@@ -63,4 +65,11
Github user rmannibucau commented on a diff in the pull request:
https://github.com/apache/tomee/pull/175#discussion_r221449834
--- Diff:
container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/MBeanOpenEJBRuntimeServices.java
---
@@ -0,0
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/171
No issue, thanks for taking time to PR and recheck it.
---
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/171
Isnt 5s too small?
Also, dont forget to add new params to service-jar.xml in openejb-core.
Otherwise looks good!
---
23 matches
Mail list logo
