[GitHub] tomee pull request #298: [BACKPORT 7.0.x] TOMEE-2363 Introduces OWASP depend...

2018-12-20 Thread rzo1
GitHub user rzo1 opened a pull request: https://github.com/apache/tomee/pull/298 [BACKPORT 7.0.x] TOMEE-2363 Introduces OWASP dependency check via profile Backport of TOMEE-2363, see #276 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] tomee pull request #297: [BACKPORT 7.1.x] TOMEE-2363 Introduces OWASP depend...

2018-12-20 Thread rzo1
GitHub user rzo1 opened a pull request: https://github.com/apache/tomee/pull/297 [BACKPORT 7.1.x] TOMEE-2363 Introduces OWASP dependency check via profile Backport of TOMEE-2363, see https://github.com/apache/tomee/pull/276 You can merge this pull request into a Git repository by

[GitHub] tomee issue #276: TOMEE-2363 Introduces OWASP dependency check via profile

2018-12-20 Thread rzo1
Github user rzo1 commented on the issue: https://github.com/apache/tomee/pull/276 Thanks for merging this in. Can anyone add the profile on the CI system? I will start to backport the changes now. ---

[GitHub] tomee issue #276: TOMEE-2363 Introduces OWASP dependency check via profile

2018-12-18 Thread rzo1
Github user rzo1 commented on the issue: https://github.com/apache/tomee/pull/276 I adjusted the PR to my comments above. Feel free to give any other suggestions. If we introduce this, I would recommend to add `owasp-check` to the CI system. Who can do this? The CVE

[GitHub] tomee issue #276: TOMEE-2363 Introduces OWASP dependency check via profile

2018-12-17 Thread rzo1
Github user rzo1 commented on the issue: https://github.com/apache/tomee/pull/276 Hey @jeanouii & @radcortez thanks for the feedback - I can update this PR. I would propose: - (1) I will add a profile `owasp-report` to generate the aggregated HTML re

[GitHub] tomee pull request #276: TOMEE-2363 Introduces OWASP dependency check via pr...

2018-12-14 Thread rzo1
GitHub user rzo1 opened a pull request: https://github.com/apache/tomee/pull/276 TOMEE-2363 Introduces OWASP dependency check via profile This PR introduces the [OWASP Dependency Check Maven Plugin](https://jeremylong.github.io/DependencyCheck/index.html) in a basic configuration

[GitHub] tomee issue #169: TOMEE-2239 removing the try-catch block

2018-12-07 Thread rzo1
Github user rzo1 commented on the issue: https://github.com/apache/tomee/pull/169 @tveronezi Can you close PR please? According to @radcortez everything was merged. ---

[GitHub] tomee issue #231: TOMEE-2314 - Code cleanup in modules listed in description

2018-12-05 Thread rzo1
Github user rzo1 commented on the issue: https://github.com/apache/tomee/pull/231 Hey @cicekhayri , I added related comments related to JNC. Maybe you can open a new JIRA for improvements and reference it in the next related PR :) - Thank you very much! ---

[GitHub] tomee pull request #231: TOMEE-2314 - Code cleanup in modules listed in desc...

2018-12-05 Thread rzo1
Github user rzo1 commented on a diff in the pull request: https://github.com/apache/tomee/pull/231#discussion_r239105917 --- Diff: tomee/tomee-common/src/main/java/org/apache/tomee/installer/Installer.java --- @@ -32,31 +32,31 @@ private Status status = Status.NONE

[GitHub] tomee pull request #231: TOMEE-2314 - Code cleanup in modules listed in desc...

2018-12-05 Thread rzo1
Github user rzo1 commented on a diff in the pull request: https://github.com/apache/tomee/pull/231#discussion_r239105823 --- Diff: tomee/tomee-common/src/main/java/org/apache/tomee/installer/Installer.java --- @@ -32,31 +32,31 @@ private Status status = Status.NONE

[GitHub] tomee pull request #231: TOMEE-2314 - Code cleanup in modules listed in desc...

2018-12-05 Thread rzo1
Github user rzo1 commented on a diff in the pull request: https://github.com/apache/tomee/pull/231#discussion_r239105687 --- Diff: server/openejb-webservices/src/main/java/org/apache/openejb/server/webservices/saaj/SaajUniverse.java --- @@ -47,7 +47,7 @@ private static void

[GitHub] tomee pull request #231: TOMEE-2314 - Code cleanup in modules listed in desc...

2018-12-05 Thread rzo1
Github user rzo1 commented on a diff in the pull request: https://github.com/apache/tomee/pull/231#discussion_r239105551 --- Diff: server/openejb-webservices/src/main/java/org/apache/openejb/server/webservices/WsServlet.java --- @@ -43,7 +43,7 @@ public static final

[GitHub] tomee pull request #231: TOMEE-2314 - Code cleanup in modules listed in desc...

2018-12-05 Thread rzo1
Github user rzo1 commented on a diff in the pull request: https://github.com/apache/tomee/pull/231#discussion_r239105184 --- Diff: server/openejb-multicast/src/main/java/org/apache/openejb/server/discovery/MulticastDiscoveryAgent.java --- @@ -46,7 +46,7 @@ */ public

[GitHub] tomee issue #231: TOMEE-2314 - Code cleanup in modules listed in description

2018-12-05 Thread rzo1
Github user rzo1 commented on the issue: https://github.com/apache/tomee/pull/231 Hi @cicekhayri thanks for your fast response :) I think, that there are a few more constants following this pattern. Shall I provide feedback, there I think, it could be

[GitHub] tomee issue #231: TOMEE-2314 - Code cleanup in modules listed in description

2018-12-05 Thread rzo1
Github user rzo1 commented on the issue: https://github.com/apache/tomee/pull/231 Hey @cicekhayri I am just curious: To which naming convention are you referring to in your first commit? I thought, that constants consisting of more than one word will be separated

[GitHub] tomee pull request #227: TOMEE-2233 - Custom Configuration of TomEEJsonbProv...

2018-12-03 Thread rzo1
GitHub user rzo1 opened a pull request: https://github.com/apache/tomee/pull/227 TOMEE-2233 - Custom Configuration of TomEEJsonbProvider **Summary** Provides support for custom configuration of `TomEEJsonbProvider` (see https://issues.apache.org/jira/browse/TOMEE-2233) in