[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/218 ---

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-27 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236731537 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236343729 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -157,7 +159,10 @@ private void assertJsonFormat(final String metricPath)

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236343527 --- Diff: examples/mp-metrics-timed/pom.xml --- @@ -0,0 +1,71 @@ + --- End diff -- Done :) Tks ---

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread rmannibucau
Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236342694 --- Diff: examples/mp-metrics-timed/pom.xml --- @@ -0,0 +1,71 @@ + --- End diff -- header ;) ---

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread rmannibucau
Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236342580 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -157,7 +159,10 @@ private void assertJsonFormat(final String metricPath)

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236338450 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236338135 --- Diff: pom.xml --- @@ -208,7 +208,7 @@ 1.0 1.0.0 1.1 - 1.0.0 + 1.0.1-SNAPSHOT --- End diff -- F

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236338075 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236337920 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236337860 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread rmannibucau
Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236314041 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236312514 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread rmannibucau
Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236249672 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread rmannibucau
Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236248226 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread rmannibucau
Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236248396 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread rmannibucau
Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236248868 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

2018-11-26 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236229984 --- Diff: pom.xml --- @@ -208,7 +208,7 @@ 1.0 1.0.0 1.1 - 1.0.0 + 1.0.1-SNAPSHOT --- End diff -- Hi @