Re: [RESULT] Explore creating a reusable JWT Library

2018-04-16 Thread Jean-Louis Monteiro
The PR has been merged. Thanks everyone for voting. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Apr 12, 2018 at 4:25 PM, Romain Manni-Bucau wrote: > why -> for consistency accross our coupled communities > why does it matter if it is in G for T? ->

Re: [RESULT] Explore creating a reusable JWT Library

2018-04-12 Thread Romain Manni-Bucau
why -> for consistency accross our coupled communities why does it matter if it is in G for T? -> it doesn't Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book 2018-04-12 15:56 GMT+02:00 Matthew Broadhead : > we already include libraries from geronimo, e.g. javamail, s

Re: [RESULT] Explore creating a reusable JWT Library

2018-04-12 Thread Matthew Broadhead
we already include libraries from geronimo, e.g. javamail, so why does it matter where the library resides as long as it can be included in the package On 11/04/2018 15:05, Romain Manni-Bucau wrote: Hi Matthew, No, technicall there are a lot of small things to do before it can be "included" b

Re: [RESULT] Explore creating a reusable JWT Library

2018-04-11 Thread Romain Manni-Bucau
Hi Matthew, No, technicall there are a lot of small things to do before it can be "included" but the main blocker for me is that the exact same project is created at geronimo (actually this code was designed to be owned by geronimo and the artifact imported in tomee). Since G will have it I would

Re: [RESULT] Explore creating a reusable JWT Library

2018-04-11 Thread Matthew Broadhead
Hi David, Thanks for the invitation to vote.  I don't want to vote because I am not sure I have enough knowledge to be able to do so. My gut feeling would probably be to side with Mark and Romain as they have been very supportive with my queries about TomEE and they have shown  deep technica

Re: [RESULT] Explore creating a reusable JWT Library

2018-04-10 Thread Romain Manni-Bucau
2018-04-10 9:24 GMT+02:00 Rudy De Busscher : > Sorry Romain but I still have doubts if the code is really reusable, like > that you can just add it to WildFly or Payara and that it works. (like > Geronimo Config for example) It will support the CDI+servlet support OOTB, the PR brings the servlet/E

Re: [RESULT] Explore creating a reusable JWT Library

2018-04-10 Thread Rudy De Busscher
Sorry Romain but I still have doubts if the code is really reusable, like that you can just add it to WildFly or Payara and that it works. (like Geronimo Config for example) Things like integrating with @RolesAllowed is not standardized (except using JASPIC maybe which I tried but I had other issu

Re: [RESULT] Explore creating a reusable JWT Library

2018-04-09 Thread Romain Manni-Bucau
Le 10 avr. 2018 05:23, "David Blevins" a écrit : Officially closing the vote. Thanks for the patience everyone. As mentioned in the other vote, this one needed some good discussion and a bit of extra time. +1s Andy Gumbrecht David Blevins Ivan Junckes Filho Jean-Louis Monteiro Jonathan Gallimo

[RESULT] Explore creating a reusable JWT Library

2018-04-09 Thread David Blevins
Officially closing the vote. Thanks for the patience everyone. As mentioned in the other vote, this one needed some good discussion and a bit of extra time. +1s Andy Gumbrecht David Blevins Ivan Junckes Filho Jean-Louis Monteiro Jonathan Gallimore Thiago Veronezi +0 Rudy De Busscher -1s Mark