rzo1 merged PR #1447:
URL: https://github.com/apache/tomee/pull/1447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
F
dependabot[bot] opened a new pull request, #1447:
URL: https://github.com/apache/tomee/pull/1447
Bumps
[org.apache.maven.plugins:maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin)
from 3.4.0 to 3.5.0.
Commits
https://github.com/apache/maven-checkstyle
rzo1 merged PR #1355:
URL: https://github.com/apache/tomee/pull/1355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
F
dependabot[bot] opened a new pull request, #1355:
URL: https://github.com/apache/tomee/pull/1355
Bumps
[org.apache.maven.plugins:maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin)
from 2.15 to 3.4.0.
Commits
https://github.com/apache/maven-checkstyle
cesarhernandezgt merged pull request #738:
URL: https://github.com/apache/tomee/pull/738
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
cesarhernandezgt merged pull request #737:
URL: https://github.com/apache/tomee/pull/737
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
cesarhernandezgt merged pull request #676:
URL: https://github.com/apache/tomee/pull/676
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jgallimore merged pull request #443: Fixing checkstyle issue
URL: https://github.com/apache/tomee/pull/443
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jgallimore merged pull request #444: Checkstyle fix
URL: https://github.com/apache/tomee/pull/444
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
danielsoro opened a new pull request #443: Fixing checkstyle issue
URL: https://github.com/apache/tomee/pull/443
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Hi folks,
I was wondering why do we have our checkstyle check only for a few modules:
https://github.com/apache/tomee/blob/464efec5d43467ae0861ad7a55ebb665293246f1/pom.xml#L615-L672
<https://github.com/apache/tomee/blob/464efec5d43467ae0861ad7a55ebb665293246f1/pom.xml#L615-L672>
Does
trick to trigger the "checkstyle:check" and
> "pmd:check" goals from any submodule without copying pmd or checkstyle
> configuration rules in every one of the target submodules?
>
> I mean, I want to be able to go to
> "/home/tveronezi/dev/ws/tomee/source/conta
Guys,
Do you know of any maven trick to trigger the "checkstyle:check" and
"pmd:check" goals from any submodule without copying pmd or checkstyle
configuration rules in every one of the target submodules?
I mean, I want to be able to go to
"/home/tveronezi/dev/ws/tomee
Ok guys, no worries.
Consensus, so keeping rules are already defined.
JLouis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Fri, May 23, 2014 at 5:54 AM, Romain Manni-Bucau
wrote:
> @Thiago: the issue I spoke about @Suppress is the code can evolve and it
>
@Thiago: the issue I spoke about @Suppress is the code can evolve and it
can hide some important stuff (saw it a lot with @Suppress(eclipse stuff)
users)
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https
-1 this is really too error prone.
People keep adding lines via patches and voila all your code is broken...
LieGrue,
strub
On Friday, 23 May 2014, 11:19, Jean-Louis Monteiro
wrote:
>
>
>Hey guys,
>
>Is it possible to restore the ability to have inline if?
>I like them cause I think it's
y boring; and I find that boring code is far more beautiful,
truly, than spaces vs tabs or if { vs if\n{ or any other code beauty
type of debates.
+1 (non-binding): Keep as is.
On Fri, May 23, 2014 at 8:21 AM, Thiago Veronezi wrote:
> I see the checkstyle and pmd as robots that help us to
-1
Don't like brace-less code ever, and much prefer:
if (null != bla) { do stuff }
Andy.
On 23/05/2014 14:21, Thiago Veronezi wrote:
I see the checkstyle and pmd as robots that help us to write core easily
readable by others. These are dummy robots with no "common sense". W
I see the checkstyle and pmd as robots that help us to write core easily
readable by others. These are dummy robots with no "common sense". We can
also help them to understand when a rule is not applicable to certain parts
of our code. Going around rules should not be common place, ot
or do nothing (hehe)
BTW I'd never use @SuppressXXX since when code is touched it is not
mantained for sure and then if we use so we shouldn't have rules ;).
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github:
Good morning!
I think we have two options:
* change the rule for 'NeedBraces' (
http://checkstyle.sourceforge.net/config_blocks.html)
* add @SuppressWarnings("checkstyle:needbraces") when needed.
I've just committed a "@SuppressWarnings" example.
[]s,
Thiago.
On Fri, May 23, 2014 at 5:25 AM,
Not that important, I agree.
Just asking cause I like this way to implement pre conditions in methods.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Fri, May 23, 2014 at 2:21 AM, Romain Manni-Bucau
wrote:
> -0, I like having brackets, avoid bugs when upda
-0, I like having brackets, avoid bugs when updating the code, that said if
I'm alone thinking it go for it, this is not that important
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rman
Hey guys,
Is it possible to restore the ability to have inline if?
I like them cause I think it's more readable, especially to write pre
condition at the beginning of methods.
For instance ...
if (bla == null) return;
Thanks
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.to
24 matches
Mail list logo
